* Undocumented Sleep Requirements for ieee80211_ops
@ 2015-10-29 6:46 Krishna Chaitanya
2015-10-30 9:37 ` Johannes Berg
0 siblings, 1 reply; 3+ messages in thread
From: Krishna Chaitanya @ 2015-10-29 6:46 UTC (permalink / raw)
To: Johannes Berg; +Cc: linux-wireless
Hi,
>From the documentation:(mac80211.h) For the ieee80211_ops
(un)assign_vif_chanctx, there is no mention of explicit sleep
requirements (allowed/disallwoed) for the callback.
>From a quick glance at the code calling the OP, looks like we can
sleep (mutexes are used). So how should we handle such OPS? is it ok
to sleep in the callback?
We have a requirement where we need to wait for channel programming to
be done, before we allow data packets and it might take a while.
--
Thanks,
Regards,
Chaitanya T K.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Undocumented Sleep Requirements for ieee80211_ops
2015-10-29 6:46 Undocumented Sleep Requirements for ieee80211_ops Krishna Chaitanya
@ 2015-10-30 9:37 ` Johannes Berg
2015-10-30 10:11 ` Krishna Chaitanya
0 siblings, 1 reply; 3+ messages in thread
From: Johannes Berg @ 2015-10-30 9:37 UTC (permalink / raw)
To: Krishna Chaitanya; +Cc: linux-wireless
On Thu, 2015-10-29 at 12:16 +0530, Krishna Chaitanya wrote:
> Hi,
>
> From the documentation:(mac80211.h) For the ieee80211_ops
> (un)assign_vif_chanctx, there is no mention of explicit sleep
> requirements (allowed/disallwoed) for the callback.
Same goes for drv_switch_vif_chanctx().
> From a quick glance at the code calling the OP, looks like we can
> sleep (mutexes are used). So how should we handle such OPS? is it ok
> to sleep in the callback?
>
You can sleep, and I'd appreciate if you sent a patch to add
might_sleep() to the code and the appropriate documentation.
johannes
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Undocumented Sleep Requirements for ieee80211_ops
2015-10-30 9:37 ` Johannes Berg
@ 2015-10-30 10:11 ` Krishna Chaitanya
0 siblings, 0 replies; 3+ messages in thread
From: Krishna Chaitanya @ 2015-10-30 10:11 UTC (permalink / raw)
To: Johannes Berg; +Cc: linux-wireless
On Fri, Oct 30, 2015 at 3:07 PM, Johannes Berg
<johannes@sipsolutions.net> wrote:
> On Thu, 2015-10-29 at 12:16 +0530, Krishna Chaitanya wrote:
>> Hi,
>>
>> From the documentation:(mac80211.h) For the ieee80211_ops
>> (un)assign_vif_chanctx, there is no mention of explicit sleep
>> requirements (allowed/disallwoed) for the callback.
>
> Same goes for drv_switch_vif_chanctx().
Yes.
>
>> From a quick glance at the code calling the OP, looks like we can
>> sleep (mutexes are used). So how should we handle such OPS? is it ok
>> to sleep in the callback?
>>
>
> You can sleep, and I'd appreciate if you sent a patch to add
> might_sleep() to the code and the appropriate documentation.
Sure, will send a patch.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-30 10:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-29 6:46 Undocumented Sleep Requirements for ieee80211_ops Krishna Chaitanya
2015-10-30 9:37 ` Johannes Berg
2015-10-30 10:11 ` Krishna Chaitanya
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.