Re: [PATCH v3] dom variable error handled in Xenstore

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1118 bytes --]

On Thu, 2015-10-29 at 20:28 +0530, Lasya Venneti wrote:
> 
> 
> On 29 October 2015 at 15:41, Dario Faggioli <
> dario.faggioli@citrix.com> wrote:
> > On Thu, 2015-10-29 at 10:07 +0000, Wei Liu wrote:

> > > As for xc_dom_allocate, the only failure path at the moment is
> > malloc
> > > failure, which would be appropriate to use ENOMEM to represent.
> > >
> > > However if it causes too many faffs, you can just set rv to -1
> > and
> > > return to caller. I think the main point is to handle the error,
> > > either
> > > -1 or ENOMEM is fine by me.
> > >
> > Agreed but, I personally prefer -1, for consistency. :-)
> > 
> So should I proceed with -1? In that case I don't need to add the
> header...
>  
If you're still up for this (and for the other patch, which would be
great!), yes, go for -1.

Thanks and Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel