* [PATCH] drop get_xen_guest_handle()
@ 2015-10-27 8:04 Jan Beulich
2015-10-27 10:40 ` Andrew Cooper
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Jan Beulich @ 2015-10-27 8:04 UTC (permalink / raw)
To: xen-devel
Cc: Ian Campbell, Keir Fraser, Stefano Stabellini, Andrew Cooper,
Ian Jackson, Tim Deegan, Julien Grall
[-- Attachment #1: Type: text/plain, Size: 1773 bytes --]
Its use in the tools (and its apparent abuse in the hypervisor) are
long gone.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/sysctl.c
+++ b/xen/arch/x86/sysctl.c
@@ -31,8 +31,6 @@
#include <xsm/xsm.h>
#include <asm/psr.h>
-#define get_xen_guest_handle(val, hnd) do { val = (hnd).p; } while (0)
-
struct l3_cache_info {
int ret;
unsigned long size;
--- a/xen/arch/x86/x86_64/cpu_idle.c
+++ b/xen/arch/x86/x86_64/cpu_idle.c
@@ -21,9 +21,6 @@
* ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
*/
-#define __XEN_TOOLS__ /* for using get_xen_guest_handle macro */
-
-#include <xen/config.h>
#include <xen/types.h>
#include <xen/xmalloc.h>
#include <xen/guest_access.h>
--- a/xen/include/public/arch-arm.h
+++ b/xen/include/public/arch-arm.h
@@ -195,9 +195,6 @@
_sxghr_tmp->q = 0; \
_sxghr_tmp->p = val; \
} while ( 0 )
-#ifdef __XEN_TOOLS__
-#define get_xen_guest_handle(val, hnd) do { val = (hnd).p; } while (0)
-#endif
#define set_xen_guest_handle(hnd, val) set_xen_guest_handle_raw(hnd, val)
#if defined(__GNUC__) && !defined(__STRICT_ANSI__)
--- a/xen/include/public/arch-x86/xen.h
+++ b/xen/include/public/arch-x86/xen.h
@@ -54,9 +54,6 @@
#define XEN_GUEST_HANDLE(name) __XEN_GUEST_HANDLE(name)
#define XEN_GUEST_HANDLE_PARAM(name) XEN_GUEST_HANDLE(name)
#define set_xen_guest_handle_raw(hnd, val) do { (hnd).p = val; } while (0)
-#ifdef __XEN_TOOLS__
-#define get_xen_guest_handle(val, hnd) do { val = (hnd).p; } while (0)
-#endif
#define set_xen_guest_handle(hnd, val) set_xen_guest_handle_raw(hnd, val)
#if defined(__i386__)
[-- Attachment #2: drop-get_xen_guest_handle.patch --]
[-- Type: text/plain, Size: 1798 bytes --]
drop get_xen_guest_handle()
Its use in the tools (and its apparent abuse in the hypervisor) are
long gone.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/sysctl.c
+++ b/xen/arch/x86/sysctl.c
@@ -31,8 +31,6 @@
#include <xsm/xsm.h>
#include <asm/psr.h>
-#define get_xen_guest_handle(val, hnd) do { val = (hnd).p; } while (0)
-
struct l3_cache_info {
int ret;
unsigned long size;
--- a/xen/arch/x86/x86_64/cpu_idle.c
+++ b/xen/arch/x86/x86_64/cpu_idle.c
@@ -21,9 +21,6 @@
* ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
*/
-#define __XEN_TOOLS__ /* for using get_xen_guest_handle macro */
-
-#include <xen/config.h>
#include <xen/types.h>
#include <xen/xmalloc.h>
#include <xen/guest_access.h>
--- a/xen/include/public/arch-arm.h
+++ b/xen/include/public/arch-arm.h
@@ -195,9 +195,6 @@
_sxghr_tmp->q = 0; \
_sxghr_tmp->p = val; \
} while ( 0 )
-#ifdef __XEN_TOOLS__
-#define get_xen_guest_handle(val, hnd) do { val = (hnd).p; } while (0)
-#endif
#define set_xen_guest_handle(hnd, val) set_xen_guest_handle_raw(hnd, val)
#if defined(__GNUC__) && !defined(__STRICT_ANSI__)
--- a/xen/include/public/arch-x86/xen.h
+++ b/xen/include/public/arch-x86/xen.h
@@ -54,9 +54,6 @@
#define XEN_GUEST_HANDLE(name) __XEN_GUEST_HANDLE(name)
#define XEN_GUEST_HANDLE_PARAM(name) XEN_GUEST_HANDLE(name)
#define set_xen_guest_handle_raw(hnd, val) do { (hnd).p = val; } while (0)
-#ifdef __XEN_TOOLS__
-#define get_xen_guest_handle(val, hnd) do { val = (hnd).p; } while (0)
-#endif
#define set_xen_guest_handle(hnd, val) set_xen_guest_handle_raw(hnd, val)
#if defined(__i386__)
[-- Attachment #3: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drop get_xen_guest_handle()
2015-10-27 8:04 [PATCH] drop get_xen_guest_handle() Jan Beulich
@ 2015-10-27 10:40 ` Andrew Cooper
2015-10-29 12:15 ` Julien Grall
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Andrew Cooper @ 2015-10-27 10:40 UTC (permalink / raw)
To: Jan Beulich, xen-devel
Cc: Julien Grall, Keir Fraser, Stefano Stabellini, Tim Deegan,
Ian Jackson, Ian Campbell
On 27/10/15 08:04, Jan Beulich wrote:
> Its use in the tools (and its apparent abuse in the hypervisor) are
> long gone.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drop get_xen_guest_handle()
2015-10-27 8:04 [PATCH] drop get_xen_guest_handle() Jan Beulich
2015-10-27 10:40 ` Andrew Cooper
@ 2015-10-29 12:15 ` Julien Grall
2015-10-29 12:18 ` Julien Grall
2015-11-02 13:55 ` Ian Campbell
3 siblings, 0 replies; 6+ messages in thread
From: Julien Grall @ 2015-10-29 12:15 UTC (permalink / raw)
To: Jan Beulich, xen-devel
Cc: Keir Fraser, Stefano Stabellini, Andrew Cooper, Tim Deegan,
Ian Campbell, Ian Jackson
Hi Jan,
On 27/10/15 08:04, Jan Beulich wrote:
> Its use in the tools (and its apparent abuse in the hypervisor) are
> long gone.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
FWIW:
Reviewed-by: Julien Grall <julien.grall@citrix.com>
Regards,
--
Julien Grall
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drop get_xen_guest_handle()
2015-10-27 8:04 [PATCH] drop get_xen_guest_handle() Jan Beulich
2015-10-27 10:40 ` Andrew Cooper
2015-10-29 12:15 ` Julien Grall
@ 2015-10-29 12:18 ` Julien Grall
2015-10-29 12:26 ` Jan Beulich
2015-11-02 13:55 ` Ian Campbell
3 siblings, 1 reply; 6+ messages in thread
From: Julien Grall @ 2015-10-29 12:18 UTC (permalink / raw)
To: Jan Beulich, xen-devel
Cc: Keir Fraser, Stefano Stabellini, Andrew Cooper, Tim Deegan,
Ian Campbell, Ian Jackson
On 27/10/15 08:04, Jan Beulich wrote:
> --- a/xen/arch/x86/x86_64/cpu_idle.c
> +++ b/xen/arch/x86/x86_64/cpu_idle.c
> @@ -21,9 +21,6 @@
> * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> */
>
> -#define __XEN_TOOLS__ /* for using get_xen_guest_handle macro */
> -
> -#include <xen/config.h>
Hmmm... Is this line drop intentional?
Sorry I reviewed too quickly this patch.
Regards,
--
Julien Grall
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drop get_xen_guest_handle()
2015-10-29 12:18 ` Julien Grall
@ 2015-10-29 12:26 ` Jan Beulich
0 siblings, 0 replies; 6+ messages in thread
From: Jan Beulich @ 2015-10-29 12:26 UTC (permalink / raw)
To: Julien Grall
Cc: Keir Fraser, Stefano Stabellini, Andrew Cooper, Ian Jackson,
Tim Deegan, Ian Campbell, xen-devel
>>> On 29.10.15 at 13:18, <julien.grall@citrix.com> wrote:
> On 27/10/15 08:04, Jan Beulich wrote:
>> --- a/xen/arch/x86/x86_64/cpu_idle.c
>> +++ b/xen/arch/x86/x86_64/cpu_idle.c
>> @@ -21,9 +21,6 @@
>> *
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> */
>>
>> -#define __XEN_TOOLS__ /* for using get_xen_guest_handle macro */
>> -
>> -#include <xen/config.h>
>
> Hmmm... Is this line drop intentional?
Yes, it is. We're trying to get rid of all the explicit xen/config.h
inclusions, but rather as a side effect than by a special patch series.
Jan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drop get_xen_guest_handle()
2015-10-27 8:04 [PATCH] drop get_xen_guest_handle() Jan Beulich
` (2 preceding siblings ...)
2015-10-29 12:18 ` Julien Grall
@ 2015-11-02 13:55 ` Ian Campbell
3 siblings, 0 replies; 6+ messages in thread
From: Ian Campbell @ 2015-11-02 13:55 UTC (permalink / raw)
To: Jan Beulich, xen-devel
Cc: Keir Fraser, Stefano Stabellini, Andrew Cooper, Tim Deegan,
Julien Grall, Ian Jackson
On Tue, 2015-10-27 at 02:04 -0600, Jan Beulich wrote:
> Its use in the tools (and its apparent abuse in the hypervisor) are
> long gone.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-11-02 13:55 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-27 8:04 [PATCH] drop get_xen_guest_handle() Jan Beulich
2015-10-27 10:40 ` Andrew Cooper
2015-10-29 12:15 ` Julien Grall
2015-10-29 12:18 ` Julien Grall
2015-10-29 12:26 ` Jan Beulich
2015-11-02 13:55 ` Ian Campbell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.