* [PATCH] libxlu: avoid linker warnings
@ 2015-10-29 10:05 Jan Beulich
2015-10-29 10:36 ` Wei Liu
2015-11-02 14:01 ` Ian Campbell
0 siblings, 2 replies; 6+ messages in thread
From: Jan Beulich @ 2015-10-29 10:05 UTC (permalink / raw)
To: xen-devel; +Cc: Ian Campbell, Ian Jackson, Wei Liu, Stefano Stabellini
[-- Attachment #1: Type: text/plain, Size: 1254 bytes --]
Recent ld warns about libxenlight.so's dependency libraries not being
available, which can be easily avoided by not just passing the raw
library name on ld's command line.
In the course of checking how things fit together (I originally
suspected the warning to come from the linking of xl) I also noticed a
stray L in SHLIB_libxenguest, which gets removed at once.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/tools/Rules.mk
+++ b/tools/Rules.mk
@@ -40,7 +40,7 @@ SHLIB_libxenctrl = -Wl,-rpath-link=$(XE
CFLAGS_libxenguest = -I$(XEN_LIBXC)/include $(CFLAGS_xeninclude)
LDLIBS_libxenguest = $(XEN_LIBXC)/libxenguest$(libextension)
-SHLIB_libxenguest = -Wl,-rpath-link=L$(XEN_LIBXC)
+SHLIB_libxenguest = -Wl,-rpath-link=$(XEN_LIBXC)
CFLAGS_libxenstore = -I$(XEN_XENSTORE)/include $(CFLAGS_xeninclude)
LDLIBS_libxenstore = $(XEN_XENSTORE)/libxenstore$(libextension)
--- a/tools/libxl/Makefile
+++ b/tools/libxl/Makefile
@@ -41,7 +41,7 @@ LDFLAGS += $(PTHREAD_LDFLAGS)
LIBXL_LIBS += $(PTHREAD_LIBS)
LIBXL_LIBS += $(LIBXL_LIBS-y)
-LIBXLU_LIBS = libxenlight.so
+LIBXLU_LIBS = $(LDLIBS_libxenlight)
LIBXL_OBJS-y = osdeps.o libxl_paths.o libxl_bootloader.o flexarray.o
ifeq ($(LIBXL_BLKTAP),y)
[-- Attachment #2: xl-ld-warnings.patch --]
[-- Type: text/plain, Size: 1281 bytes --]
libxlu: avoid linker warnings
Recent ld warns about libxenlight.so's dependency libraries not being
available, which can be easily avoided by not just passing the raw
library name on ld's command line.
In the course of checking how things fit together (I originally
suspected the warning to come from the linking of xl) I also noticed a
stray L in SHLIB_libxenguest, which gets removed at once.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/tools/Rules.mk
+++ b/tools/Rules.mk
@@ -40,7 +40,7 @@ SHLIB_libxenctrl = -Wl,-rpath-link=$(XE
CFLAGS_libxenguest = -I$(XEN_LIBXC)/include $(CFLAGS_xeninclude)
LDLIBS_libxenguest = $(XEN_LIBXC)/libxenguest$(libextension)
-SHLIB_libxenguest = -Wl,-rpath-link=L$(XEN_LIBXC)
+SHLIB_libxenguest = -Wl,-rpath-link=$(XEN_LIBXC)
CFLAGS_libxenstore = -I$(XEN_XENSTORE)/include $(CFLAGS_xeninclude)
LDLIBS_libxenstore = $(XEN_XENSTORE)/libxenstore$(libextension)
--- a/tools/libxl/Makefile
+++ b/tools/libxl/Makefile
@@ -41,7 +41,7 @@ LDFLAGS += $(PTHREAD_LDFLAGS)
LIBXL_LIBS += $(PTHREAD_LIBS)
LIBXL_LIBS += $(LIBXL_LIBS-y)
-LIBXLU_LIBS = libxenlight.so
+LIBXLU_LIBS = $(LDLIBS_libxenlight)
LIBXL_OBJS-y = osdeps.o libxl_paths.o libxl_bootloader.o flexarray.o
ifeq ($(LIBXL_BLKTAP),y)
[-- Attachment #3: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] libxlu: avoid linker warnings
2015-10-29 10:05 [PATCH] libxlu: avoid linker warnings Jan Beulich
@ 2015-10-29 10:36 ` Wei Liu
2015-11-02 14:01 ` Ian Campbell
1 sibling, 0 replies; 6+ messages in thread
From: Wei Liu @ 2015-10-29 10:36 UTC (permalink / raw)
To: Jan Beulich
Cc: Ian Campbell, xen-devel, Wei Liu, Ian Jackson, Stefano Stabellini
On Thu, Oct 29, 2015 at 04:05:26AM -0600, Jan Beulich wrote:
> Recent ld warns about libxenlight.so's dependency libraries not being
> available, which can be easily avoided by not just passing the raw
> library name on ld's command line.
>
> In the course of checking how things fit together (I originally
> suspected the warning to come from the linking of xl) I also noticed a
> stray L in SHLIB_libxenguest, which gets removed at once.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> --- a/tools/Rules.mk
> +++ b/tools/Rules.mk
> @@ -40,7 +40,7 @@ SHLIB_libxenctrl = -Wl,-rpath-link=$(XE
>
> CFLAGS_libxenguest = -I$(XEN_LIBXC)/include $(CFLAGS_xeninclude)
> LDLIBS_libxenguest = $(XEN_LIBXC)/libxenguest$(libextension)
> -SHLIB_libxenguest = -Wl,-rpath-link=L$(XEN_LIBXC)
> +SHLIB_libxenguest = -Wl,-rpath-link=$(XEN_LIBXC)
Heh, I wonder how this ever worked, but it turns out SHLIB_libxenguest
is not used in tree.
>
> CFLAGS_libxenstore = -I$(XEN_XENSTORE)/include $(CFLAGS_xeninclude)
> LDLIBS_libxenstore = $(XEN_XENSTORE)/libxenstore$(libextension)
> --- a/tools/libxl/Makefile
> +++ b/tools/libxl/Makefile
> @@ -41,7 +41,7 @@ LDFLAGS += $(PTHREAD_LDFLAGS)
> LIBXL_LIBS += $(PTHREAD_LIBS)
> LIBXL_LIBS += $(LIBXL_LIBS-y)
>
> -LIBXLU_LIBS = libxenlight.so
> +LIBXLU_LIBS = $(LDLIBS_libxenlight)
>
This looks correct to me.
Acked-by: Wei Liu <wei.liu2@citrix.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] libxlu: avoid linker warnings
2015-10-29 10:05 [PATCH] libxlu: avoid linker warnings Jan Beulich
2015-10-29 10:36 ` Wei Liu
@ 2015-11-02 14:01 ` Ian Campbell
2015-11-02 14:25 ` Ian Campbell
2015-11-03 10:02 ` Jan Beulich
1 sibling, 2 replies; 6+ messages in thread
From: Ian Campbell @ 2015-11-02 14:01 UTC (permalink / raw)
To: Jan Beulich, xen-devel; +Cc: Ian Jackson, Wei Liu, Stefano Stabellini
On Thu, 2015-10-29 at 04:05 -0600, Jan Beulich wrote:
> Recent ld warns about libxenlight.so's dependency libraries not being
> available, which can be easily avoided by not just passing the raw
> library name on ld's command line.
> In the course of checking how things fit together (I originally
> suspected the warning to come from the linking of xl) I also noticed a
> stray L in SHLIB_libxenguest, which gets removed at once.
Looks like I (unwittingly) fixed this aspect in
http://lists.xen.org/archives/html/xen-devel/2015-10/msg02256.html
too. I can easily rebase.
Since you have a pickier ld than me I wonder if you would mind trying my patch out on top of yours too?
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
> --- a/tools/Rules.mk
> +++ b/tools/Rules.mk
> @@ -40,7 +40,7 @@ SHLIB_libxenctrl = -Wl,-rpath-link=$(XE
>
> CFLAGS_libxenguest = -I$(XEN_LIBXC)/include $(CFLAGS_xeninclude)
> LDLIBS_libxenguest = $(XEN_LIBXC)/libxenguest$(libextension)
> -SHLIB_libxenguest = -Wl,-rpath-link=L$(XEN_LIBXC)
> +SHLIB_libxenguest = -Wl,-rpath-link=$(XEN_LIBXC)
>
> CFLAGS_libxenstore = -I$(XEN_XENSTORE)/include $(CFLAGS_xeninclude)
> LDLIBS_libxenstore = $(XEN_XENSTORE)/libxenstore$(libextension)
> --- a/tools/libxl/Makefile
> +++ b/tools/libxl/Makefile
> @@ -41,7 +41,7 @@ LDFLAGS += $(PTHREAD_LDFLAGS)
> LIBXL_LIBS += $(PTHREAD_LIBS)
> LIBXL_LIBS += $(LIBXL_LIBS-y)
>
> -LIBXLU_LIBS = libxenlight.so
> +LIBXLU_LIBS = $(LDLIBS_libxenlight)
>
> LIBXL_OBJS-y = osdeps.o libxl_paths.o libxl_bootloader.o flexarray.o
> ifeq ($(LIBXL_BLKTAP),y)
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] libxlu: avoid linker warnings
2015-11-02 14:01 ` Ian Campbell
@ 2015-11-02 14:25 ` Ian Campbell
2015-11-03 10:02 ` Jan Beulich
1 sibling, 0 replies; 6+ messages in thread
From: Ian Campbell @ 2015-11-02 14:25 UTC (permalink / raw)
To: Jan Beulich, xen-devel; +Cc: Wei Liu, Ian Jackson, Stefano Stabellini
On Mon, 2015-11-02 at 14:01 +0000, Ian Campbell wrote:
> On Thu, 2015-10-29 at 04:05 -0600, Jan Beulich wrote:
> > Recent ld warns about libxenlight.so's dependency libraries not being
> > available, which can be easily avoided by not just passing the raw
> > library name on ld's command line.
>
> > In the course of checking how things fit together (I originally
> > suspected the warning to come from the linking of xl) I also noticed a
> > stray L in SHLIB_libxenguest, which gets removed at once.
>
> Looks like I (unwittingly) fixed this aspect in
Actually, no I didn't.
> http://lists.xen.org/archives/html/xen-devel/2015-10/msg02256.html
> too. I can easily rebase.
easily rebase> that remains the case.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] libxlu: avoid linker warnings
2015-11-02 14:01 ` Ian Campbell
2015-11-02 14:25 ` Ian Campbell
@ 2015-11-03 10:02 ` Jan Beulich
2015-11-03 12:12 ` Ian Campbell
1 sibling, 1 reply; 6+ messages in thread
From: Jan Beulich @ 2015-11-03 10:02 UTC (permalink / raw)
To: Ian Campbell; +Cc: Ian Jackson, Wei Liu, xen-devel, Stefano Stabellini
>>> On 02.11.15 at 15:01, <ian.campbell@citrix.com> wrote:
> On Thu, 2015-10-29 at 04:05 -0600, Jan Beulich wrote:
>> Recent ld warns about libxenlight.so's dependency libraries not being
>> available, which can be easily avoided by not just passing the raw
>> library name on ld's command line.
>
>> In the course of checking how things fit together (I originally
>> suspected the warning to come from the linking of xl) I also noticed a
>> stray L in SHLIB_libxenguest, which gets removed at once.
>
> Looks like I (unwittingly) fixed this aspect in
>
> http://lists.xen.org/archives/html/xen-devel/2015-10/msg02256.html
> too. I can easily rebase.
>
> Since you have a pickier ld than me I wonder if you would mind trying my
> patch out on top of yours too?
No warnings.
Jan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] libxlu: avoid linker warnings
2015-11-03 10:02 ` Jan Beulich
@ 2015-11-03 12:12 ` Ian Campbell
0 siblings, 0 replies; 6+ messages in thread
From: Ian Campbell @ 2015-11-03 12:12 UTC (permalink / raw)
To: Jan Beulich; +Cc: Ian Jackson, Wei Liu, xen-devel, Stefano Stabellini
On Tue, 2015-11-03 at 03:02 -0700, Jan Beulich wrote:
> > > > On 02.11.15 at 15:01, <ian.campbell@citrix.com> wrote:
> > On Thu, 2015-10-29 at 04:05 -0600, Jan Beulich wrote:
> > > Recent ld warns about libxenlight.so's dependency libraries not being
> > > available, which can be easily avoided by not just passing the raw
> > > library name on ld's command line.
> >
> > > In the course of checking how things fit together (I originally
> > > suspected the warning to come from the linking of xl) I also noticed
> > > a
> > > stray L in SHLIB_libxenguest, which gets removed at once.
> >
> > Looks like I (unwittingly) fixed this aspect in
> >
> > http://lists.xen.org/archives/html/xen-devel/2015-10/msg02256.html
> > too. I can easily rebase.
> >
> > Since you have a pickier ld than me I wonder if you would mind trying
> > my
> > patch out on top of yours too?
>
> No warnings.
Thanks!
>
> Jan
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-11-03 12:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-29 10:05 [PATCH] libxlu: avoid linker warnings Jan Beulich
2015-10-29 10:36 ` Wei Liu
2015-11-02 14:01 ` Ian Campbell
2015-11-02 14:25 ` Ian Campbell
2015-11-03 10:02 ` Jan Beulich
2015-11-03 12:12 ` Ian Campbell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.