* [PATCH] timer-op: demote a debugging message to really be debugging only
@ 2015-10-30 17:42 Jan Beulich
2015-10-30 18:58 ` Andrew Cooper
0 siblings, 1 reply; 3+ messages in thread
From: Jan Beulich @ 2015-10-30 17:42 UTC (permalink / raw)
To: xen-devel; +Cc: Ian Campbell, Keir Fraser, Ian Jackson, Tim Deegan
[-- Attachment #1: Type: text/plain, Size: 754 bytes --]
The issue the message points out may have been of relevance during the
early days, but shouldn't anymore.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/common/schedule.c
+++ b/xen/common/schedule.c
@@ -1118,8 +1118,8 @@ long do_set_timer_op(s_time_t timeout)
* timeout in this case can burn a lot of CPU. We therefore go for a
* reasonable middleground of triggering a timer event in 100ms.
*/
- gprintk(XENLOG_INFO, "Warning: huge timeout set: %"PRIx64"\n",
- (uint64_t)timeout);
+ gdprintk(XENLOG_INFO, "Warning: huge timeout set: %"PRIx64"\n",
+ timeout);
set_timer(&v->singleshot_timer, NOW() + MILLISECS(100));
}
else
[-- Attachment #2: hcall-printk-1.patch --]
[-- Type: text/plain, Size: 816 bytes --]
timer-op: demote a debugging message to really be debugging only
The issue the message points out may have been of relevance during the
early days, but shouldn't anymore.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/common/schedule.c
+++ b/xen/common/schedule.c
@@ -1118,8 +1118,8 @@ long do_set_timer_op(s_time_t timeout)
* timeout in this case can burn a lot of CPU. We therefore go for a
* reasonable middleground of triggering a timer event in 100ms.
*/
- gprintk(XENLOG_INFO, "Warning: huge timeout set: %"PRIx64"\n",
- (uint64_t)timeout);
+ gdprintk(XENLOG_INFO, "Warning: huge timeout set: %"PRIx64"\n",
+ timeout);
set_timer(&v->singleshot_timer, NOW() + MILLISECS(100));
}
else
[-- Attachment #3: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] timer-op: demote a debugging message to really be debugging only
2015-10-30 17:42 [PATCH] timer-op: demote a debugging message to really be debugging only Jan Beulich
@ 2015-10-30 18:58 ` Andrew Cooper
2015-11-02 14:41 ` Ian Campbell
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Cooper @ 2015-10-30 18:58 UTC (permalink / raw)
To: Jan Beulich, xen-devel; +Cc: Ian Campbell, Ian Jackson, Keir Fraser, Tim Deegan
On 30/10/15 17:42, Jan Beulich wrote:
> The issue the message points out may have been of relevance during the
> early days, but shouldn't anymore.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] timer-op: demote a debugging message to really be debugging only
2015-10-30 18:58 ` Andrew Cooper
@ 2015-11-02 14:41 ` Ian Campbell
0 siblings, 0 replies; 3+ messages in thread
From: Ian Campbell @ 2015-11-02 14:41 UTC (permalink / raw)
To: Andrew Cooper, Jan Beulich, xen-devel
Cc: Ian Jackson, Keir Fraser, Tim Deegan
On Fri, 2015-10-30 at 18:58 +0000, Andrew Cooper wrote:
> On 30/10/15 17:42, Jan Beulich wrote:
> > The issue the message points out may have been of relevance during the
> > early days, but shouldn't anymore.
> >
> > Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-11-02 14:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-30 17:42 [PATCH] timer-op: demote a debugging message to really be debugging only Jan Beulich
2015-10-30 18:58 ` Andrew Cooper
2015-11-02 14:41 ` Ian Campbell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.