Re: implement put_char() in cdc-acm

[Oliver Neukum <oneukum-IBi9RG/b67k@public.gmane.org>]

On Mon, 2015-11-02 at 21:27 +0100, Sven Brauch wrote:
> On 02/11/15 12:32, Oliver Neukum wrote:
> > given this test I will submit the patch.
> Mind you, I don't know if the improvement is due to your patch or other
> things. I didn't test the new kernel without your patch; should I?

If you find the time. But testing with enlarged buffers is
more important.

> > Sven, can you ramp up the buffers in the manner Peter suggested
> > and retest? It looks like the throttling code isn't perfect yet,
> > but a larger buffer may make its performance good enough.
> I'll try as soon as possible, but I'm sceptical. That still doesn't
> guarantee that no data is lost, which feels bad to me.

That cannot be guaranteed on a remote line. Basically
your device is special by doing implied flow control
when the host stops requesting data.

	Regards
		Oliver


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html