Re: implement put_char() in cdc-acm

[Sven Brauch <mail-ITmcY+a7/CDoK6nBLMlh1Q@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1447 bytes --]

Hey,

On 28/10/15 13:23, Peter Hurley wrote:
> Sven, please test Oliver's patch on that tree.
I will do as soon as I get around to it, I hope on the weekend.

> Lastly, please confirm your test method/termios settings (iow, are
> you using a reproducer or just 'cat big_file > /dev/ttyACM1')
Sorry, what exactly do you mean by "reproducer"? I have a
microcontroller which acquires and transmits the data on the device end
of the USB connection. The data flows from device to host.

> I would much rather rework URB flow + unthrottle, as I previously
> outlined in the original thread instead of introducing another
> buffering layer.
From my non-kernel-dev point of view, this seems the way to go if the
strategy in my patch (technical flaws aside) is not acceptable.
Everything else, i.e. larger buffers or less delay, will certainly be a
welcome improvement but still does not guarantee data delivery.

A very similar patch, by the way, was already submitted a few years ago
[1] but not accepted for similar reasons as brought up here (I only
found that thread later on). That patch has a more elegant
implementation than mine, so you might prefer reviving that, if it
becomes relevant.

I will be happy to test any fixes which come up, although I can't
promise I can get around to do it immediately.

Thanks and best regards,
Sven

_______________
[1] https://marc.info/?l=linux-kernel&m=130754754705303&w=2


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]