Re: [RFC PATCH v2 03/16] configure: #define SEABIOS_PATH and OVMF_PATH

[Ian Campbell <ian.campbell@citrix.com>]

On Mon, 2015-10-26 at 16:03 +0000, Anthony PERARD wrote:
> Those paths are to be used by libxl, in order to load the firmware in
> memory. If a system path is not define, then this default to the Xen
> firmware directory.

AIUI these are both existing variables which are right now exposed only to
the Makefiles and not to the C code, and this adds the latter.

That only matters because I then don't have to think about the semantics of
a "new" option, what the matching command line option behaviour is, docs
etc.

> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> 
> ---
> Please, run ./autogen.sh on this patch.
> ---
>  tools/configure.ac | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/tools/configure.ac b/tools/configure.ac
> index 6c70040..6929006 100644
> --- a/tools/configure.ac
> +++ b/tools/configure.ac
> @@ -212,6 +212,9 @@ AC_ARG_WITH([system-seabios],
>      esac
>  ],[])
>  AC_SUBST(seabios_path)
> +AC_DEFINE_UNQUOTED([SEABIOS_PATH],
> +                   ["${seabios_path:-$XENFIRMWAREDIR/seabios.bin}"],
> +                   [SeaBIOS path])

I thought ${foo:-bar} might not be POSIXly-correct, but it turns out it is
http://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html ,
so good!


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel