Re: [RFC PATCH v2 11/16] hvmloader: No BIOS ROM image allowed to be compiled in

[Ian Campbell <ian.campbell@citrix.com>]

On Mon, 2015-10-26 at 16:03 +0000, Anthony PERARD wrote:

This might invalidate some of my earlier comments about reusing bios_addr,
in which case that other commit ought to make reference to the eventual
goal.

But...
> @@ -432,9 +424,9 @@ int main(void)
>      if ( SCRATCH_PHYSICAL_ADDRESS != scratch_start )
>          printf(" %05x-%05lx: Scratch space\n",
>                 SCRATCH_PHYSICAL_ADDRESS, scratch_start);
> -    printf(" %05x-%05x: Main BIOS\n",
> -           bios->bios_address,
> -           bios->bios_address + bios->image_size - 1);
> +    /* printf(" %05x-%05x: Main BIOS\n", */
> +           /* bios->bios_address, */
> +           /* bios->bios_address + bios->image_size - 1); */

A way should be found to keep this useful debug output, which may involve
having the per-bios code propagate what they have done, or logging it
themselves etc.

Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel