* [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro
@ 2015-11-09 15:17 Ranjith
2015-11-09 16:55 ` Hartley Sweeten
0 siblings, 1 reply; 9+ messages in thread
From: Ranjith @ 2015-11-09 15:17 UTC (permalink / raw)
To: gregkh; +Cc: abbotti, hsweeten, devel, linux-kernel, ranjithece24
BIT macro is used for defining BIT location instead of
shifting operator - coding style issue
Signed-off-by: Ranjith <ranjithece24@gmail.com>
---
drivers/staging/comedi/drivers/comedi_parport.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/comedi_parport.c b/drivers/staging/comedi/drivers/comedi_parport.c
index 15a4093..1bf8ddc 100644
--- a/drivers/staging/comedi/drivers/comedi_parport.c
+++ b/drivers/staging/comedi/drivers/comedi_parport.c
@@ -75,8 +75,8 @@
#define PARPORT_DATA_REG 0x00
#define PARPORT_STATUS_REG 0x01
#define PARPORT_CTRL_REG 0x02
-#define PARPORT_CTRL_IRQ_ENA (1 << 4)
-#define PARPORT_CTRL_BIDIR_ENA (1 << 5)
+#define PARPORT_CTRL_IRQ_ENA BIT(4)
+#define PARPORT_CTRL_BIDIR_ENA BIT(5)
static int parport_data_reg_insn_bits(struct comedi_device *dev,
struct comedi_subdevice *s,
--
1.7.10.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* RE: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro
2015-11-09 15:17 [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro Ranjith
@ 2015-11-09 16:55 ` Hartley Sweeten
0 siblings, 0 replies; 9+ messages in thread
From: Hartley Sweeten @ 2015-11-09 16:55 UTC (permalink / raw)
To: Ranjith, gregkh@linuxfoundation.org
Cc: abbotti@mev.co.uk, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
On Monday, November 09, 2015 8:17 AM, Ranjith wrote:
> BIT macro is used for defining BIT location instead of
> shifting operator - coding style issue
>
> Signed-off-by: Ranjith <ranjithece24@gmail.com>
> ---
> drivers/staging/comedi/drivers/comedi_parport.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/comedi_parport.c b/drivers/staging/comedi/drivers/comedi_parport.c
> index 15a4093..1bf8ddc 100644
> --- a/drivers/staging/comedi/drivers/comedi_parport.c
> +++ b/drivers/staging/comedi/drivers/comedi_parport.c
> @@ -75,8 +75,8 @@
> #define PARPORT_DATA_REG 0x00
> #define PARPORT_STATUS_REG 0x01
> #define PARPORT_CTRL_REG 0x02
> -#define PARPORT_CTRL_IRQ_ENA (1 << 4)
> -#define PARPORT_CTRL_BIDIR_ENA (1 << 5)
> +#define PARPORT_CTRL_IRQ_ENA BIT(4)
> +#define PARPORT_CTRL_BIDIR_ENA BIT(5)
>
> static int parport_data_reg_insn_bits(struct comedi_device *dev,
> struct comedi_subdevice *s,
Hello,
No problems with the patch but your sign-off needs to include your
full legal name.
Regards,
Hartley
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro
@ 2015-11-09 17:48 Ranjith T
2015-11-11 13:44 ` Ranjith T
0 siblings, 1 reply; 9+ messages in thread
From: Ranjith T @ 2015-11-09 17:48 UTC (permalink / raw)
To: gregkh; +Cc: abbotti, hsweeten, devel, linux-kernel, ranjithece24
BIT macro is used for defining BIT location instead of
shifting operator - coding style issue
Signed-off-by: Ranjith T <ranjithece24@gmail.com>
---
drivers/staging/comedi/drivers/comedi_parport.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/comedi_parport.c b/drivers/staging/comedi/drivers/comedi_parport.c
index 15a4093..1bf8ddc 100644
--- a/drivers/staging/comedi/drivers/comedi_parport.c
+++ b/drivers/staging/comedi/drivers/comedi_parport.c
@@ -75,8 +75,8 @@
#define PARPORT_DATA_REG 0x00
#define PARPORT_STATUS_REG 0x01
#define PARPORT_CTRL_REG 0x02
-#define PARPORT_CTRL_IRQ_ENA (1 << 4)
-#define PARPORT_CTRL_BIDIR_ENA (1 << 5)
+#define PARPORT_CTRL_IRQ_ENA BIT(4)
+#define PARPORT_CTRL_BIDIR_ENA BIT(5)
static int parport_data_reg_insn_bits(struct comedi_device *dev,
struct comedi_subdevice *s,
--
1.7.10.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro
2015-11-09 17:48 Ranjith T
@ 2015-11-11 13:44 ` Ranjith T
2015-11-11 14:11 ` Ian Abbott
0 siblings, 1 reply; 9+ messages in thread
From: Ranjith T @ 2015-11-11 13:44 UTC (permalink / raw)
To: gregkh; +Cc: Ian Abbott, hsweeten, devel, linux-kernel, Ranjith T
Is this patch is fine?.
Thanks,
Ranjith T.
On Mon, Nov 9, 2015 at 11:18 PM, Ranjith T <ranjithece24@gmail.com> wrote:
> BIT macro is used for defining BIT location instead of
> shifting operator - coding style issue
>
> Signed-off-by: Ranjith T <ranjithece24@gmail.com>
> ---
> drivers/staging/comedi/drivers/comedi_parport.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/comedi_parport.c b/drivers/staging/comedi/drivers/comedi_parport.c
> index 15a4093..1bf8ddc 100644
> --- a/drivers/staging/comedi/drivers/comedi_parport.c
> +++ b/drivers/staging/comedi/drivers/comedi_parport.c
> @@ -75,8 +75,8 @@
> #define PARPORT_DATA_REG 0x00
> #define PARPORT_STATUS_REG 0x01
> #define PARPORT_CTRL_REG 0x02
> -#define PARPORT_CTRL_IRQ_ENA (1 << 4)
> -#define PARPORT_CTRL_BIDIR_ENA (1 << 5)
> +#define PARPORT_CTRL_IRQ_ENA BIT(4)
> +#define PARPORT_CTRL_BIDIR_ENA BIT(5)
>
> static int parport_data_reg_insn_bits(struct comedi_device *dev,
> struct comedi_subdevice *s,
> --
> 1.7.10.4
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro
2015-11-11 13:44 ` Ranjith T
@ 2015-11-11 14:11 ` Ian Abbott
2015-11-11 14:18 ` Ranjith T
0 siblings, 1 reply; 9+ messages in thread
From: Ian Abbott @ 2015-11-11 14:11 UTC (permalink / raw)
To: Ranjith T, gregkh; +Cc: hsweeten, devel, linux-kernel
On 11/11/2015 13:44, Ranjith T wrote:
> Is this patch is fine?.
>
> Thanks,
> Ranjith T.
Fine apart from the "Signed-off-by" line. I'm guessing your last name
isn't really "T".
> On Mon, Nov 9, 2015 at 11:18 PM, Ranjith T <ranjithece24@gmail.com> wrote:
>> BIT macro is used for defining BIT location instead of
>> shifting operator - coding style issue
>>
>> Signed-off-by: Ranjith T <ranjithece24@gmail.com>
>> ---
>> drivers/staging/comedi/drivers/comedi_parport.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/comedi/drivers/comedi_parport.c b/drivers/staging/comedi/drivers/comedi_parport.c
>> index 15a4093..1bf8ddc 100644
>> --- a/drivers/staging/comedi/drivers/comedi_parport.c
>> +++ b/drivers/staging/comedi/drivers/comedi_parport.c
>> @@ -75,8 +75,8 @@
>> #define PARPORT_DATA_REG 0x00
>> #define PARPORT_STATUS_REG 0x01
>> #define PARPORT_CTRL_REG 0x02
>> -#define PARPORT_CTRL_IRQ_ENA (1 << 4)
>> -#define PARPORT_CTRL_BIDIR_ENA (1 << 5)
>> +#define PARPORT_CTRL_IRQ_ENA BIT(4)
>> +#define PARPORT_CTRL_BIDIR_ENA BIT(5)
>>
>> static int parport_data_reg_insn_bits(struct comedi_device *dev,
>> struct comedi_subdevice *s,
>> --
>> 1.7.10.4
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro
2015-11-11 14:11 ` Ian Abbott
@ 2015-11-11 14:18 ` Ranjith T
2015-11-11 14:36 ` Ian Abbott
0 siblings, 1 reply; 9+ messages in thread
From: Ranjith T @ 2015-11-11 14:18 UTC (permalink / raw)
To: Ian Abbott; +Cc: gregkh, hsweeten, devel, linux-kernel
Actually my name is Ranjith and father name is Thangavel. So I used to
mention my name as Ranjith T.
Thanks,
Ranjith T
On Wed, Nov 11, 2015 at 7:41 PM, Ian Abbott <abbotti@mev.co.uk> wrote:
> On 11/11/2015 13:44, Ranjith T wrote:
>>
>> Is this patch is fine?.
>>
>> Thanks,
>> Ranjith T.
>
>
> Fine apart from the "Signed-off-by" line. I'm guessing your last name isn't
> really "T".
>
>
>> On Mon, Nov 9, 2015 at 11:18 PM, Ranjith T <ranjithece24@gmail.com> wrote:
>>>
>>> BIT macro is used for defining BIT location instead of
>>> shifting operator - coding style issue
>>>
>>> Signed-off-by: Ranjith T <ranjithece24@gmail.com>
>>> ---
>>> drivers/staging/comedi/drivers/comedi_parport.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/staging/comedi/drivers/comedi_parport.c
>>> b/drivers/staging/comedi/drivers/comedi_parport.c
>>> index 15a4093..1bf8ddc 100644
>>> --- a/drivers/staging/comedi/drivers/comedi_parport.c
>>> +++ b/drivers/staging/comedi/drivers/comedi_parport.c
>>> @@ -75,8 +75,8 @@
>>> #define PARPORT_DATA_REG 0x00
>>> #define PARPORT_STATUS_REG 0x01
>>> #define PARPORT_CTRL_REG 0x02
>>> -#define PARPORT_CTRL_IRQ_ENA (1 << 4)
>>> -#define PARPORT_CTRL_BIDIR_ENA (1 << 5)
>>> +#define PARPORT_CTRL_IRQ_ENA BIT(4)
>>> +#define PARPORT_CTRL_BIDIR_ENA BIT(5)
>>>
>>> static int parport_data_reg_insn_bits(struct comedi_device *dev,
>>> struct comedi_subdevice *s,
>>> --
>>> 1.7.10.4
>
>
> --
> -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
> -=( Web: http://www.mev.co.uk/ )=-
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro
2015-11-11 14:18 ` Ranjith T
@ 2015-11-11 14:36 ` Ian Abbott
0 siblings, 0 replies; 9+ messages in thread
From: Ian Abbott @ 2015-11-11 14:36 UTC (permalink / raw)
To: Ranjith T; +Cc: gregkh, hsweeten, devel, linux-kernel
On 11/11/15 14:18, Ranjith T wrote:
> Actually my name is Ranjith and father name is Thangavel. So I used to
> mention my name as Ranjith T.
How do you write your name on legal documents? That is what you should
use on the patch's "Signed-off-by:" line, and on the email's "From:" line.
Thanks.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro
@ 2015-11-11 15:54 Ranjith Thangavel
2015-11-12 17:57 ` Ian Abbott
0 siblings, 1 reply; 9+ messages in thread
From: Ranjith Thangavel @ 2015-11-11 15:54 UTC (permalink / raw)
To: gregkh; +Cc: abbotti, hsweeten, devel, linux-kernel, ranjithece24
BIT macro is used for defining BIT location instead of
shifting operator - coding style issue
Signed-off-by: Ranjith Thangavel <ranjithece24@gmail.com>
---
drivers/staging/comedi/drivers/comedi_parport.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/comedi_parport.c b/drivers/staging/comedi/drivers/comedi_parport.c
index 15a4093..1bf8ddc 100644
--- a/drivers/staging/comedi/drivers/comedi_parport.c
+++ b/drivers/staging/comedi/drivers/comedi_parport.c
@@ -75,8 +75,8 @@
#define PARPORT_DATA_REG 0x00
#define PARPORT_STATUS_REG 0x01
#define PARPORT_CTRL_REG 0x02
-#define PARPORT_CTRL_IRQ_ENA (1 << 4)
-#define PARPORT_CTRL_BIDIR_ENA (1 << 5)
+#define PARPORT_CTRL_IRQ_ENA BIT(4)
+#define PARPORT_CTRL_BIDIR_ENA BIT(5)
static int parport_data_reg_insn_bits(struct comedi_device *dev,
struct comedi_subdevice *s,
--
1.7.10.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro
2015-11-11 15:54 Ranjith Thangavel
@ 2015-11-12 17:57 ` Ian Abbott
0 siblings, 0 replies; 9+ messages in thread
From: Ian Abbott @ 2015-11-12 17:57 UTC (permalink / raw)
To: Ranjith Thangavel, gregkh; +Cc: hsweeten, devel, linux-kernel
On 11/11/15 15:54, Ranjith Thangavel wrote:
> BIT macro is used for defining BIT location instead of
> shifting operator - coding style issue
>
> Signed-off-by: Ranjith Thangavel <ranjithece24@gmail.com>
> ---
> drivers/staging/comedi/drivers/comedi_parport.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/comedi_parport.c b/drivers/staging/comedi/drivers/comedi_parport.c
> index 15a4093..1bf8ddc 100644
> --- a/drivers/staging/comedi/drivers/comedi_parport.c
> +++ b/drivers/staging/comedi/drivers/comedi_parport.c
> @@ -75,8 +75,8 @@
> #define PARPORT_DATA_REG 0x00
> #define PARPORT_STATUS_REG 0x01
> #define PARPORT_CTRL_REG 0x02
> -#define PARPORT_CTRL_IRQ_ENA (1 << 4)
> -#define PARPORT_CTRL_BIDIR_ENA (1 << 5)
> +#define PARPORT_CTRL_IRQ_ENA BIT(4)
> +#define PARPORT_CTRL_BIDIR_ENA BIT(5)
>
> static int parport_data_reg_insn_bits(struct comedi_device *dev,
> struct comedi_subdevice *s,
>
Thanks!
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2015-11-12 17:57 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-09 15:17 [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro Ranjith
2015-11-09 16:55 ` Hartley Sweeten
-- strict thread matches above, loose matches on Subject: below --
2015-11-09 17:48 Ranjith T
2015-11-11 13:44 ` Ranjith T
2015-11-11 14:11 ` Ian Abbott
2015-11-11 14:18 ` Ranjith T
2015-11-11 14:36 ` Ian Abbott
2015-11-11 15:54 Ranjith Thangavel
2015-11-12 17:57 ` Ian Abbott
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.