All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] fetch2: Remove crazy code in unpack
@ 2015-11-10  9:56 Richard Purdie
  0 siblings, 0 replies; only message in thread
From: Richard Purdie @ 2015-11-10  9:56 UTC (permalink / raw)
  To: bitbake-devel

This looks reasonable until you realise self.localpath is a function. Data
expansion of something which isn't a string is the original value so this
code just wastes CPU cycles and makes no sense. Remove it.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 bitbake/lib/bb/fetch2/__init__.py | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/bitbake/lib/bb/fetch2/__init__.py b/bitbake/lib/bb/fetch2/__init__.py
index 288a1c8..d66a212 100644
--- a/bitbake/lib/bb/fetch2/__init__.py
+++ b/bitbake/lib/bb/fetch2/__init__.py
@@ -1686,9 +1686,6 @@ class Fetch(object):
             ud = self.ud[u]
             ud.setup_localpath(self.d)
 
-            if self.d.expand(self.localpath) is None:
-                continue
-
             if ud.lockfile:
                 lf = bb.utils.lockfile(ud.lockfile)
 




^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2015-11-10 11:10 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-10  9:56 [PATCH] fetch2: Remove crazy code in unpack Richard Purdie

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.