* [PATCH] drm/i915/skl: Update DDI translation tables for SKL
@ 2015-11-06 23:30 Jim Bride
2015-11-11 13:02 ` Ander Conselvan De Oliveira
0 siblings, 1 reply; 3+ messages in thread
From: Jim Bride @ 2015-11-06 23:30 UTC (permalink / raw)
To: intel-gfx; +Cc: Rodrigo Vivi
While comparing the B-Spec with the code I noticed that several
values in these tables have been updated in the spec, so I
changed the code to match..
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Jim Bride <jim.bride@linux.intel.com>
---
drivers/gpu/drm/i915/intel_ddi.c | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index 036ff9b..d0062ad 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -133,12 +133,12 @@ static const struct ddi_buf_trans skl_ddi_translations_dp[] = {
{ 0x00002016, 0x000000A0, 0x0 },
{ 0x00005012, 0x0000009B, 0x0 },
{ 0x00007011, 0x00000088, 0x0 },
- { 0x00009010, 0x000000C7, 0x0 },
+ { 0x80009010, 0x000000C0, 0x1 }, /* Uses I_boost level 0x1 */
{ 0x00002016, 0x0000009B, 0x0 },
{ 0x00005012, 0x00000088, 0x0 },
- { 0x00007011, 0x000000C7, 0x0 },
+ { 0x80007011, 0x000000C0, 0x1 }, /* Uses I_boost level 0x1 */
{ 0x00002016, 0x000000DF, 0x0 },
- { 0x00005012, 0x000000C7, 0x0 },
+ { 0x80005012, 0x000000C0, 0x1 }, /* Uses I_boost level 0x1 */
};
/* Skylake U */
@@ -146,12 +146,12 @@ static const struct ddi_buf_trans skl_u_ddi_translations_dp[] = {
{ 0x0000201B, 0x000000A2, 0x0 },
{ 0x00005012, 0x00000088, 0x0 },
{ 0x00007011, 0x00000087, 0x0 },
- { 0x80009010, 0x000000C7, 0x1 }, /* Uses I_boost level 0x1 */
+ { 0x80009010, 0x000000C0, 0x1 }, /* Uses I_boost level 0x1 */
{ 0x0000201B, 0x0000009D, 0x0 },
- { 0x00005012, 0x000000C7, 0x0 },
- { 0x00007011, 0x000000C7, 0x0 },
+ { 0x80005012, 0x000000C0, 0x1 }, /* Uses I_boost level 0x1 */
+ { 0x80007011, 0x000000C0, 0x1 }, /* Uses I_boost level 0x1 */
{ 0x00002016, 0x00000088, 0x0 },
- { 0x00005012, 0x000000C7, 0x0 },
+ { 0x80005012, 0x000000C0, 0x1 }, /* Uses I_boost level 0x1 */
};
/* Skylake Y */
@@ -159,12 +159,12 @@ static const struct ddi_buf_trans skl_y_ddi_translations_dp[] = {
{ 0x00000018, 0x000000A2, 0x0 },
{ 0x00005012, 0x00000088, 0x0 },
{ 0x00007011, 0x00000087, 0x0 },
- { 0x80009010, 0x000000C7, 0x3 }, /* Uses I_boost level 0x3 */
+ { 0x80009010, 0x000000C0, 0x3 }, /* Uses I_boost level 0x3 */
{ 0x00000018, 0x0000009D, 0x0 },
- { 0x00005012, 0x000000C7, 0x0 },
- { 0x00007011, 0x000000C7, 0x0 },
+ { 0x80005012, 0x000000C0, 0x3 }, /* Uses I_boost level 0x3 */
+ { 0x80007011, 0x000000C0, 0x3 }, /* Uses I_boost level 0x3 */
{ 0x00000018, 0x00000088, 0x0 },
- { 0x00005012, 0x000000C7, 0x0 },
+ { 0x80005012, 0x000000C0, 0x3 }, /* Uses I_boost level 0x3 */
};
/*
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drm/i915/skl: Update DDI translation tables for SKL
2015-11-06 23:30 [PATCH] drm/i915/skl: Update DDI translation tables for SKL Jim Bride
@ 2015-11-11 13:02 ` Ander Conselvan De Oliveira
2015-11-13 12:39 ` Ander Conselvan De Oliveira
0 siblings, 1 reply; 3+ messages in thread
From: Ander Conselvan De Oliveira @ 2015-11-11 13:02 UTC (permalink / raw)
To: Jim Bride, intel-gfx; +Cc: Rodrigo Vivi
On Fri, 2015-11-06 at 15:30 -0800, Jim Bride wrote:
> While comparing the B-Spec with the code I noticed that several
> values in these tables have been updated in the spec, so I
> changed the code to match..
>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Jim Bride <jim.bride@linux.intel.com>
Reviewed-by: Ander Conselvan de Oliveira <conselvan2@gmail.com>
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c
> b/drivers/gpu/drm/i915/intel_ddi.c
> index 036ff9b..d0062ad 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -133,12 +133,12 @@ static const struct ddi_buf_trans
> skl_ddi_translations_dp[] = {
> { 0x00002016, 0x000000A0, 0x0 },
> { 0x00005012, 0x0000009B, 0x0 },
> { 0x00007011, 0x00000088, 0x0 },
> - { 0x00009010, 0x000000C7, 0x0 },
> + { 0x80009010, 0x000000C0, 0x1 }, /* Uses I_boost level 0x1 */
> { 0x00002016, 0x0000009B, 0x0 },
> { 0x00005012, 0x00000088, 0x0 },
> - { 0x00007011, 0x000000C7, 0x0 },
> + { 0x80007011, 0x000000C0, 0x1 }, /* Uses I_boost level 0x1 */
> { 0x00002016, 0x000000DF, 0x0 },
> - { 0x00005012, 0x000000C7, 0x0 },
> + { 0x80005012, 0x000000C0, 0x1 }, /* Uses I_boost level 0x1 */
> };
>
> /* Skylake U */
> @@ -146,12 +146,12 @@ static const struct ddi_buf_trans
> skl_u_ddi_translations_dp[] = {
> { 0x0000201B, 0x000000A2, 0x0 },
> { 0x00005012, 0x00000088, 0x0 },
> { 0x00007011, 0x00000087, 0x0 },
> - { 0x80009010, 0x000000C7, 0x1 }, /* Uses I_boost level 0x1 */
> + { 0x80009010, 0x000000C0, 0x1 }, /* Uses I_boost level 0x1 */
> { 0x0000201B, 0x0000009D, 0x0 },
> - { 0x00005012, 0x000000C7, 0x0 },
> - { 0x00007011, 0x000000C7, 0x0 },
> + { 0x80005012, 0x000000C0, 0x1 }, /* Uses I_boost level 0x1 */
> + { 0x80007011, 0x000000C0, 0x1 }, /* Uses I_boost level 0x1 */
> { 0x00002016, 0x00000088, 0x0 },
> - { 0x00005012, 0x000000C7, 0x0 },
> + { 0x80005012, 0x000000C0, 0x1 }, /* Uses I_boost level 0x1 */
> };
>
> /* Skylake Y */
> @@ -159,12 +159,12 @@ static const struct ddi_buf_trans
> skl_y_ddi_translations_dp[] = {
> { 0x00000018, 0x000000A2, 0x0 },
> { 0x00005012, 0x00000088, 0x0 },
> { 0x00007011, 0x00000087, 0x0 },
> - { 0x80009010, 0x000000C7, 0x3 }, /* Uses I_boost level 0x3 */
> + { 0x80009010, 0x000000C0, 0x3 }, /* Uses I_boost level 0x3 */
> { 0x00000018, 0x0000009D, 0x0 },
> - { 0x00005012, 0x000000C7, 0x0 },
> - { 0x00007011, 0x000000C7, 0x0 },
> + { 0x80005012, 0x000000C0, 0x3 }, /* Uses I_boost level 0x3 */
> + { 0x80007011, 0x000000C0, 0x3 }, /* Uses I_boost level 0x3 */
> { 0x00000018, 0x00000088, 0x0 },
> - { 0x00005012, 0x000000C7, 0x0 },
> + { 0x80005012, 0x000000C0, 0x3 }, /* Uses I_boost level 0x3 */
> };
>
> /*
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/i915/skl: Update DDI translation tables for SKL
2015-11-11 13:02 ` Ander Conselvan De Oliveira
@ 2015-11-13 12:39 ` Ander Conselvan De Oliveira
0 siblings, 0 replies; 3+ messages in thread
From: Ander Conselvan De Oliveira @ 2015-11-13 12:39 UTC (permalink / raw)
To: Jim Bride, intel-gfx; +Cc: Rodrigo Vivi
On Wed, 2015-11-11 at 15:02 +0200, Ander Conselvan De Oliveira wrote:
> On Fri, 2015-11-06 at 15:30 -0800, Jim Bride wrote:
> > While comparing the B-Spec with the code I noticed that several
> > values in these tables have been updated in the spec, so I
> > changed the code to match..
> >
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Signed-off-by: Jim Bride <jim.bride@linux.intel.com>
>
> Reviewed-by: Ander Conselvan de Oliveira <conselvan2@gmail.com>
Pushed to dinq. Thanks for the patch.
Ander
>
> > ---
> > drivers/gpu/drm/i915/intel_ddi.c | 22 +++++++++++-----------
> > 1 file changed, 11 insertions(+), 11 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_ddi.c
> > b/drivers/gpu/drm/i915/intel_ddi.c
> > index 036ff9b..d0062ad 100644
> > --- a/drivers/gpu/drm/i915/intel_ddi.c
> > +++ b/drivers/gpu/drm/i915/intel_ddi.c
> > @@ -133,12 +133,12 @@ static const struct ddi_buf_trans
> > skl_ddi_translations_dp[] = {
> > { 0x00002016, 0x000000A0, 0x0 },
> > { 0x00005012, 0x0000009B, 0x0 },
> > { 0x00007011, 0x00000088, 0x0 },
> > - { 0x00009010, 0x000000C7, 0x0 },
> > + { 0x80009010, 0x000000C0, 0x1 }, /* Uses I_boost level 0x1
> > */
> > { 0x00002016, 0x0000009B, 0x0 },
> > { 0x00005012, 0x00000088, 0x0 },
> > - { 0x00007011, 0x000000C7, 0x0 },
> > + { 0x80007011, 0x000000C0, 0x1 }, /* Uses I_boost level 0x1
> > */
> > { 0x00002016, 0x000000DF, 0x0 },
> > - { 0x00005012, 0x000000C7, 0x0 },
> > + { 0x80005012, 0x000000C0, 0x1 }, /* Uses I_boost level 0x1
> > */
> > };
> >
> > /* Skylake U */
> > @@ -146,12 +146,12 @@ static const struct ddi_buf_trans
> > skl_u_ddi_translations_dp[] = {
> > { 0x0000201B, 0x000000A2, 0x0 },
> > { 0x00005012, 0x00000088, 0x0 },
> > { 0x00007011, 0x00000087, 0x0 },
> > - { 0x80009010, 0x000000C7, 0x1 }, /* Uses I_boost level 0x1
> > */
> > + { 0x80009010, 0x000000C0, 0x1 }, /* Uses I_boost level 0x1
> > */
> > { 0x0000201B, 0x0000009D, 0x0 },
> > - { 0x00005012, 0x000000C7, 0x0 },
> > - { 0x00007011, 0x000000C7, 0x0 },
> > + { 0x80005012, 0x000000C0, 0x1 }, /* Uses I_boost level 0x1
> > */
> > + { 0x80007011, 0x000000C0, 0x1 }, /* Uses I_boost level 0x1
> > */
> > { 0x00002016, 0x00000088, 0x0 },
> > - { 0x00005012, 0x000000C7, 0x0 },
> > + { 0x80005012, 0x000000C0, 0x1 }, /* Uses I_boost level 0x1
> > */
> > };
> >
> > /* Skylake Y */
> > @@ -159,12 +159,12 @@ static const struct ddi_buf_trans
> > skl_y_ddi_translations_dp[] = {
> > { 0x00000018, 0x000000A2, 0x0 },
> > { 0x00005012, 0x00000088, 0x0 },
> > { 0x00007011, 0x00000087, 0x0 },
> > - { 0x80009010, 0x000000C7, 0x3 }, /* Uses I_boost level 0x3
> > */
> > + { 0x80009010, 0x000000C0, 0x3 }, /* Uses I_boost level 0x3
> > */
> > { 0x00000018, 0x0000009D, 0x0 },
> > - { 0x00005012, 0x000000C7, 0x0 },
> > - { 0x00007011, 0x000000C7, 0x0 },
> > + { 0x80005012, 0x000000C0, 0x3 }, /* Uses I_boost level 0x3
> > */
> > + { 0x80007011, 0x000000C0, 0x3 }, /* Uses I_boost level 0x3
> > */
> > { 0x00000018, 0x00000088, 0x0 },
> > - { 0x00005012, 0x000000C7, 0x0 },
> > + { 0x80005012, 0x000000C0, 0x3 }, /* Uses I_boost level 0x3
> > */
> > };
> >
> > /*
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-11-13 12:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-06 23:30 [PATCH] drm/i915/skl: Update DDI translation tables for SKL Jim Bride
2015-11-11 13:02 ` Ander Conselvan De Oliveira
2015-11-13 12:39 ` Ander Conselvan De Oliveira
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.