From: David Howells <dhowells@redhat.com>
To: Jeffle Xu <jefflexu@linux.alibaba.com>
Cc: tianzichen@kuaishou.com, linux-erofs@lists.ozlabs.org,
fannaihao@baidu.com, willy@infradead.org,
linux-kernel@vger.kernel.org, dhowells@redhat.com,
joseph.qi@linux.alibaba.com, zhangjiachen.jaycee@bytedance.com,
linux-cachefs@redhat.com, gregkh@linuxfoundation.org,
linux-fsdevel@vger.kernel.org, luodaowen.backend@bytedance.com,
gerry@linux.alibaba.com, torvalds@linux-foundation.org
Subject: EMFILE/ENFILE mitigation needed in erofs?
Date: Thu, 21 Apr 2022 15:54:58 +0100 [thread overview]
Message-ID: <1447543.1650552898@warthog.procyon.org.uk> (raw)
In-Reply-To: <20220415123614.54024-3-jefflexu@linux.alibaba.com>
Jeffle Xu <jefflexu@linux.alibaba.com> wrote:
> + fd_install(fd, file);
Do you need to mitigate potential EMFILE/ENFILE problems? You're potentially
trebling up the number of accounted systemwide fds: one for erofs itself, one
anonfd per cache object file to communicate with the daemon and one in the
daemon to talk to the server. Cachefiles has a fourth internally, but it's
kept off the books - further, cachefiles closes them fairly quickly after a
period of nonuse.
David
WARNING: multiple messages have this Message-ID (diff)
From: David Howells <dhowells@redhat.com>
To: Jeffle Xu <jefflexu@linux.alibaba.com>
Cc: dhowells@redhat.com, linux-cachefs@redhat.com, xiang@kernel.org,
chao@kernel.org, linux-erofs@lists.ozlabs.org,
torvalds@linux-foundation.org, gregkh@linuxfoundation.org,
willy@infradead.org, linux-fsdevel@vger.kernel.org,
joseph.qi@linux.alibaba.com, bo.liu@linux.alibaba.com,
tao.peng@linux.alibaba.com, gerry@linux.alibaba.com,
eguan@linux.alibaba.com, linux-kernel@vger.kernel.org,
luodaowen.backend@bytedance.com, tianzichen@kuaishou.com,
fannaihao@baidu.com, zhangjiachen.jaycee@bytedance.com
Subject: EMFILE/ENFILE mitigation needed in erofs?
Date: Thu, 21 Apr 2022 15:54:58 +0100 [thread overview]
Message-ID: <1447543.1650552898@warthog.procyon.org.uk> (raw)
In-Reply-To: <20220415123614.54024-3-jefflexu@linux.alibaba.com>
Jeffle Xu <jefflexu@linux.alibaba.com> wrote:
> + fd_install(fd, file);
Do you need to mitigate potential EMFILE/ENFILE problems? You're potentially
trebling up the number of accounted systemwide fds: one for erofs itself, one
anonfd per cache object file to communicate with the daemon and one in the
daemon to talk to the server. Cachefiles has a fourth internally, but it's
kept off the books - further, cachefiles closes them fairly quickly after a
period of nonuse.
David
next prev parent reply other threads:[~2022-04-21 14:55 UTC|newest]
Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-15 12:35 [PATCH v9 00/21] fscache, erofs: fscache-based on-demand read semantics Jeffle Xu
2022-04-15 12:35 ` [PATCH v9 00/21] fscache,erofs: " Jeffle Xu
2022-04-15 12:35 ` [PATCH v9 01/21] cachefiles: extract write routine Jeffle Xu
2022-04-15 12:35 ` Jeffle Xu
2022-04-21 13:24 ` David Howells
2022-04-21 13:24 ` David Howells
2022-04-15 12:35 ` [PATCH v9 02/21] cachefiles: notify user daemon when looking up cookie Jeffle Xu
2022-04-15 12:35 ` Jeffle Xu
2022-04-21 13:57 ` David Howells
2022-04-21 13:57 ` David Howells
2022-04-21 14:47 ` JeffleXu
2022-04-21 14:47 ` JeffleXu
2022-04-21 14:54 ` David Howells [this message]
2022-04-21 14:54 ` EMFILE/ENFILE mitigation needed in erofs? David Howells
2022-04-21 16:14 ` JeffleXu
2022-04-21 16:14 ` JeffleXu
2022-04-21 17:57 ` David Howells
2022-04-21 17:57 ` David Howells
2022-04-21 18:16 ` Gao Xiang
2022-04-21 18:16 ` Gao Xiang
2022-04-15 12:35 ` [PATCH v9 03/21] cachefiles: unbind cachefiles gracefully in on-demand mode Jeffle Xu
2022-04-15 12:35 ` Jeffle Xu
2022-04-21 14:02 ` David Howells
2022-04-21 14:02 ` David Howells
2022-04-22 2:44 ` JeffleXu
2022-04-22 2:44 ` JeffleXu
2022-04-15 12:35 ` [PATCH v9 04/21] cachefiles: notify user daemon when withdrawing cookie Jeffle Xu
2022-04-15 12:35 ` Jeffle Xu
2022-04-21 14:05 ` David Howells
2022-04-21 14:05 ` David Howells
2022-04-21 14:57 ` JeffleXu
2022-04-21 14:57 ` JeffleXu
2022-04-15 12:35 ` [PATCH v9 05/21] cachefiles: implement on-demand read Jeffle Xu
2022-04-15 12:35 ` Jeffle Xu
2022-04-21 14:14 ` David Howells
2022-04-21 14:14 ` David Howells
2022-04-21 15:00 ` JeffleXu
2022-04-21 15:00 ` JeffleXu
2022-04-15 12:35 ` [PATCH v9 06/21] cachefiles: enable on-demand read mode Jeffle Xu
2022-04-15 12:35 ` Jeffle Xu
2022-04-21 14:17 ` David Howells
2022-04-21 14:17 ` David Howells
2022-04-21 15:11 ` JeffleXu
2022-04-21 15:11 ` JeffleXu
2022-04-15 12:36 ` [PATCH v9 07/21] cachefiles: add tracepoints for " Jeffle Xu
2022-04-15 12:36 ` Jeffle Xu
2022-04-21 14:19 ` David Howells
2022-04-21 14:19 ` David Howells
2022-04-15 12:36 ` [PATCH v9 08/21] cachefiles: document " Jeffle Xu
2022-04-15 12:36 ` Jeffle Xu
2022-04-21 14:47 ` David Howells
2022-04-21 14:47 ` David Howells
2022-04-22 3:10 ` JeffleXu
2022-04-22 3:10 ` JeffleXu
2022-04-15 12:36 ` [PATCH v9 09/21] erofs: make erofs_map_blocks() generally available Jeffle Xu
2022-04-15 12:36 ` Jeffle Xu
2022-04-15 12:36 ` [PATCH v9 10/21] erofs: add fscache mode check helper Jeffle Xu
2022-04-15 12:36 ` Jeffle Xu
2022-04-21 7:53 ` Gao Xiang
2022-04-21 7:53 ` Gao Xiang
2022-04-15 12:36 ` [PATCH v9 11/21] erofs: register fscache volume Jeffle Xu
2022-04-15 12:36 ` Jeffle Xu
2022-04-15 12:36 ` [PATCH v9 12/21] erofs: add fscache context helper functions Jeffle Xu
2022-04-15 12:36 ` Jeffle Xu
2022-04-15 12:36 ` [PATCH v9 13/21] erofs: add anonymous inode caching metadata for data blobs Jeffle Xu
2022-04-15 12:36 ` Jeffle Xu
2022-04-15 12:36 ` [PATCH v9 14/21] erofs: add erofs_fscache_read_folios() helper Jeffle Xu
2022-04-15 12:36 ` Jeffle Xu
2022-04-15 12:36 ` [PATCH v9 15/21] erofs: register fscache context for primary data blob Jeffle Xu
2022-04-15 12:36 ` Jeffle Xu
2022-04-15 12:36 ` [PATCH v9 16/21] erofs: register fscache context for extra data blobs Jeffle Xu
2022-04-15 12:36 ` Jeffle Xu
2022-04-21 10:58 ` Gao Xiang
2022-04-21 10:58 ` Gao Xiang
2022-04-15 12:36 ` [PATCH v9 17/21] erofs: implement fscache-based metadata read Jeffle Xu
2022-04-15 12:36 ` Jeffle Xu
2022-04-21 13:03 ` Gao Xiang
2022-04-21 13:03 ` Gao Xiang
2022-04-15 12:36 ` [PATCH v9 18/21] erofs: implement fscache-based data read for non-inline layout Jeffle Xu
2022-04-15 12:36 ` Jeffle Xu
2022-04-21 11:13 ` Gao Xiang
2022-04-21 11:13 ` Gao Xiang
2022-04-15 12:36 ` [PATCH v9 19/21] erofs: implement fscache-based data read for inline layout Jeffle Xu
2022-04-15 12:36 ` Jeffle Xu
2022-04-21 11:14 ` Gao Xiang
2022-04-21 11:14 ` Gao Xiang
2022-04-15 12:36 ` [PATCH v9 20/21] erofs: implement fscache-based data readahead Jeffle Xu
2022-04-15 12:36 ` Jeffle Xu
2022-04-21 11:51 ` Gao Xiang
2022-04-21 11:51 ` Gao Xiang
2022-04-15 12:36 ` [PATCH v9 21/21] erofs: add 'fsid' mount option Jeffle Xu
2022-04-15 12:36 ` Jeffle Xu
2022-04-21 11:59 ` Gao Xiang
2022-04-21 11:59 ` Gao Xiang
2022-04-20 8:52 ` [PATCH v9 00/21] fscache, erofs: fscache-based on-demand read semantics JiaZhu
2022-04-20 8:52 ` JiaZhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447543.1650552898@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=fannaihao@baidu.com \
--cc=gerry@linux.alibaba.com \
--cc=gregkh@linuxfoundation.org \
--cc=jefflexu@linux.alibaba.com \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-cachefs@redhat.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luodaowen.backend@bytedance.com \
--cc=tianzichen@kuaishou.com \
--cc=torvalds@linux-foundation.org \
--cc=willy@infradead.org \
--cc=zhangjiachen.jaycee@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.