From: Ian Campbell <ian.campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH 1/2] libxl: replace libxl__sprintf(gc, ...) with GCSPRINTF
Date: Tue, 17 Nov 2015 15:21:39 +0000 [thread overview]
Message-ID: <1447773699.301.45.camel@citrix.com> (raw)
In-Reply-To: <20151117151618.GD1495@citrix.com>
On Tue, 2015-11-17 at 15:16 +0000, Wei Liu wrote:
> On Tue, Nov 17, 2015 at 03:08:47PM +0000, Wei Liu wrote:
> > The rune is
> >
> > sed -i 's/libxl__sprintf(gc,\s*\(".*",.*\)/GCSPRINTF(\1/g' libxl*.c
> >
>
> Hmm... It looks like this rune alone doesn't cover all situations.
>
> $ ack-grep 'libxl__sprintf\(gc' | wc -l
> 43
>
> Let me see if I can refine it a bit or use multiple runes to replace all
> libxl__sprintf.
Coccinelle would probably work quite well for this particular case.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2015-11-17 15:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-17 15:08 [PATCH 0/2] Convert libxl__sprintf(gc) to GCSPRINTF Wei Liu
2015-11-17 15:08 ` [PATCH 1/2] libxl: replace libxl__sprintf(gc, ...) with GCSPRINTF Wei Liu
2015-11-17 15:16 ` Wei Liu
2015-11-17 15:21 ` Ian Campbell [this message]
2015-11-17 15:24 ` Wei Liu
2015-11-17 15:32 ` Ian Campbell
2015-11-17 15:51 ` Wei Liu
2015-11-17 15:08 ` [PATCH 2/2] libxl: fix line wrapping issues introduced by automatic replacement Wei Liu
2015-11-17 15:34 ` [PATCH 0/2] Convert libxl__sprintf(gc) to GCSPRINTF David Vrabel
2015-11-17 15:38 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447773699.301.45.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.