From: David Vrabel <david.vrabel@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH 0/2] Convert libxl__sprintf(gc) to GCSPRINTF
Date: Tue, 17 Nov 2015 15:34:30 +0000 [thread overview]
Message-ID: <564B4906.1080404@citrix.com> (raw)
In-Reply-To: <1447772928-12652-1-git-send-email-wei.liu2@citrix.com>
On 17/11/15 15:08, Wei Liu wrote:
> There are mixed usage of libxl__sprintf(gc) and GCSPRINTF. Convert all
> libxl__sprintf to GCSPRINTF.
This looks like pointless churn /and/ GCSPRINTF is /less/ readable than
libxl__sprintf(gc,...) because the reader now has to also look up what
GCSPRINTF does.
David
next prev parent reply other threads:[~2015-11-17 15:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-17 15:08 [PATCH 0/2] Convert libxl__sprintf(gc) to GCSPRINTF Wei Liu
2015-11-17 15:08 ` [PATCH 1/2] libxl: replace libxl__sprintf(gc, ...) with GCSPRINTF Wei Liu
2015-11-17 15:16 ` Wei Liu
2015-11-17 15:21 ` Ian Campbell
2015-11-17 15:24 ` Wei Liu
2015-11-17 15:32 ` Ian Campbell
2015-11-17 15:51 ` Wei Liu
2015-11-17 15:08 ` [PATCH 2/2] libxl: fix line wrapping issues introduced by automatic replacement Wei Liu
2015-11-17 15:34 ` David Vrabel [this message]
2015-11-17 15:38 ` [PATCH 0/2] Convert libxl__sprintf(gc) to GCSPRINTF Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564B4906.1080404@citrix.com \
--to=david.vrabel@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.