From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Anshuman Khandual <khandual@linux.vnet.ibm.com>,
Denis Kirjanov <kda@linux-powerpc.org>,
Rashmica Gupta <rashmicy@gmail.com>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc: Standardise on NR_syscalls rather than __NR_syscalls.
Date: Thu, 19 Nov 2015 21:33:43 +1100 [thread overview]
Message-ID: <1447929223.11126.4.camel@kernel.crashing.org> (raw)
In-Reply-To: <564D9D85.1090201@linux.vnet.ibm.com>
On Thu, 2015-11-19 at 15:29 +0530, Anshuman Khandual wrote:
> On 11/19/2015 02:45 PM, Denis Kirjanov wrote:
> > On 11/19/15, Rashmica Gupta <rashmicy@gmail.com> wrote:
> > > > Most architectures use NR_syscalls as the #define for the
> > > > number of
> > > > syscalls.
> > > >
> > > > We use __NR_syscalls, and then define NR_syscalls as
> > > > __NR_syscalls.
> > > >
> > > > __NR_syscalls is not used outside arch code, whereas
> > > > NR_syscalls is. So as
> > > > NR_syscalls must be defined and __NR_syscalls does not, replace
> > > > __NR_syscalls
> > > > with NR_syscalls.
> > Hi,
> >
> > But what's wrong with the current code? Why do we need such change?
>
> Yeah, just out of curiosity. Why we had both __NR_syscalls and
> NR_syscalls to begin with ?
Evolutionary remains. This is a whorthwhile and fairly simple cleanup.
Cheers,
Ben.
next prev parent reply other threads:[~2015-11-19 10:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-19 6:04 [PATCH] powerpc: Standardise on NR_syscalls rather than __NR_syscalls Rashmica Gupta
2015-11-19 9:15 ` Denis Kirjanov
2015-11-19 9:59 ` Anshuman Khandual
2015-11-19 10:33 ` Benjamin Herrenschmidt [this message]
2015-11-23 3:29 ` Michael Ellerman
2015-11-23 9:28 ` Denis Kirjanov
2015-11-23 10:14 ` Michael Ellerman
2015-11-23 6:23 ` Anshuman Khandual
2015-11-23 23:22 ` Michael Ellerman
2015-11-26 12:15 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447929223.11126.4.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=kda@linux-powerpc.org \
--cc=khandual@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=rashmicy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.