From: Michael Neuling <mikey@neuling.org>
To: Cyril Bur <cyrilbur@gmail.com>, anton@samba.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 4/8] powerpc: Explicitly disable math features when copying thread
Date: Mon, 23 Nov 2015 12:08:38 +1100 [thread overview]
Message-ID: <1448240918.3061.6.camel@neuling.org> (raw)
In-Reply-To: <1447817215-15804-5-git-send-email-cyrilbur@gmail.com>
On Wed, 2015-11-18 at 14:26 +1100, Cyril Bur wrote:
> With threads leaving the math bits enabled in their saved MSR to
> indicate
> that the hardware is hot and a restore is not needed, children need
> to turn
> it off as when they do get scheduled, there's no way their registers
> could
> have been hot.
>=20
> Signed-off-by: Cyril Bur <cyrilbur@gmail.com>
> ---
> arch/powerpc/kernel/process.c | 1 +
> 1 file changed, 1 insertion(+)
>=20
> diff --git a/arch/powerpc/kernel/process.c
> b/arch/powerpc/kernel/process.c
> index 398f7bf..441d9e5 100644
> --- a/arch/powerpc/kernel/process.c
> +++ b/arch/powerpc/kernel/process.c
> @@ -1243,6 +1243,7 @@ int copy_thread(unsigned long clone_flags,
> unsigned long usp,
> =20
> f =3D ret_from_fork;
> }
> + childregs->msr &=3D ~(MSR_FP|MSR_VEC|MSR_VSX);
Is this a current bug?=20
Mikey
> sp -=3D STACK_FRAME_OVERHEAD;
> =20
> /*
next prev parent reply other threads:[~2015-11-23 1:08 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-18 3:26 [PATCH 0/8] FP/VEC/VSX switching optimisations Cyril Bur
2015-11-18 3:26 ` [PATCH 1/8] selftests/powerpc: Test the preservation of FPU and VMX regs across syscall Cyril Bur
2015-11-23 0:23 ` Michael Neuling
2015-11-23 0:58 ` Cyril Bur
2015-11-23 1:06 ` Michael Neuling
2015-11-18 3:26 ` [PATCH 2/8] selftests/powerpc: Test preservation of FPU and VMX regs across preemption Cyril Bur
2015-11-23 0:34 ` Michael Neuling
2015-11-18 3:26 ` [PATCH 3/8] selftests/powerpc: Test FPU and VMX regs in signal ucontext Cyril Bur
2015-11-19 11:36 ` [3/8] " Michael Ellerman
2015-11-23 1:04 ` [PATCH 3/8] " Michael Neuling
2015-11-18 3:26 ` [PATCH 4/8] powerpc: Explicitly disable math features when copying thread Cyril Bur
2015-11-23 1:08 ` Michael Neuling [this message]
2015-11-23 3:20 ` Cyril Bur
2015-11-18 3:26 ` [PATCH 5/8] powerpc: Restore FPU/VEC/VSX if previously used Cyril Bur
2015-11-20 11:01 ` Michael Ellerman
2015-11-22 22:18 ` Cyril Bur
2015-11-22 23:07 ` Michael Ellerman
2015-11-23 1:29 ` Michael Neuling
2015-11-18 3:26 ` [PATCH 6/8] powerpc: Add the ability to save FPU without giving it up Cyril Bur
2015-11-18 3:26 ` [PATCH 7/8] powerpc: Add the ability to save Altivec " Cyril Bur
2015-11-18 3:26 ` [PATCH 8/8] powerpc: Add the ability to save VSX " Cyril Bur
2015-11-18 14:51 ` [PATCH 0/8] FP/VEC/VSX switching optimisations David Laight
2015-11-18 23:01 ` Cyril Bur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448240918.3061.6.camel@neuling.org \
--to=mikey@neuling.org \
--cc=anton@samba.org \
--cc=cyrilbur@gmail.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.