From: Philippe Longepe <philippe.longepe@linux.intel.com>
To: linux-pm@vger.kernel.org
Cc: srinivas.pandruvada@linux.intel.com,
Philippe Longepe <philippe.longepe@intel.com>
Subject: [PATCH v1 1/5] cpufreq: intel_pstate: change function name for calculation for busy
Date: Mon, 23 Nov 2015 14:06:37 +0100 [thread overview]
Message-ID: <1448284006-13596-3-git-send-email-philippe.longepe@linux.intel.com> (raw)
In-Reply-To: <1448284006-13596-1-git-send-email-philippe.longepe@linux.intel.com>
From: Philippe Longepe <philippe.longepe@intel.com>
APERF/MPERF is not giving busy but average performance of frequency.
Also core_pct_busy is not busy but core percent for performance.
Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Philippe Longepe <philippe.longepe@intel.com>
---
drivers/cpufreq/intel_pstate.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
index d3b0e50..423a12a 100644
--- a/drivers/cpufreq/intel_pstate.c
+++ b/drivers/cpufreq/intel_pstate.c
@@ -65,7 +65,7 @@ static inline int ceiling_fp(int32_t x)
}
struct sample {
- int32_t core_pct_busy;
+ int32_t core_pct_perf;
u64 aperf;
u64 mperf;
u64 tsc;
@@ -856,7 +856,7 @@ static void intel_pstate_get_cpu_pstates(struct cpudata *cpu)
intel_pstate_set_pstate(cpu, cpu->pstate.min_pstate, false);
}
-static inline void intel_pstate_calc_busy(struct cpudata *cpu)
+static inline void intel_pstate_calc_performance(struct cpudata *cpu)
{
struct sample *sample = &cpu->sample;
int64_t core_pct;
@@ -870,7 +870,7 @@ static inline void intel_pstate_calc_busy(struct cpudata *cpu)
cpu->pstate.scaling / 100),
core_pct));
- sample->core_pct_busy = (int32_t)core_pct;
+ sample->core_pct_perf = (int32_t)core_pct;
}
static inline void intel_pstate_sample(struct cpudata *cpu)
@@ -899,7 +899,7 @@ static inline void intel_pstate_sample(struct cpudata *cpu)
cpu->sample.mperf -= cpu->prev_mperf;
cpu->sample.tsc -= cpu->prev_tsc;
- intel_pstate_calc_busy(cpu);
+ intel_pstate_calc_performance(cpu);
cpu->prev_aperf = aperf;
cpu->prev_mperf = mperf;
@@ -939,7 +939,7 @@ static inline int32_t intel_pstate_get_scaled_busy(struct cpudata *cpu)
* period. The result will be a percentage of busy at a
* specified pstate.
*/
- core_busy = cpu->sample.core_pct_busy;
+ core_busy = cpu->sample.core_pct_perf;
max_pstate = int_tofp(cpu->pstate.max_pstate_physical);
current_pstate = int_tofp(cpu->pstate.current_pstate);
core_busy = mul_fp(core_busy, div_fp(max_pstate, current_pstate));
@@ -982,7 +982,7 @@ static inline void intel_pstate_adjust_busy_pstate(struct cpudata *cpu)
intel_pstate_set_pstate(cpu, cpu->pstate.current_pstate - ctl, true);
sample = &cpu->sample;
- trace_pstate_sample(fp_toint(sample->core_pct_busy),
+ trace_pstate_sample(fp_toint(sample->core_pct_perf),
fp_toint(busy_scaled),
from,
cpu->pstate.current_pstate,
--
1.9.1
next prev parent reply other threads:[~2015-11-23 13:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-23 13:06 [PATCH v1 0/5] intel_pstate: Use the cpu load first on Atom only Philippe Longepe
2015-11-23 13:06 ` Philippe Longepe
2015-11-23 13:06 ` Philippe Longepe [this message]
2015-11-23 13:06 ` [PATCH 1/5] cpufreq: intel_pstate: change function name for calculation for busy Philippe Longepe
2015-11-23 13:06 ` [PATCH v1 2/5] cpufreq: intel_pstate: Rename current busy calculation function Philippe Longepe
2015-11-23 13:06 ` Philippe Longepe
2015-11-23 13:06 ` [PATCH v1 3/5] cpufreq: intel_pstate: account for non C0 time Philippe Longepe
2015-11-23 13:06 ` Philippe Longepe
2015-11-23 13:06 ` [PATCH v1 4/5] cpufreq: intel_pstate: configurable busy calculation Philippe Longepe
2015-11-23 13:06 ` Philippe Longepe
2015-11-23 13:06 ` [PATCH v1 5/5] cpufreq: intel_pstate: try load instead of busy_scaled Philippe Longepe
2015-11-23 16:10 ` Doug Smythies
2015-11-23 16:26 ` Philippe Longepe
2015-11-24 1:33 ` Doug Smythies
2015-11-23 13:06 ` Philippe Longepe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448284006-13596-3-git-send-email-philippe.longepe@linux.intel.com \
--to=philippe.longepe@linux.intel.com \
--cc=linux-pm@vger.kernel.org \
--cc=philippe.longepe@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.