From: Philippe Longepe <philippe.longepe@linux.intel.com>
To: Doug Smythies <dsmythies@telus.net>
Cc: srinivas.pandruvada@linux.intel.com,
'Stephane Gasparini' <stephane.gasparini@intel.com>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v1 5/5] cpufreq: intel_pstate: try load instead of busy_scaled
Date: Mon, 23 Nov 2015 17:26:20 +0100 [thread overview]
Message-ID: <56533E2C.6090506@linux.intel.com> (raw)
In-Reply-To: <001101d12609$73987ef0$5ac97cd0$@net>
Thank you Smythies,
I found another small error on patch 5/5.
Let me doing few test on a CherryTrail and I'll resubmit a version 2 for
this patch.
Thx,
Philippe
On 23/11/2015 17:10, Doug Smythies wrote:
> On 2015.11.23 05:47 Philippe Longepe wrote:
>
>> static inline int32_t intel_pstate_calc_scaled_busy(struct cpudata *cpu)
>> {
>> + u64 cummulative_iowait, delta_iowait_us;
>> + u64 delta_iowait_mperf;
>> + u64 mperf, now;
>> struct sample *sample = &cpu->sample;
>> struct pstate_data *pstate = &cpu->pstate;
> To prevent a build "unused variable 'pstate'" warning, suggest deleting that last line.
> As of this patch 5 of 5 it is no longer used. i.e.:
>
> - struct pstate_data *pstate = &cpu->pstate;
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-11-23 16:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-23 13:06 [PATCH v1 0/5] intel_pstate: Use the cpu load first on Atom only Philippe Longepe
2015-11-23 13:06 ` Philippe Longepe
2015-11-23 13:06 ` [PATCH v1 1/5] cpufreq: intel_pstate: change function name for calculation for busy Philippe Longepe
2015-11-23 13:06 ` [PATCH " Philippe Longepe
2015-11-23 13:06 ` [PATCH v1 2/5] cpufreq: intel_pstate: Rename current busy calculation function Philippe Longepe
2015-11-23 13:06 ` Philippe Longepe
2015-11-23 13:06 ` [PATCH v1 3/5] cpufreq: intel_pstate: account for non C0 time Philippe Longepe
2015-11-23 13:06 ` Philippe Longepe
2015-11-23 13:06 ` [PATCH v1 4/5] cpufreq: intel_pstate: configurable busy calculation Philippe Longepe
2015-11-23 13:06 ` Philippe Longepe
2015-11-23 13:06 ` [PATCH v1 5/5] cpufreq: intel_pstate: try load instead of busy_scaled Philippe Longepe
2015-11-23 16:10 ` Doug Smythies
2015-11-23 16:26 ` Philippe Longepe [this message]
2015-11-24 1:33 ` Doug Smythies
2015-11-23 13:06 ` Philippe Longepe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56533E2C.6090506@linux.intel.com \
--to=philippe.longepe@linux.intel.com \
--cc=dsmythies@telus.net \
--cc=linux-pm@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=stephane.gasparini@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.