From: Michal Hocko <mhocko@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Vladimir Davydov <vdavydov@parallels.com>,
Vlastimil Babka <vbabka@suse.cz>, Mel Gorman <mgorman@suse.de>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 0/2] 2 zone_pages_reclaimable fixes
Date: Tue, 24 Nov 2015 12:54:58 +0100 [thread overview]
Message-ID: <1448366100-11023-1-git-send-email-mhocko@kernel.org> (raw)
Hi,
Johannes had a valid point [1] that zone_pages_reclaimable should contain
isolated pages as well. This is what the first patch does. While I was
there I've realized that the current logic of this function allows for
a large overestimation of the reclaimable memory with anon >> nr_swap_pages
which would be visible especially when the swap is getting short on space.
I think this is a bug and this is fixed in the second patch.
I do not have any particular workload which would show significant misbehavior
because of the current implementation though. We mostly just happen to scan
longer than necessary because zone_reclaimable would keep us looping longer
but I still think it makes sense to fix this regardless.
[1] http://lkml.kernel.org/r/20151123182447.GF13000%40cmpxchg.org
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Vladimir Davydov <vdavydov@parallels.com>,
Vlastimil Babka <vbabka@suse.cz>, Mel Gorman <mgorman@suse.de>,
<linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 0/2] 2 zone_pages_reclaimable fixes
Date: Tue, 24 Nov 2015 12:54:58 +0100 [thread overview]
Message-ID: <1448366100-11023-1-git-send-email-mhocko@kernel.org> (raw)
Hi,
Johannes had a valid point [1] that zone_pages_reclaimable should contain
isolated pages as well. This is what the first patch does. While I was
there I've realized that the current logic of this function allows for
a large overestimation of the reclaimable memory with anon >> nr_swap_pages
which would be visible especially when the swap is getting short on space.
I think this is a bug and this is fixed in the second patch.
I do not have any particular workload which would show significant misbehavior
because of the current implementation though. We mostly just happen to scan
longer than necessary because zone_reclaimable would keep us looping longer
but I still think it makes sense to fix this regardless.
[1] http://lkml.kernel.org/r/20151123182447.GF13000%40cmpxchg.org
next reply other threads:[~2015-11-24 11:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-24 11:54 Michal Hocko [this message]
2015-11-24 11:54 ` [PATCH 0/2] 2 zone_pages_reclaimable fixes Michal Hocko
2015-11-24 11:54 ` [PATCH 1/2] mm, vmscan: consider isolated pages in zone_reclaimable_pages Michal Hocko
2015-11-24 11:54 ` Michal Hocko
2015-11-24 13:53 ` Vladimir Davydov
2015-11-24 13:53 ` Vladimir Davydov
2015-11-24 16:03 ` Johannes Weiner
2015-11-24 16:03 ` Johannes Weiner
2015-11-25 11:00 ` David Rientjes
2015-11-25 11:00 ` David Rientjes
2015-11-24 11:55 ` [PATCH 2/2] mm, vmscan: do not overestimate anonymous reclaimable pages Michal Hocko
2015-11-24 11:55 ` Michal Hocko
2015-11-24 13:07 ` Vladimir Davydov
2015-11-24 13:07 ` Vladimir Davydov
2015-11-24 13:37 ` Michal Hocko
2015-11-24 13:37 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448366100-11023-1-git-send-email-mhocko@kernel.org \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=vbabka@suse.cz \
--cc=vdavydov@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.