All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2]iw: DEREF_AFTER_NULL: fix
@ 2015-11-26  9:10 Rahul Jain
  2015-11-26 17:43 ` Johannes Berg
  0 siblings, 1 reply; 2+ messages in thread
From: Rahul Jain @ 2015-11-26  9:10 UTC (permalink / raw)
  To: johannes; +Cc: linux-wireless, Amit Khatri, Rahul Jain

From: Amit Khatri <amit.khatri@samsung.com>

Signed-off-by: Amit Khatri <amit.khatri@samsung.com>
Signed-off-by: Rahul Jain <rahul.jain@samsung.com>
---
 wowlan.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/wowlan.c b/wowlan.c
index 25f260b..ac2c13d 100644
--- a/wowlan.c
+++ b/wowlan.c
@@ -194,7 +194,8 @@ static int wowlan_parse_tcp_file(struct nl_msg *msg, const char *fn)
 	err = -ENOBUFS;
  close:
 	fclose(f);
-	nla_nest_end(msg, tcp);
+	if(tcp)
+		nla_nest_end(msg, tcp);
 	return err;
 }
 
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/2]iw: DEREF_AFTER_NULL: fix
  2015-11-26  9:10 [PATCH 1/2]iw: DEREF_AFTER_NULL: fix Rahul Jain
@ 2015-11-26 17:43 ` Johannes Berg
  0 siblings, 0 replies; 2+ messages in thread
From: Johannes Berg @ 2015-11-26 17:43 UTC (permalink / raw)
  To: Rahul Jain; +Cc: linux-wireless, Amit Khatri

Applied, but please use better coding style and a useful commit message
next time.

johannes

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-11-26 17:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-26  9:10 [PATCH 1/2]iw: DEREF_AFTER_NULL: fix Rahul Jain
2015-11-26 17:43 ` Johannes Berg

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.