* Patch "usb: chipidea: debug: disable usb irq while role switch" has been added to the 4.3-stable tree
@ 2015-12-07 8:49 gregkh
0 siblings, 0 replies; only message in thread
From: gregkh @ 2015-12-07 8:49 UTC (permalink / raw)
To: jun.li, gregkh, peter.chen; +Cc: stable, stable-commits
This is a note to let you know that I've just added the patch titled
usb: chipidea: debug: disable usb irq while role switch
to the 4.3-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
usb-chipidea-debug-disable-usb-irq-while-role-switch.patch
and it can be found in the queue-4.3 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.
>From 251b3c8b57481bcecd3f753108e36e7389ce12ac Mon Sep 17 00:00:00 2001
From: Li Jun <jun.li@freescale.com>
Date: Tue, 13 Oct 2015 18:23:31 +0800
Subject: usb: chipidea: debug: disable usb irq while role switch
From: Li Jun <jun.li@freescale.com>
commit 251b3c8b57481bcecd3f753108e36e7389ce12ac upstream.
Since the ci->role will be set after the host role start is complete, there
will be nobody cared irq during start host if usb irq enabled. This error
can be reproduced on i.mx6 sololite EVK board by:
1. disable otg id irq(IDIE) and disable all real otg properties of usbotg1
in dts.
2. boot up the board with ID cable and usb device connected.
3. echo gadget > /sys/kernel/debug/ci_hdrc.0/role
4. echo host > /sys/kernel/debug/ci_hdrc.0/role
5. irq 212: nobody cared.
Signed-off-by: Li Jun <jun.li@freescale.com>
Signed-off-by: Peter Chen <peter.chen@freescale.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/usb/chipidea/debug.c | 2 ++
1 file changed, 2 insertions(+)
--- a/drivers/usb/chipidea/debug.c
+++ b/drivers/usb/chipidea/debug.c
@@ -322,8 +322,10 @@ static ssize_t ci_role_write(struct file
return -EINVAL;
pm_runtime_get_sync(ci->dev);
+ disable_irq(ci->irq);
ci_role_stop(ci);
ret = ci_role_start(ci, role);
+ enable_irq(ci->irq);
pm_runtime_put_sync(ci->dev);
return ret ? ret : count;
Patches currently in stable-queue which might be from jun.li@freescale.com are
queue-4.3/usb-chipidea-debug-disable-usb-irq-while-role-switch.patch
queue-4.3/usb-chipidea-otg-gadget-module-load-and-unload-support.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2015-12-07 12:24 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-07 8:49 Patch "usb: chipidea: debug: disable usb irq while role switch" has been added to the 4.3-stable tree gregkh
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.