From: Ian Campbell <ian.campbell@citrix.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xenproject.org
Subject: Re: [OSSTEST PATCH 11/11] mg-schema-test-database: Sort out daemons; provide `daemons' subcommand
Date: Mon, 7 Dec 2015 10:18:16 +0000 [thread overview]
Message-ID: <1449483496.29724.42.camel@citrix.com> (raw)
In-Reply-To: <1449257734-26860-12-git-send-email-ian.jackson@eu.citrix.com>
On Fri, 2015-12-04 at 19:35 +0000, Ian Jackson wrote:
> We arrange for the test configuration to look for the daemons on a
> different host and port, and we provide a convenient way to run such a
> pair of daemons.
I was missing where *Daemon{Host,Port} were set here, it turns out to be in
patch 9, which might be a bisection issue? I'm not sure we care for this
new code.
It also occurred to me while reading this that I didn't know what to do
with OSSTEST_CONFIG here, I've not spotted in patch 9 where withtest()
behaves in the obvious way, but it might be worth mentioning explicitly in
the comments that the script DTRT and it is never(/rarely) necessary to set
OSSTEST_CONFIG=local-config.test-database_SUFFIX yourself.
But that's a comment on a previous patch, so:
> Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
next prev parent reply other threads:[~2015-12-07 10:19 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-04 19:35 [OSSTEST PATCH 00/11] Test database handling Ian Jackson
2015-12-04 19:35 ` [OSSTEST PATCH 01/11] tcl daemons: log host and port number we bind to, at startup Ian Jackson
2015-12-07 9:42 ` Ian Campbell
2015-12-04 19:35 ` [OSSTEST PATCH 02/11] cri-getconfig: Break out exec_resetting_sigint Ian Jackson
2015-12-07 9:43 ` Ian Campbell
2015-12-04 19:35 ` [OSSTEST PATCH 03/11] Configuration: No longer set password=<~/.xen-osstest/db-password> Ian Jackson
2015-12-07 9:52 ` Ian Campbell
2015-12-07 15:05 ` Ian Jackson
2015-12-04 19:35 ` [OSSTEST PATCH 04/11] mg-debug-fail: New utility script for debugging Ian Jackson
2015-12-07 9:55 ` Ian Campbell
2015-12-07 15:10 ` Ian Jackson
2015-12-07 15:40 ` Ian Campbell
2015-12-07 15:41 ` Ian Campbell
2015-12-04 19:35 ` [OSSTEST PATCH 05/11] mg-debug-fail: Catch attempts to read from a tty Ian Jackson
2015-12-07 9:55 ` Ian Campbell
2015-12-04 19:35 ` [OSSTEST PATCH 06/11] cri-getconfig: Provide get_psql_cmd and get_pgdump_cmd Ian Jackson
2015-12-07 9:57 ` Ian Campbell
2015-12-07 14:59 ` Ian Jackson
2015-12-04 19:35 ` [OSSTEST PATCH 07/11] cri-getconfig: Provide debugging for get_psql_cmd Ian Jackson
2015-12-07 10:00 ` Ian Campbell
2015-12-07 15:02 ` Ian Jackson
2015-12-07 15:38 ` Ian Campbell
2015-12-04 19:35 ` [OSSTEST PATCH 08/11] Osstest.pm: Break out and export globalconfigfiles Ian Jackson
2015-12-07 10:03 ` Ian Campbell
2015-12-04 19:35 ` [OSSTEST PATCH 09/11] mg-schema-test-database: New script Ian Jackson
2015-12-07 10:12 ` Ian Campbell
2015-12-07 15:12 ` Ian Jackson
2015-12-07 15:42 ` Ian Campbell
2015-12-04 19:35 ` [OSSTEST PATCH 10/11] mg-schema-test-database: Move setting of test_cfg_setting to dbname Ian Jackson
2015-12-07 10:12 ` Ian Campbell
2015-12-04 19:35 ` [OSSTEST PATCH 11/11] mg-schema-test-database: Sort out daemons; provide `daemons' subcommand Ian Jackson
2015-12-07 10:18 ` Ian Campbell [this message]
2015-12-07 15:16 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449483496.29724.42.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.