All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>,
	Xen-devel <xen-devel@lists.xenproject.org>
Cc: ian.jackson@eu.citrix.com
Subject: Re: [PATCH OSSTEST] mg-execute-flight: create tmp directory if it doesn't exist
Date: Mon, 7 Dec 2015 14:42:03 +0000	[thread overview]
Message-ID: <1449499323.29724.54.camel@citrix.com> (raw)
In-Reply-To: <1449497350-11439-1-git-send-email-wei.liu2@citrix.com>

On Mon, 2015-12-07 at 14:09 +0000, Wei Liu wrote:
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>

Acked-by: Ian Campbell <ian.campbell@citrix.com>

Most other places just do "mkdir -p tmp" (-p includes "no error if
existing"). I guess it doesn't really matter either way.

Ian.

> ---
>  mg-execute-flight | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/mg-execute-flight b/mg-execute-flight
> index 8b2c21c..dd64aef 100755
> --- a/mg-execute-flight
> +++ b/mg-execute-flight
> @@ -66,6 +66,8 @@ export OSSTEST_RESOURCE_PREINFO="[adhoc $blessing]\
>  
>  : ${OSSTEST_HTMLPUB_DIR:=`getconfig Logs`}
>  
> +if [ ! -d tmp ]; then mkdir tmp; fi
> +
>  (./sg-execute-flight $flight $blessing ||
>   echo "sg-execute-flight $flight $blessing failed: $?") \
>   >tmp/$flight.transcript 2>&1

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2015-12-07 14:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-07 14:09 [PATCH OSSTEST] mg-execute-flight: create tmp directory if it doesn't exist Wei Liu
2015-12-07 14:42 ` Ian Campbell [this message]
2015-12-07 14:45   ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1449499323.29724.54.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.