* [PATCH OSSTEST] mg-execute-flight: create tmp directory if it doesn't exist
@ 2015-12-07 14:09 Wei Liu
2015-12-07 14:42 ` Ian Campbell
0 siblings, 1 reply; 3+ messages in thread
From: Wei Liu @ 2015-12-07 14:09 UTC (permalink / raw)
To: Xen-devel; +Cc: ian.jackson, Wei Liu, ian.campbell
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
mg-execute-flight | 2 ++
1 file changed, 2 insertions(+)
diff --git a/mg-execute-flight b/mg-execute-flight
index 8b2c21c..dd64aef 100755
--- a/mg-execute-flight
+++ b/mg-execute-flight
@@ -66,6 +66,8 @@ export OSSTEST_RESOURCE_PREINFO="[adhoc $blessing]\
: ${OSSTEST_HTMLPUB_DIR:=`getconfig Logs`}
+if [ ! -d tmp ]; then mkdir tmp; fi
+
(./sg-execute-flight $flight $blessing ||
echo "sg-execute-flight $flight $blessing failed: $?") \
>tmp/$flight.transcript 2>&1
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH OSSTEST] mg-execute-flight: create tmp directory if it doesn't exist
2015-12-07 14:09 [PATCH OSSTEST] mg-execute-flight: create tmp directory if it doesn't exist Wei Liu
@ 2015-12-07 14:42 ` Ian Campbell
2015-12-07 14:45 ` Ian Jackson
0 siblings, 1 reply; 3+ messages in thread
From: Ian Campbell @ 2015-12-07 14:42 UTC (permalink / raw)
To: Wei Liu, Xen-devel; +Cc: ian.jackson
On Mon, 2015-12-07 at 14:09 +0000, Wei Liu wrote:
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
Most other places just do "mkdir -p tmp" (-p includes "no error if
existing"). I guess it doesn't really matter either way.
Ian.
> ---
> mg-execute-flight | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/mg-execute-flight b/mg-execute-flight
> index 8b2c21c..dd64aef 100755
> --- a/mg-execute-flight
> +++ b/mg-execute-flight
> @@ -66,6 +66,8 @@ export OSSTEST_RESOURCE_PREINFO="[adhoc $blessing]\
>
> : ${OSSTEST_HTMLPUB_DIR:=`getconfig Logs`}
>
> +if [ ! -d tmp ]; then mkdir tmp; fi
> +
> (./sg-execute-flight $flight $blessing ||
> echo "sg-execute-flight $flight $blessing failed: $?") \
> >tmp/$flight.transcript 2>&1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH OSSTEST] mg-execute-flight: create tmp directory if it doesn't exist
2015-12-07 14:42 ` Ian Campbell
@ 2015-12-07 14:45 ` Ian Jackson
0 siblings, 0 replies; 3+ messages in thread
From: Ian Jackson @ 2015-12-07 14:45 UTC (permalink / raw)
To: Ian Campbell; +Cc: Xen-devel, Wei Liu
Ian Campbell writes ("Re: [PATCH OSSTEST] mg-execute-flight: create tmp directory if it doesn't exist"):
> On Mon, 2015-12-07 at 14:09 +0000, Wei Liu wrote:
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
>
> Most other places just do "mkdir -p tmp" (-p includes "no error if
> existing"). I guess it doesn't really matter either way.
mkdir -p is better IMO because it's simpler...
Ian.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-12-07 14:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-07 14:09 [PATCH OSSTEST] mg-execute-flight: create tmp directory if it doesn't exist Wei Liu
2015-12-07 14:42 ` Ian Campbell
2015-12-07 14:45 ` Ian Jackson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.