[OSSTEST PATCH] Executive: Permit OSSTEST_TASK=<refkey> (for static tasks)

[OSSTEST PATCH] Executive: Permit OSSTEST_TASK=<refkey> (for static tasks)

[Ian Jackson]

If OSSTEST_TASK is not set, we construct a <refkey> from the username
and the nodename, and look for a such a static task.  If OSSTEST_TASK
/is/ set would require it to contain `<taskid> <type> <refkey>'.

In this patch, permit OSSTEST_TASK to be set simply to the <refkey>.
This is much more convenient and doesn't involve manually looking up
taskids.  The risk of error seems negligible.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
 Osstest/Executive.pm |    8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/Osstest/Executive.pm b/Osstest/Executive.pm
index fcef83f..84c7d46 100644
--- a/Osstest/Executive.pm
+++ b/Osstest/Executive.pm
@@ -446,13 +446,15 @@ sub findtask () {
     if (!defined $spec) {
         $!=0; $?=0; my $node=   `uname -n`; defined $node   or die "$? $!";
         chomp($node); $node =~ s/\..*//;
-        my $refkey= "$c{Username}\@$node";
-        $what= "static $refkey";
+	$spec= "$c{Username}\@$node";
+    }
+    if ($spec !~ m/\s/) {
+        $what= "static $spec";
         $q= $dbh_tests->prepare(<<END);
             SELECT * FROM tasks
                     WHERE type='static' AND refkey=?
 END
-        $q->execute($refkey);
+        $q->execute($spec);
     } else {
         my @l = split /\s+/, $spec;
         @l==3 or die "$spec ".scalar(@l)." ?";
-- 
1.7.10.4

Re: [OSSTEST PATCH] Executive: Permit OSSTEST_TASK=<refkey> (for static tasks)

[Ian Campbell]

On Tue, 2015-12-08 at 14:19 +0000, Ian Jackson wrote:
> If OSSTEST_TASK is not set, we construct a <refkey> from the username
> and the nodename, and look for a such a static task.  If OSSTEST_TASK
> /is/ set would require it to contain `<taskid> <type> <refkey>'.
> 
> In this patch, permit OSSTEST_TASK to be set simply to the <refkey>.
> This is much more convenient and doesn't involve manually looking up
> taskids.  The risk of error seems negligible.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>

Acked-by: Ian Campbell <ian.campbell@citrix.com>


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel