* [PATCH] Fix regression in xendomains initscript: test for privcmd char device
@ 2015-12-08 15:07 Sander Eikelenboom
2015-12-08 15:14 ` Ian Jackson
0 siblings, 1 reply; 3+ messages in thread
From: Sander Eikelenboom @ 2015-12-08 15:07 UTC (permalink / raw)
To: xen-devel; +Cc: Doug Goldstein, Ian Jackson, Ian Campbell, Sander Eikelenboom
Since commit:
"xendomains initscript: test for privcmd char device"
(1367e9e5ba4d1612e303123ec0bbf961100fcfa1)
due to incorrect negation the xendomains initscript bails out
early when both: "/dev/xen/privcmd" and "/proc/xen/privcmd"
are present in dom0.
Signed-off-by: Sander Eikelenboom <linux@eikelenboom.it>
---
tools/hotplug/Linux/xendomains.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/hotplug/Linux/xendomains.in b/tools/hotplug/Linux/xendomains.in
index 686f061..dfe0b33 100644
--- a/tools/hotplug/Linux/xendomains.in
+++ b/tools/hotplug/Linux/xendomains.in
@@ -45,7 +45,7 @@ fi
# Correct exit code would probably be 5, but it's enough
# if xend complains if we're not running as privileged domain
-if ! [ -e /dev/xen/privcmd ] || [ -e /proc/xen/privcmd ]; then
+if [ ! -e /dev/xen/privcmd ] && [ ! -e /proc/xen/privcmd ]; then
exit 0
fi
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix regression in xendomains initscript: test for privcmd char device
2015-12-08 15:07 [PATCH] Fix regression in xendomains initscript: test for privcmd char device Sander Eikelenboom
@ 2015-12-08 15:14 ` Ian Jackson
2015-12-08 17:21 ` Ian Campbell
0 siblings, 1 reply; 3+ messages in thread
From: Ian Jackson @ 2015-12-08 15:14 UTC (permalink / raw)
To: Sander Eikelenboom; +Cc: xen-devel, Doug Goldstein, Ian Campbell
Sander Eikelenboom writes ("[PATCH] Fix regression in xendomains initscript: test for privcmd char device"):
> Since commit:
> "xendomains initscript: test for privcmd char device"
> (1367e9e5ba4d1612e303123ec0bbf961100fcfa1)
> due to incorrect negation the xendomains initscript bails out
> early when both: "/dev/xen/privcmd" and "/proc/xen/privcmd"
> are present in dom0.
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Sorry for not spotting this bug when reading the patch before it was
committed !
Ian.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Fix regression in xendomains initscript: test for privcmd char device
2015-12-08 15:14 ` Ian Jackson
@ 2015-12-08 17:21 ` Ian Campbell
0 siblings, 0 replies; 3+ messages in thread
From: Ian Campbell @ 2015-12-08 17:21 UTC (permalink / raw)
To: Ian Jackson, Sander Eikelenboom; +Cc: xen-devel, Doug Goldstein
On Tue, 2015-12-08 at 15:14 +0000, Ian Jackson wrote:
> Sander Eikelenboom writes ("[PATCH] Fix regression in xendomains
> initscript: test for privcmd char device"):
> > Since commit:
> > "xendomains initscript: test for privcmd char device"
> > (1367e9e5ba4d1612e303123ec0bbf961100fcfa1)
> > due to incorrect negation the xendomains initscript bails out
> > early when both: "/dev/xen/privcmd" and "/proc/xen/privcmd"
> > are present in dom0.
>
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-12-08 17:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-08 15:07 [PATCH] Fix regression in xendomains initscript: test for privcmd char device Sander Eikelenboom
2015-12-08 15:14 ` Ian Jackson
2015-12-08 17:21 ` Ian Campbell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.