From: Johannes Berg <johannes@sipsolutions.net>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Golan Ben-Ami <golan.ben.ami@intel.com>
Cc: Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
Intel Linux Wireless <linuxwifi@intel.com>,
Kalle Valo <kvalo@codeaurora.org>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] iwlwifi: mvm: remove an extra tab
Date: Wed, 09 Dec 2015 10:41:22 +0000 [thread overview]
Message-ID: <1449657682.2304.1.camel@sipsolutions.net> (raw)
In-Reply-To: <20151209102608.GF3173@mwanda> (sfid-20151209_112631_985246_0F4FF2B2)
On Wed, 2015-12-09 at 13:26 +0300, Dan Carpenter wrote:
> Smatch prints a static checker warning here:
>
> drivers/net/wireless/intel/iwlwifi/mvm/fw-dbg.c:386
> iwl_dump_prph()
> warn: curly braces intended?
>
> Curly braces are NOT intended, the extra tab was added by mistake in
> commit 1a616dd2f171 ('iwlwifi: dump prph registers in a common place
> for all transports').
>
Applied, thanks.
johannes
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Berg <johannes@sipsolutions.net>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Golan Ben-Ami <golan.ben.ami@intel.com>
Cc: Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
Intel Linux Wireless <linuxwifi@intel.com>,
Kalle Valo <kvalo@codeaurora.org>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] iwlwifi: mvm: remove an extra tab
Date: Wed, 09 Dec 2015 11:41:22 +0100 [thread overview]
Message-ID: <1449657682.2304.1.camel@sipsolutions.net> (raw)
In-Reply-To: <20151209102608.GF3173@mwanda> (sfid-20151209_112631_985246_0F4FF2B2)
On Wed, 2015-12-09 at 13:26 +0300, Dan Carpenter wrote:
> Smatch prints a static checker warning here:
>
> drivers/net/wireless/intel/iwlwifi/mvm/fw-dbg.c:386
> iwl_dump_prph()
> warn: curly braces intended?
>
> Curly braces are NOT intended, the extra tab was added by mistake in
> commit 1a616dd2f171 ('iwlwifi: dump prph registers in a common place
> for all transports').
>
Applied, thanks.
johannes
next prev parent reply other threads:[~2015-12-09 10:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 10:26 [patch] iwlwifi: mvm: remove an extra tab Dan Carpenter
2015-12-09 10:26 ` Dan Carpenter
2015-12-09 10:41 ` Johannes Berg [this message]
2015-12-09 10:41 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449657682.2304.1.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=dan.carpenter@oracle.com \
--cc=emmanuel.grumbach@intel.com \
--cc=golan.ben.ami@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxwifi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.