* [PATCH] tools: always enable HAS_MEM_ACCESS
@ 2015-12-11 16:00 Doug Goldstein
2015-12-14 8:59 ` Jan Beulich
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Doug Goldstein @ 2015-12-11 16:00 UTC (permalink / raw)
To: xen-devel
Cc: Tamas K Lengyel, Wei Liu, Ian Campbell, Razvan Cojocaru,
Stefano Stabellini, Doug Goldstein, Ian Jackson
For all supported targets HAS_MEM_ACCESS is enabled so this drops the
conditional and always makes it enabled. The goal here is to remove the
setting in the top level config directory when kconfig changes land.
Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
---
tools/tests/xen-access/Makefile | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tools/tests/xen-access/Makefile b/tools/tests/xen-access/Makefile
index f810543..dd70f9f 100644
--- a/tools/tests/xen-access/Makefile
+++ b/tools/tests/xen-access/Makefile
@@ -7,8 +7,7 @@ CFLAGS += $(CFLAGS_libxenctrl)
CFLAGS += $(CFLAGS_libxenguest)
CFLAGS += $(CFLAGS_xeninclude)
-TARGETS-y :=
-TARGETS-$(HAS_MEM_ACCESS) := xen-access
+TARGETS-y := xen-access
TARGETS := $(TARGETS-y)
.PHONY: all
--
2.4.10
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] tools: always enable HAS_MEM_ACCESS
2015-12-11 16:00 [PATCH] tools: always enable HAS_MEM_ACCESS Doug Goldstein
@ 2015-12-14 8:59 ` Jan Beulich
2015-12-14 11:44 ` Razvan Cojocaru
2015-12-15 12:11 ` Ian Campbell
2 siblings, 0 replies; 5+ messages in thread
From: Jan Beulich @ 2015-12-14 8:59 UTC (permalink / raw)
To: Doug Goldstein
Cc: Tamas K Lengyel, Wei Liu, Ian Campbell, Razvan Cojocaru,
Stefano Stabellini, Ian Jackson, xen-devel
>>> On 11.12.15 at 17:00, <cardoe@cardoe.com> wrote:
> For all supported targets HAS_MEM_ACCESS is enabled so this drops the
> conditional and always makes it enabled. The goal here is to remove the
> setting in the top level config directory when kconfig changes land.
Suggested-by: Jan Beulich <jbeulich@suse.com>
> Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
Thanks for the patch,
Jan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] tools: always enable HAS_MEM_ACCESS
2015-12-11 16:00 [PATCH] tools: always enable HAS_MEM_ACCESS Doug Goldstein
2015-12-14 8:59 ` Jan Beulich
@ 2015-12-14 11:44 ` Razvan Cojocaru
2015-12-15 12:11 ` Ian Campbell
2 siblings, 0 replies; 5+ messages in thread
From: Razvan Cojocaru @ 2015-12-14 11:44 UTC (permalink / raw)
To: Doug Goldstein, xen-devel
Cc: Wei Liu, Tamas K Lengyel, Ian Jackson, Ian Campbell,
Stefano Stabellini
On 12/11/2015 06:00 PM, Doug Goldstein wrote:
> For all supported targets HAS_MEM_ACCESS is enabled so this drops the
> conditional and always makes it enabled. The goal here is to remove the
> setting in the top level config directory when kconfig changes land.
>
> Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
Acked-by: Razvan Cojocaru <rcojocaru@bitdefender.com>
Thanks,
Razvan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] tools: always enable HAS_MEM_ACCESS
2015-12-11 16:00 [PATCH] tools: always enable HAS_MEM_ACCESS Doug Goldstein
2015-12-14 8:59 ` Jan Beulich
2015-12-14 11:44 ` Razvan Cojocaru
@ 2015-12-15 12:11 ` Ian Campbell
2015-12-16 12:14 ` Ian Campbell
2 siblings, 1 reply; 5+ messages in thread
From: Ian Campbell @ 2015-12-15 12:11 UTC (permalink / raw)
To: Doug Goldstein, xen-devel
Cc: Wei Liu, Tamas K Lengyel, Ian Jackson, Razvan Cojocaru,
Stefano Stabellini
On Fri, 2015-12-11 at 10:00 -0600, Doug Goldstein wrote:
> For all supported targets HAS_MEM_ACCESS is enabled so this drops the
> conditional and always makes it enabled. The goal here is to remove the
> setting in the top level config directory when kconfig changes land.
>
> Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
I suppose any future arch which doesn't initially add xen access support
will have to patch the Kconfig later on, which is fine by me.
> ---
> tools/tests/xen-access/Makefile | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/tools/tests/xen-access/Makefile b/tools/tests/xen-
> access/Makefile
> index f810543..dd70f9f 100644
> --- a/tools/tests/xen-access/Makefile
> +++ b/tools/tests/xen-access/Makefile
> @@ -7,8 +7,7 @@ CFLAGS += $(CFLAGS_libxenctrl)
> CFLAGS += $(CFLAGS_libxenguest)
> CFLAGS += $(CFLAGS_xeninclude)
>
> -TARGETS-y :=
> -TARGETS-$(HAS_MEM_ACCESS) := xen-access
> +TARGETS-y := xen-access
> TARGETS := $(TARGETS-y)
>
> .PHONY: all
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] tools: always enable HAS_MEM_ACCESS
2015-12-15 12:11 ` Ian Campbell
@ 2015-12-16 12:14 ` Ian Campbell
0 siblings, 0 replies; 5+ messages in thread
From: Ian Campbell @ 2015-12-16 12:14 UTC (permalink / raw)
To: Doug Goldstein, xen-devel
Cc: Ian Jackson, Tamas K Lengyel, Wei Liu, Razvan Cojocaru,
Stefano Stabellini
On Tue, 2015-12-15 at 12:11 +0000, Ian Campbell wrote:
> On Fri, 2015-12-11 at 10:00 -0600, Doug Goldstein wrote:
> > For all supported targets HAS_MEM_ACCESS is enabled so this drops the
> > conditional and always makes it enabled. The goal here is to remove the
> > setting in the top level config directory when kconfig changes land.
> >
> > Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
and now applied, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-12-16 12:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-11 16:00 [PATCH] tools: always enable HAS_MEM_ACCESS Doug Goldstein
2015-12-14 8:59 ` Jan Beulich
2015-12-14 11:44 ` Razvan Cojocaru
2015-12-15 12:11 ` Ian Campbell
2015-12-16 12:14 ` Ian Campbell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.