From: Ian Campbell <ian.campbell@citrix.com>
To: Juergen Gross <jgross@suse.com>,
xen-devel@lists.xen.org, ian.jackson@eu.citrix.com,
stefano.stabellini@eu.citrix.com, wei.liu2@citrix.com
Cc: Daniel De Graaf <dgdegra@tycho.nsa.gov>
Subject: Re: [PATCH 4/9] xenstore: add error messages to init-xenstore-domain
Date: Tue, 15 Dec 2015 12:20:27 +0000 [thread overview]
Message-ID: <1450182027.16856.155.camel@citrix.com> (raw)
In-Reply-To: <1449848861-7700-5-git-send-email-jgross@suse.com>
Adding Daniel again.
On Fri, 2015-12-11 at 16:47 +0100, Juergen Gross wrote:
> Additional add some diagnostic messages to the program to have an idea
> why it failed.
[...]
> err:
> if (dom)
> xc_dom_release(dom);
> + if (domid >= 0)
> + xc_domain_destroy(xch, domid);
This important looking bug fix should't be buried in this otherwise quite
mechanical commit.
The rest looks reasonable, so with the above moved to a separate commit
this one would be:
Acked-by: Ian Campbell <ian.campbell@citrix.com>
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2015-12-15 12:20 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-11 15:47 [PATCH 0/9] xenstore: make it easier to run xenstore in a domain Juergen Gross
2015-12-11 15:47 ` [PATCH 1/9] xen: add xenstore domain flag to hypervisor Juergen Gross
2015-12-11 15:54 ` Fwd: " Juergen Gross
2015-12-15 22:18 ` Daniel De Graaf
2015-12-11 15:47 ` [PATCH 2/9] libxc: support new xenstore domain flag in libxc Juergen Gross
2015-12-11 15:47 ` [PATCH 3/9] xenstore: install init-xenstore-domain via make install Juergen Gross
2015-12-15 12:16 ` Ian Campbell
2015-12-15 12:19 ` Juergen Gross
2015-12-15 12:31 ` Ian Campbell
2015-12-15 21:41 ` Daniel De Graaf
2015-12-16 6:27 ` Juergen Gross
2015-12-16 10:01 ` Ian Campbell
2015-12-11 15:47 ` [PATCH 4/9] xenstore: add error messages to init-xenstore-domain Juergen Gross
2015-12-15 12:20 ` Ian Campbell [this message]
2015-12-15 21:54 ` Daniel De Graaf
2015-12-11 15:47 ` [PATCH 5/9] xenstore: modify init-xenstore-domain parameter syntax Juergen Gross
2015-12-15 12:22 ` Ian Campbell
2015-12-15 21:49 ` Daniel De Graaf
2015-12-11 15:47 ` [PATCH 6/9] xenstore: don't start xenstore domain if already one is active Juergen Gross
2015-12-15 12:23 ` Ian Campbell
2015-12-15 12:28 ` Juergen Gross
2015-12-15 12:32 ` Ian Campbell
2015-12-15 12:40 ` Juergen Gross
2015-12-15 12:47 ` Ian Campbell
2015-12-15 12:49 ` Juergen Gross
2015-12-11 15:47 ` [PATCH 7/9] xenstore: add init-xenstore-domain parameter to specify cmdline Juergen Gross
2015-12-15 12:24 ` Ian Campbell
2015-12-11 15:47 ` [PATCH 8/9] xenstore: write xenstore domain data to xenstore Juergen Gross
2015-12-15 12:26 ` Ian Campbell
2015-12-15 12:34 ` Juergen Gross
2015-12-15 12:49 ` Ian Campbell
2015-12-15 12:53 ` Juergen Gross
2015-12-15 13:19 ` Ian Campbell
2015-12-15 13:30 ` Juergen Gross
2015-12-17 8:26 ` Juergen Gross
2015-12-17 10:01 ` Ian Campbell
2015-12-17 10:08 ` Juergen Gross
2015-12-17 10:16 ` Ian Campbell
2015-12-11 15:47 ` [PATCH 9/9] xenstore: when running in mini-os use printk for diagnostic messages Juergen Gross
2015-12-15 12:31 ` Ian Campbell
2015-12-15 12:47 ` Juergen Gross
2015-12-15 12:52 ` Ian Campbell
2015-12-15 12:55 ` Juergen Gross
2015-12-15 14:06 ` Andrew Cooper
2015-12-15 14:57 ` Juergen Gross
2015-12-15 15:01 ` Andrew Cooper
2015-12-15 15:44 ` Juergen Gross
2015-12-17 16:38 ` Juergen Gross
2015-12-15 13:03 ` Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1450182027.16856.155.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=ian.jackson@eu.citrix.com \
--cc=jgross@suse.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.