From: Ian Campbell <ian.campbell@citrix.com>
To: Juergen Gross <jgross@suse.com>,
xen-devel@lists.xen.org, ian.jackson@eu.citrix.com,
stefano.stabellini@eu.citrix.com, wei.liu2@citrix.com
Subject: Re: [PATCH 8/9] xenstore: write xenstore domain data to xenstore
Date: Tue, 15 Dec 2015 12:26:20 +0000 [thread overview]
Message-ID: <1450182380.16856.159.camel@citrix.com> (raw)
In-Reply-To: <1449848861-7700-9-git-send-email-jgross@suse.com>
On Fri, 2015-12-11 at 16:47 +0100, Juergen Gross wrote:
> After starting the xenstore domain write the basic data (domid and
> name) to the xenstore.
>
> Add a new option to init-xenstore-domain to be able to specify the
> domain's name.
Is all this enough to keep "xl list" etc happy?
Do we need to also create a dummy json object like we do for dom0 (init-
xen-dom0)?
> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---
> tools/xenstore/init-xenstore-domain.c | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/tools/xenstore/init-xenstore-domain.c b/tools/xenstore/init-
> xenstore-domain.c
> index eedcf32..2a8a417 100644
> --- a/tools/xenstore/init-xenstore-domain.c
> +++ b/tools/xenstore/init-xenstore-domain.c
> @@ -18,6 +18,7 @@ static char *kernel;
> static char *ramdisk;
> static char *flask;
> static char *param;
> +static char *name = "Xenstore";
> static int memory;
>
> static struct option options[] = {
> @@ -26,6 +27,7 @@ static struct option options[] = {
> { "flask", 1, NULL, 'f' },
> { "ramdisk", 1, NULL, 'r' },
> { "param", 1, NULL, 'p' },
> + { "name", 1, NULL, 'n' },
> { NULL, 0, NULL, 0 }
> };
>
> @@ -42,7 +44,8 @@ static void usage(void)
> " --memory <memory size> size of the domain in MB, mandatory\n"
> " --flask <flask-label> optional flask label of the domain\n"
> " --ramdisk <ramdisk-file> optional ramdisk file for the domain\n"
> -" --param <cmdline> optional additional parameters for the
> domain\n");
> +" --param <cmdline> optional additional parameters for the
> domain\n"
> +" --name <name> name of the domain (default:
> Xenstore)\n");
> }
>
> static int build(xc_interface *xch)
> @@ -195,6 +198,7 @@ int main(int argc, char** argv)
> xc_interface *xch;
> struct xs_handle *xsh;
> char buf[16];
> + char path[64];
> int rv, fd;
>
> while ((opt = getopt_long(argc, argv, "", options, NULL)) != -1)
> {
> @@ -214,6 +218,9 @@ int main(int argc, char** argv)
> case 'p':
> param = optarg;
> break;
> + case 'n':
> + name = optarg;
> + break;
> }
> }
>
> @@ -243,6 +250,10 @@ int main(int argc, char** argv)
> xsh = xs_open(0);
> rv = snprintf(buf, 16, "%d", domid);
> xs_write(xsh, XBT_NULL, "/tool/xenstored/domid", buf, rv);
> + snprintf(path, 64, "/local/domain/%d/domid", domid);
> + xs_write(xsh, XBT_NULL, path, buf, rv);
> + snprintf(path, 64, "/local/domain/%d/name", domid);
> + xs_write(xsh, XBT_NULL, path, name, strlen(name));
> xs_daemon_close(xsh);
>
> fd = creat("/var/run/xenstored.pid", 0666);
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2015-12-15 12:26 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-11 15:47 [PATCH 0/9] xenstore: make it easier to run xenstore in a domain Juergen Gross
2015-12-11 15:47 ` [PATCH 1/9] xen: add xenstore domain flag to hypervisor Juergen Gross
2015-12-11 15:54 ` Fwd: " Juergen Gross
2015-12-15 22:18 ` Daniel De Graaf
2015-12-11 15:47 ` [PATCH 2/9] libxc: support new xenstore domain flag in libxc Juergen Gross
2015-12-11 15:47 ` [PATCH 3/9] xenstore: install init-xenstore-domain via make install Juergen Gross
2015-12-15 12:16 ` Ian Campbell
2015-12-15 12:19 ` Juergen Gross
2015-12-15 12:31 ` Ian Campbell
2015-12-15 21:41 ` Daniel De Graaf
2015-12-16 6:27 ` Juergen Gross
2015-12-16 10:01 ` Ian Campbell
2015-12-11 15:47 ` [PATCH 4/9] xenstore: add error messages to init-xenstore-domain Juergen Gross
2015-12-15 12:20 ` Ian Campbell
2015-12-15 21:54 ` Daniel De Graaf
2015-12-11 15:47 ` [PATCH 5/9] xenstore: modify init-xenstore-domain parameter syntax Juergen Gross
2015-12-15 12:22 ` Ian Campbell
2015-12-15 21:49 ` Daniel De Graaf
2015-12-11 15:47 ` [PATCH 6/9] xenstore: don't start xenstore domain if already one is active Juergen Gross
2015-12-15 12:23 ` Ian Campbell
2015-12-15 12:28 ` Juergen Gross
2015-12-15 12:32 ` Ian Campbell
2015-12-15 12:40 ` Juergen Gross
2015-12-15 12:47 ` Ian Campbell
2015-12-15 12:49 ` Juergen Gross
2015-12-11 15:47 ` [PATCH 7/9] xenstore: add init-xenstore-domain parameter to specify cmdline Juergen Gross
2015-12-15 12:24 ` Ian Campbell
2015-12-11 15:47 ` [PATCH 8/9] xenstore: write xenstore domain data to xenstore Juergen Gross
2015-12-15 12:26 ` Ian Campbell [this message]
2015-12-15 12:34 ` Juergen Gross
2015-12-15 12:49 ` Ian Campbell
2015-12-15 12:53 ` Juergen Gross
2015-12-15 13:19 ` Ian Campbell
2015-12-15 13:30 ` Juergen Gross
2015-12-17 8:26 ` Juergen Gross
2015-12-17 10:01 ` Ian Campbell
2015-12-17 10:08 ` Juergen Gross
2015-12-17 10:16 ` Ian Campbell
2015-12-11 15:47 ` [PATCH 9/9] xenstore: when running in mini-os use printk for diagnostic messages Juergen Gross
2015-12-15 12:31 ` Ian Campbell
2015-12-15 12:47 ` Juergen Gross
2015-12-15 12:52 ` Ian Campbell
2015-12-15 12:55 ` Juergen Gross
2015-12-15 14:06 ` Andrew Cooper
2015-12-15 14:57 ` Juergen Gross
2015-12-15 15:01 ` Andrew Cooper
2015-12-15 15:44 ` Juergen Gross
2015-12-17 16:38 ` Juergen Gross
2015-12-15 13:03 ` Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1450182380.16856.159.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jgross@suse.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.