* [PATCH] xen: arm: Drop trailing ; from DEFINE_XEN_GUEST_HANDLE
@ 2015-12-14 16:21 Ian Campbell
2015-12-14 16:25 ` Stefano Stabellini
2015-12-14 16:41 ` Jan Beulich
0 siblings, 2 replies; 4+ messages in thread
From: Ian Campbell @ 2015-12-14 16:21 UTC (permalink / raw)
To: stefano.stabellini, julien.grall, xen-devel; +Cc: Ian Campbell
This is always present at the point of use, which with -pedantic
provokes:
error: ISO C does not allow extra ';' outside of a function [-Werror=edantic]
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
xen/include/public/arch-arm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
index 6322548..870bc3b 100644
--- a/xen/include/public/arch-arm.h
+++ b/xen/include/public/arch-arm.h
@@ -173,7 +173,7 @@
typedef union { type *p; unsigned long q; } \
__guest_handle_ ## name; \
typedef union { type *p; uint64_aligned_t q; } \
- __guest_handle_64_ ## name;
+ __guest_handle_64_ ## name
/*
* XEN_GUEST_HANDLE represents a guest pointer, when passed as a field
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] xen: arm: Drop trailing ; from DEFINE_XEN_GUEST_HANDLE
2015-12-14 16:21 [PATCH] xen: arm: Drop trailing ; from DEFINE_XEN_GUEST_HANDLE Ian Campbell
@ 2015-12-14 16:25 ` Stefano Stabellini
2015-12-14 16:41 ` Jan Beulich
1 sibling, 0 replies; 4+ messages in thread
From: Stefano Stabellini @ 2015-12-14 16:25 UTC (permalink / raw)
To: Ian Campbell; +Cc: julien.grall, xen-devel, stefano.stabellini
On Mon, 14 Dec 2015, Ian Campbell wrote:
> This is always present at the point of use, which with -pedantic
> provokes:
>
> error: ISO C does not allow extra ';' outside of a function [-Werror=edantic]
>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> xen/include/public/arch-arm.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
> index 6322548..870bc3b 100644
> --- a/xen/include/public/arch-arm.h
> +++ b/xen/include/public/arch-arm.h
> @@ -173,7 +173,7 @@
> typedef union { type *p; unsigned long q; } \
> __guest_handle_ ## name; \
> typedef union { type *p; uint64_aligned_t q; } \
> - __guest_handle_64_ ## name;
> + __guest_handle_64_ ## name
>
> /*
> * XEN_GUEST_HANDLE represents a guest pointer, when passed as a field
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xen: arm: Drop trailing ; from DEFINE_XEN_GUEST_HANDLE
2015-12-14 16:21 [PATCH] xen: arm: Drop trailing ; from DEFINE_XEN_GUEST_HANDLE Ian Campbell
2015-12-14 16:25 ` Stefano Stabellini
@ 2015-12-14 16:41 ` Jan Beulich
2015-12-15 12:30 ` Ian Campbell
1 sibling, 1 reply; 4+ messages in thread
From: Jan Beulich @ 2015-12-14 16:41 UTC (permalink / raw)
To: Ian Campbell; +Cc: julien.grall, xen-devel, stefano.stabellini
>>> On 14.12.15 at 17:21, <ian.campbell@citrix.com> wrote:
> This is always present at the point of use, which with -pedantic
> provokes:
>
> error: ISO C does not allow extra ';' outside of a function [-Werror=edantic]
>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
FWIW Acked-by: Jan Beulich <jbeulich@suse.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xen: arm: Drop trailing ; from DEFINE_XEN_GUEST_HANDLE
2015-12-14 16:41 ` Jan Beulich
@ 2015-12-15 12:30 ` Ian Campbell
0 siblings, 0 replies; 4+ messages in thread
From: Ian Campbell @ 2015-12-15 12:30 UTC (permalink / raw)
To: Jan Beulich; +Cc: julien.grall, xen-devel, stefano.stabellini
On Mon, 2015-12-14 at 09:41 -0700, Jan Beulich wrote:
> > > > On 14.12.15 at 17:21, <ian.campbell@citrix.com> wrote:
> > This is always present at the point of use, which with -pedantic
> > provokes:
> >
> > error: ISO C does not allow extra ';' outside of a function [-
> > Werror=edantic]
> >
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
>
> FWIW Acked-by: Jan Beulich <jbeulich@suse.com>
Thanks, applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-12-15 12:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-14 16:21 [PATCH] xen: arm: Drop trailing ; from DEFINE_XEN_GUEST_HANDLE Ian Campbell
2015-12-14 16:25 ` Stefano Stabellini
2015-12-14 16:41 ` Jan Beulich
2015-12-15 12:30 ` Ian Campbell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.