All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jerome Marchand <jmarchan@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	dave hansen <dave.hansen@intel.com>
Subject: Re: [PATCH v4 2/2] mm: allow to set overcommit ratio more precisely
Date: Wed, 6 Nov 2013 03:42:20 -0500 (EST)	[thread overview]
Message-ID: <1450211196.19341043.1383727340985.JavaMail.root@redhat.com> (raw)
In-Reply-To: <20131105155319.732dcbefb162c2ee4716ef9d@linux-foundation.org>



----- Original Message -----
> From: "Andrew Morton" <akpm@linux-foundation.org>
> To: "Jerome Marchand" <jmarchan@redhat.com>
> Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, "dave hansen" <dave.hansen@intel.com>
> Sent: Wednesday, November 6, 2013 12:53:19 AM
> Subject: Re: [PATCH v4 2/2] mm: allow to set overcommit ratio more precisely
> 
> On Fri, 18 Oct 2013 14:56:59 +0200 Jerome Marchand <jmarchan@redhat.com>
> wrote:
> 
> > Some applications that run on HPC clusters are designed around the
> > availability of RAM and the overcommit ratio is fine tuned to get the
> > maximum usage of memory without swapping. With growing memory, the 1%
> > of all RAM grain provided by overcommit_ratio has become too coarse
> > for these workload (on a 2TB machine it represents no less than
> > 20GB).
> > 
> > This patch adds the new overcommit_ratio_ppm sysctl variable that
> > allow to set overcommit ratio with a part per million precision.
> > The old overcommit_ratio variable can still be used to set and read
> > the ratio with a 1% precision. That way, overcommit_ratio interface
> > isn't broken in any way that I can imagine.
> 
> The way we've permanently squished this mistake in the past is to
> switch to "bytes".  See /proc/sys/vm/*bytes.
> 
> Would that approach work in this case?
> 

That was my first version of this patch (actually "kbytes" to avoid
overflow).
Dave raised the issue that it silently breaks the user interface:
overcommit_ratio is zero while the system behaves differently.

Jerome

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Jerome Marchand <jmarchan@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	dave hansen <dave.hansen@intel.com>
Subject: Re: [PATCH v4 2/2] mm: allow to set overcommit ratio more precisely
Date: Wed, 6 Nov 2013 03:42:20 -0500 (EST)	[thread overview]
Message-ID: <1450211196.19341043.1383727340985.JavaMail.root@redhat.com> (raw)
In-Reply-To: <20131105155319.732dcbefb162c2ee4716ef9d@linux-foundation.org>



----- Original Message -----
> From: "Andrew Morton" <akpm@linux-foundation.org>
> To: "Jerome Marchand" <jmarchan@redhat.com>
> Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, "dave hansen" <dave.hansen@intel.com>
> Sent: Wednesday, November 6, 2013 12:53:19 AM
> Subject: Re: [PATCH v4 2/2] mm: allow to set overcommit ratio more precisely
> 
> On Fri, 18 Oct 2013 14:56:59 +0200 Jerome Marchand <jmarchan@redhat.com>
> wrote:
> 
> > Some applications that run on HPC clusters are designed around the
> > availability of RAM and the overcommit ratio is fine tuned to get the
> > maximum usage of memory without swapping. With growing memory, the 1%
> > of all RAM grain provided by overcommit_ratio has become too coarse
> > for these workload (on a 2TB machine it represents no less than
> > 20GB).
> > 
> > This patch adds the new overcommit_ratio_ppm sysctl variable that
> > allow to set overcommit ratio with a part per million precision.
> > The old overcommit_ratio variable can still be used to set and read
> > the ratio with a 1% precision. That way, overcommit_ratio interface
> > isn't broken in any way that I can imagine.
> 
> The way we've permanently squished this mistake in the past is to
> switch to "bytes".  See /proc/sys/vm/*bytes.
> 
> Would that approach work in this case?
> 

That was my first version of this patch (actually "kbytes" to avoid
overflow).
Dave raised the issue that it silently breaks the user interface:
overcommit_ratio is zero while the system behaves differently.

Jerome

  reply	other threads:[~2013-11-06  8:42 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-18 12:56 [PATCH v4 1/2] mm: factor commit limit calculation Jerome Marchand
2013-10-18 12:56 ` Jerome Marchand
2013-10-18 12:56 ` [PATCH v4 2/2] mm: allow to set overcommit ratio more precisely Jerome Marchand
2013-10-18 12:56   ` Jerome Marchand
2013-11-05 23:53   ` Andrew Morton
2013-11-05 23:53     ` Andrew Morton
2013-11-06  8:42     ` Jerome Marchand [this message]
2013-11-06  8:42       ` Jerome Marchand
2013-11-06 22:33       ` Andrew Morton
2013-11-06 22:33         ` Andrew Morton
2013-11-06 23:49         ` Dave Hansen
2013-11-06 23:49           ` Dave Hansen
2013-11-07 10:43           ` Jerome Marchand
2013-11-07 10:43             ` Jerome Marchand
2013-12-03 13:33   ` [PATCH v5] mm: add overcommit_kbytes sysctl variable Jerome Marchand
2013-12-03 13:33     ` Jerome Marchand
2013-12-03 22:14     ` Andrew Morton
2013-12-03 22:14       ` Andrew Morton
2013-12-19  7:36     ` Olof Johansson
2013-12-19  7:36       ` Olof Johansson
2013-11-05 23:51 ` [PATCH v4 1/2] mm: factor commit limit calculation Andrew Morton
2013-11-05 23:51   ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1450211196.19341043.1383727340985.JavaMail.root@redhat.com \
    --to=jmarchan@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=dave.hansen@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.