From: Dan Williams <dcbw-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
bjorn.andersson-/MT0OVThwyLZJqsBc5GL+g@public.gmane.org
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
courtney.cavin-/MT0OVThwyLZJqsBc5GL+g@public.gmane.org
Subject: Re: [PATCH] net: add Qualcomm IPC router
Date: Tue, 15 Dec 2015 15:14:10 -0600 [thread overview]
Message-ID: <1450214050.4464.10.camel@redhat.com> (raw)
In-Reply-To: <1450214005.4464.9.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
On Tue, 2015-12-15 at 15:13 -0600, Dan Williams wrote:
> On Tue, 2015-12-15 at 16:01 -0500, David Miller wrote:
> > From: Bjorn Andersson <bjorn.andersson-/MT0OVThwyLZJqsBc5GL+g@public.gmane.org>
> > Date: Fri, 11 Dec 2015 12:41:59 -0800
> >
> > > +static unsigned int qrtr_local_nid = 1;
> > > +module_param_named(node_id, qrtr_local_nid, uint, S_IRUGO);
> > > +MODULE_PARM_DESC(idVendor, "Local Node Identifier");
>
> Also s/idVendor/node_id?
Well, not that it matters if the module parameter gets removed...
Dan
>
> Dan
>
> > Module parameters suck.
> >
> > Allow the user to choose this dynamically. You have roughtly two
> > choices.
> >
> > 1) Subvert the 'protocol' field passed to ->create() and use that,
> > it
> > is
> > being ignored otherwise.
> >
> > 2) Put it into the socket address for bind().
> > --
> > To unsubscribe from this list: send the line "unsubscribe netdev"
> > in
> > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: dcbw@redhat.com (Dan Williams)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] net: add Qualcomm IPC router
Date: Tue, 15 Dec 2015 15:14:10 -0600 [thread overview]
Message-ID: <1450214050.4464.10.camel@redhat.com> (raw)
In-Reply-To: <1450214005.4464.9.camel@redhat.com>
On Tue, 2015-12-15 at 15:13 -0600, Dan Williams wrote:
> On Tue, 2015-12-15 at 16:01 -0500, David Miller wrote:
> > From: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> > Date: Fri, 11 Dec 2015 12:41:59 -0800
> >
> > > +static unsigned int qrtr_local_nid = 1;
> > > +module_param_named(node_id, qrtr_local_nid, uint, S_IRUGO);
> > > +MODULE_PARM_DESC(idVendor, "Local Node Identifier");
>
> Also s/idVendor/node_id?
Well, not that it matters if the module parameter gets removed...
Dan
>
> Dan
>
> > Module parameters suck.
> >
> > Allow the user to choose this dynamically. You have roughtly two
> > choices.
> >
> > 1) Subvert the 'protocol' field passed to ->create() and use that,
> > it
> > is
> > being ignored otherwise.
> >
> > 2) Put it into the socket address for bind().
> > --
> > To unsubscribe from this list: send the line "unsubscribe netdev"
> > in
> > the body of a message to majordomo at vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Dan Williams <dcbw@redhat.com>
To: David Miller <davem@davemloft.net>, bjorn.andersson@sonymobile.com
Cc: linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
netdev@vger.kernel.org, srinivas.kandagatla@linaro.org,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
courtney.cavin@sonymobile.com
Subject: Re: [PATCH] net: add Qualcomm IPC router
Date: Tue, 15 Dec 2015 15:14:10 -0600 [thread overview]
Message-ID: <1450214050.4464.10.camel@redhat.com> (raw)
In-Reply-To: <1450214005.4464.9.camel@redhat.com>
On Tue, 2015-12-15 at 15:13 -0600, Dan Williams wrote:
> On Tue, 2015-12-15 at 16:01 -0500, David Miller wrote:
> > From: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> > Date: Fri, 11 Dec 2015 12:41:59 -0800
> >
> > > +static unsigned int qrtr_local_nid = 1;
> > > +module_param_named(node_id, qrtr_local_nid, uint, S_IRUGO);
> > > +MODULE_PARM_DESC(idVendor, "Local Node Identifier");
>
> Also s/idVendor/node_id?
Well, not that it matters if the module parameter gets removed...
Dan
>
> Dan
>
> > Module parameters suck.
> >
> > Allow the user to choose this dynamically. You have roughtly two
> > choices.
> >
> > 1) Subvert the 'protocol' field passed to ->create() and use that,
> > it
> > is
> > being ignored otherwise.
> >
> > 2) Put it into the socket address for bind().
> > --
> > To unsubscribe from this list: send the line "unsubscribe netdev"
> > in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-12-15 21:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-11 20:41 [PATCH] net: add Qualcomm IPC router Bjorn Andersson
2015-12-11 20:41 ` Bjorn Andersson
2015-12-11 20:41 ` Bjorn Andersson
2015-12-11 20:41 ` Bjorn Andersson
2015-12-15 21:01 ` David Miller
2015-12-15 21:01 ` David Miller
[not found] ` <20151215.160114.1178824607335349574.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2015-12-15 21:13 ` Dan Williams
2015-12-15 21:13 ` Dan Williams
2015-12-15 21:13 ` Dan Williams
[not found] ` <1450214005.4464.9.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-12-15 21:14 ` Dan Williams [this message]
2015-12-15 21:14 ` Dan Williams
2015-12-15 21:14 ` Dan Williams
2015-12-17 0:01 ` Courtney Cavin
2015-12-17 0:01 ` Courtney Cavin
2015-12-17 0:01 ` Courtney Cavin
[not found] ` <20151217000141.GG28026-/MT0OVThwyLZJqsBc5GL+g@public.gmane.org>
2015-12-17 0:16 ` David Miller
2015-12-17 0:16 ` David Miller
2015-12-17 0:16 ` David Miller
2015-12-16 23:28 ` Courtney Cavin
2015-12-16 23:28 ` Courtney Cavin
2015-12-16 23:28 ` Courtney Cavin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1450214050.4464.10.camel@redhat.com \
--to=dcbw-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=bjorn.andersson-/MT0OVThwyLZJqsBc5GL+g@public.gmane.org \
--cc=courtney.cavin-/MT0OVThwyLZJqsBc5GL+g@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.