[PATCH] m4: Drop unused/unreferenced patch

[PATCH] m4: Drop unused/unreferenced patch

[Richard Purdie]

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

diff --git a/meta/recipes-devtools/m4/m4/make.patch b/meta/recipes-devtools/m4/m4/make.patch
deleted file mode 100644
index 79fb415..0000000
--- a/meta/recipes-devtools/m4/m4/make.patch
+++ /dev/null
@@ -1,42 +0,0 @@
-Upstream-Status: Inappropriate [embedded specific]
-
-#
-# Patch managed by http://www.holgerschurig.de/patcher.html
-#
-
---- m4-1.4.2/doc/Makefile.in~make
-+++ m4-1.4.2/doc/Makefile.in
-@@ -57,9 +57,9 @@
- 	date > $(srcdir)/stamp-vti
- 
- install: all
--	$(srcdir)/../mkinstalldirs $(infodir)
-+	$(srcdir)/../mkinstalldirs $(DESTDIR)$(infodir)
- 	cd $(srcdir) && for file in m4.info*; do \
--	  $(INSTALL_DATA) $$file $(infodir)/$$file; \
-+	  $(INSTALL_DATA) $$file $(DESTDIR)$(infodir)/$$file; \
- 	done
- 
- uninstall:
---- m4-1.4.2/src/Makefile.in~make
-+++ m4-1.4.2/src/Makefile.in
-@@ -35,7 +35,7 @@
- prefix = @prefix@
- exec_prefix = @exec_prefix@
- transform = @program_transform_name@
--bindir = $(exec_prefix)/bin
-+bindir = @bindir@
- 
- COMPILE = $(CC) -c $(DEFS) $(INCLUDES) $(CPPFLAGS) $(CFLAGS)
- LINK = $(CC) $(LDFLAGS) -o $@
-@@ -84,8 +84,8 @@
- 	$(LINK) ansi2knr.o $(LIBS)
- 
- install: all
--	$(srcdir)/../mkinstalldirs $(bindir)
--	$(INSTALL_PROGRAM) m4 $(bindir)/`echo m4 | sed '$(transform)'`
-+	$(srcdir)/../mkinstalldirs $(DESTDIR)$(bindir)
-+	$(INSTALL_PROGRAM) m4 $(DESTDIR)$(bindir)/`echo m4 | sed '$(transform)'`
- 
- uninstall:
- 	rm -f $(bindir)/`echo m4 | sed '$(transform)'`

Re: [PATCH] m4: Drop unused/unreferenced patch

[Otavio Salvador]

On Tue, Dec 15, 2015 at 8:27 PM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

Is there a way to have a task, like fetchall, which checks for
non-referenced metadata files? This would help to avoid this to happen
in future.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [PATCH] m4: Drop unused/unreferenced patch

[Paul Eggleton]

Hi Otavio,

On Tue, 15 Dec 2015 22:13:53 Otavio Salvador wrote:
> Is there a way to have a task, like fetchall, which checks for
> non-referenced metadata files? This would help to avoid this to happen
> in future.

We could do this, but one place I hope we can catch this in future is in a 
script to check submitted patches [1][2] - that way we catch the error before 
it gets merged. In that context we can easily see if a reference is removed to 
a file in SRC_URI and check if there's a corresponding delete of the file 
(assuming no other recipes reference it).

Cheers,
Paul

[1] https://bugzilla.yoctoproject.org/show_bug.cgi?id=4078
[2] https://bugzilla.yoctoproject.org/show_bug.cgi?id=8648

-- 

Paul Eggleton
Intel Open Source Technology Centre

Re: [PATCH] m4: Drop unused/unreferenced patch

[Richard Purdie]

On Tue, 2015-12-15 at 22:13 -0200, Otavio Salvador wrote:
> On Tue, Dec 15, 2015 at 8:27 PM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> 
> Is there a way to have a task, like fetchall, which checks for
> non-referenced metadata files? This would help to avoid this to
> happen
> in future.

Its a nice idea, the complexity is we have patches which can be native
specific, libc specific, machine specific and so on.

I guess if there were some bitbake API to pull out 'all possible
overrides', we might be able to come up with a definitive list and do
some checks based on that. Its not a simple problem and its also not a 
top priority issue right now with available resources. Might be an idea
to open an enhancement bug for it though?

Cheers,

Richard