Re: question on "mac80211_hwsim: support any address in userspace"

[Johannes Berg <johannes@sipsolutions.net>]

On Wed, 2015-12-16 at 06:11 -0800, Ben Greear wrote:

> My code expected that the key was the MAC of the radio, not the
> MAC of a vif.  It set up mappings accordingly in the user-space
> program.
> 
> And, if I change a vif's mac address, the previous 'key' is no longer
> valid with the new patch.  If I have multiple vifs on one radio
> and want to send a broadcast pkt to that radio, then at best the
> patched API is lame because you would have to specify the address
> of one of the vifs on the radio, but it is not really destined for
> just that vif.
> 
> A fair bit of code was written, and not just by me, against the
> API that assumed the MAC of the radio was a unique key.  The
> code can be changed of course, but if Bob's change does not
> really offer any advantage, then I think the patch should
> be reverted.
> 

I guess you were trying to be much smarter than wmediumd :)

Bob, any thoughts?

johannes