All of lore.kernel.org
 help / color / mirror / Atom feed
From: "me@bobcopeland.com >> Bob Copeland" <me@bobcopeland.com>
To: Ben Greear <greearb@candelatech.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: question on "mac80211_hwsim: support any address in userspace"
Date: Wed, 16 Dec 2015 08:21:13 -0500	[thread overview]
Message-ID: <20151216132113.GA4073@localhost> (raw)
In-Reply-To: <5670DA9A.4010102@candelatech.com>

On Tue, Dec 15, 2015 at 07:29:30PM -0800, Ben Greear wrote:
> This patch below was added to the kernel around 2/24/2015
> 
> I am curious mostly about the first change:  I thought the transmitter-addr
> relates to the radio device, not the vdev (sta, ap, etc).
> 
> But, wouldn't using data from the header break that assumption?

I'm not sure this assumption is correct.  I have a hard time
seeing the value in basing the transmitter addr attribute on some
hardware address that may not even be used.

> Is there any actual advantage to having more than one address per
> hwsim radio?  It seems it complicates things for no particular
> reason as far as I can tell?

As a practical matter: the radios already have two "hardware"
addresses, and as reported in the commit log, only one of them
worked with the netlink interface, and it wasn't even the default
address.

I suppose there's no real benefit to multi-vif on hwsim vs multiple
phys, other than testing multi-vif support in the stack, but why not?
I think this patch actually simplifies things.

Does this patch cause problems for your userspace implementation?

-- 
Bob Copeland %% http://bobcopeland.com/

  parent reply	other threads:[~2015-12-16 13:21 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-16  3:29 question on "mac80211_hwsim: support any address in userspace" Ben Greear
2015-12-16  9:17 ` Johannes Berg
2015-12-16 13:13   ` Ben Greear
2015-12-16 13:25     ` Johannes Berg
2015-12-16 13:35       ` Ben Greear
2015-12-16 13:42         ` Johannes Berg
2015-12-16 14:11           ` Ben Greear
2015-12-16 14:14             ` Johannes Berg
2015-12-16 14:15             ` Johannes Berg
2015-12-16 14:59               ` Bob Copeland
2015-12-16 15:52                 ` Ben Greear
2015-12-16 17:30           ` Adam R. Welle
2015-12-16 17:46             ` Bob Copeland
2015-12-16 18:57               ` Adam R. Welle
2015-12-16 22:14             ` Ben Greear
2015-12-16 22:56               ` Adam R. Welle
2015-12-16 23:20                 ` Ben Greear
2015-12-16 23:56                   ` Adam R. Welle
2015-12-17 13:26               ` Bob Copeland
2015-12-16 13:21 ` me@bobcopeland.com >> Bob Copeland [this message]
2015-12-16 13:27   ` Ben Greear
2015-12-16 13:57     ` me@bobcopeland.com >> Bob Copeland
2015-12-16 14:16       ` Ben Greear
2015-12-16 14:33         ` me@bobcopeland.com >> Bob Copeland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151216132113.GA4073@localhost \
    --to=me@bobcopeland.com \
    --cc=greearb@candelatech.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.