Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Thu, 2015-12-17 at 17:41 -0400, Julian Margetson wrote:
> On 12/17/2015 3:53 PM, Måns Rullgård wrote:
> > Julian Margetson <runaway@candw.ms> writes:
> > 
> > > On 12/17/2015 2:51 PM, Måns Rullgård wrote:
> > > > Julian Margetson <runaway@candw.ms> writes:
> > > > 
> > > > > On 12/17/2015 1:59 PM, Måns Rullgård wrote:
> > > > > > Julian Margetson <runaway@candw.ms> writes:
> > > > > > 
> > > > > > > I have been running my machine mostly configured for
> > > > > > > pciex1  thus with
> > > > > > > the sata_dwc disabled.
> > > > > > > The changes to sata_dwc-460ex do cause an oops.
> > > > > > > I will try to give more detailed info over this weekend .
> > > > > > The driver as is upstream would do that since it
> > > > > > unconditionally
> > > > > > dereferences a null pointer in the probe function.  My
> > > > > > patch fixes that
> > > > > > as a side-effect.
> > > > > > 
> > > > > patching file drivers/ata/Kconfig
> > > > > 
> > > > > Hunk #1 FAILED at 296.
> > > > [...]
> > > > 
> > > > > root@julian-VirtualBox:/usr/src/linux-3.18.25#
> > > > The patch is against 4.4-rc5.
> > > > 
> > >  CC      drivers/ata/sata_dwc_460ex.o
> > > 
> > > drivers/ata/sata_dwc_460ex.c:198:15: error: variable
> > > ‘sata_dwc_dma_dws’ has initializer but incomplete type
> > > 
> > >  static struct dw_dma_slave sata_dwc_dma_dws = {
> > >                ^
> > It builds, albeit with an unrelated warning, using the attached
> > config.
> > Maybe there's a missing config dependency somewhere.
> > 
> I am attempting to cross compile under Ubuntu 14.04 X86 in Virtualbox
> with your .config.
> 4.4.0-rc5 builds ok with no patches applied .
> Once your patch is applied it fails to build .
> CC      drivers/ata/sata_dwc_460ex.o
> drivers/ata/sata_dwc_460ex.c:198:15: error: variable
> ‘sata_dwc_dma_dws’ has initializer but incomplete type
>  static struct dw_dma_slave sata_dwc_dma_dws = {
>                ^
> drivers/ata/sata_dwc_460ex.c:199:2: error: unknown field ‘src_id’
> specified in initializer
>   .src_id = 0,

This clearly means that header file that defines the struct
dw_dma_slave is not included.

After the patch it seems you have to explicitly enable DW_DMAC, so,
either via make nconfig, or by adding
CONFIG_DW_DMAC=y


>   ^
> drivers/ata/sata_dwc_460ex.c:199:2: warning: excess elements in
> struct initializer [enabled by default]
> drivers/ata/sata_dwc_460ex.c:199:2: warning: (near initialization for
> ‘sata_dwc_dma_dws’) [enabled by default]
> drivers/ata/sata_dwc_460ex.c:200:2: error: unknown field ‘dst_id’
> specified in initializer
>   .dst_id = 0,
>   ^
> drivers/ata/sata_dwc_460ex.c:200:2: warning: excess elements in
> struct initializer [enabled by default]
> drivers/ata/sata_dwc_460ex.c:200:2: warning: (near initialization for
> ‘sata_dwc_dma_dws’) [enabled by default]
> drivers/ata/sata_dwc_460ex.c:201:2: error: unknown field ‘src_master’
> specified in initializer
>   .src_master = 0,
>   ^
> drivers/ata/sata_dwc_460ex.c:201:2: warning: excess elements in
> struct initializer [enabled by default]
> drivers/ata/sata_dwc_460ex.c:201:2: warning: (near initialization for
> ‘sata_dwc_dma_dws’) [enabled by default]
> drivers/ata/sata_dwc_460ex.c:202:2: error: unknown field ‘dst_master’
> specified in initializer
>   .dst_master = 1,
>   ^
> drivers/ata/sata_dwc_460ex.c:202:2: warning: excess elements in
> struct initializer [enabled by default]
> drivers/ata/sata_dwc_460ex.c:202:2: warning: (near initialization for
> ‘sata_dwc_dma_dws’) [enabled by default]
> drivers/ata/sata_dwc_460ex.c: In function ‘dma_dwc_xfer_setup’:
> drivers/ata/sata_dwc_460ex.c:389:20: warning: cast from pointer to
> integer of different size [-Wpointer-to-int-cast]
>   dma_addr_t addr = (dma_addr_t)&hsdev->sata_dwc_regs->dmadr;
>                     ^
> drivers/ata/sata_dwc_460ex.c: In function ‘sata_dwc_dma_filter’:
> drivers/ata/sata_dwc_460ex.c:872:9: error: dereferencing pointer to
> incomplete type
>   if (dws->dma_dev != chan->device->dev)
>          ^
> drivers/ata/sata_dwc_460ex.c: In function ‘sata_dwc_port_start’:
> drivers/ata/sata_dwc_460ex.c:958:13: error: dereferencing pointer to
> incomplete type
>   hsdevp->dws->dma_dev = hsdev->dev;
>              ^
> drivers/ata/sata_dwc_460ex.c: In function ‘sata_dwc_probe’:
> drivers/ata/sata_dwc_460ex.c:1330:12: error: dereferencing pointer to
> incomplete type
>   hsdev->dma->irq = irq_of_parse_and_map(np, 1);
>             ^
> drivers/ata/sata_dwc_460ex.c:1331:16: error: dereferencing pointer to
> incomplete type
>   if (hsdev->dma->irq == NO_IRQ) {
>                 ^
> drivers/ata/sata_dwc_460ex.c:1338:12: error: dereferencing pointer to
> incomplete type
>   hsdev->dma->regs = of_iomap(np, 1);
>             ^
> drivers/ata/sata_dwc_460ex.c:1339:17: error: dereferencing pointer to
> incomplete type
>   if (!hsdev->dma->regs) {
>                  ^
> drivers/ata/sata_dwc_460ex.c:1349:12: error: dereferencing pointer to
> incomplete type
>   hsdev->dma->dev = &ofdev->dev;
>             ^
> drivers/ata/sata_dwc_460ex.c:1352:2: error: implicit declaration of
> function ‘dw_dma_probe’ [-Werror=implicit-function-declaration]
>   err = dw_dma_probe(hsdev->dma, NULL);
>   ^
> drivers/ata/sata_dwc_460ex.c:1381:2: error: implicit declaration of
> function ‘dw_dma_remove’ [-Werror=implicit-function-declaration]
>   dw_dma_remove(hsdev->dma);
>   ^
> drivers/ata/sata_dwc_460ex.c:1383:20: error: dereferencing pointer to
> incomplete type
>   iounmap(hsdev->dma->regs);
>                     ^
> drivers/ata/sata_dwc_460ex.c: In function ‘sata_dwc_remove’:
> drivers/ata/sata_dwc_460ex.c:1400:20: error: dereferencing pointer to
> incomplete type
>   iounmap(hsdev->dma->regs);
>                     ^
> drivers/ata/sata_dwc_460ex.c: At top level:
> drivers/ata/sata_dwc_460ex.c:901:12: warning:
> ‘sata_dwc_dma_get_channel’ defined but not used [-Wunused-function]
>  static int sata_dwc_dma_get_channel(struct sata_dwc_device_port
> *hsdevp)
>             ^
> cc1: some warnings being treated as errors
> make[2]: *** [drivers/ata/sata_dwc_460ex.o] Error 1
> make[1]: *** [drivers/ata] Error 2
> make: *** [drivers] Error 2
> root@julian-VirtualBox:/usr/src/linux-4.4-rc5# 
> 
> 
> 
> 

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy