* [PATCH] UBIFS: add a comment in key.h for unused parameter
@ 2015-12-20 3:25 Dongsheng Yang
2015-12-21 11:46 ` Artem Bityutskiy
0 siblings, 1 reply; 3+ messages in thread
From: Dongsheng Yang @ 2015-12-20 3:25 UTC (permalink / raw)
To: linux-mtd; +Cc: dedekind1, richard, david, Dongsheng Yang
Add a comment in key.h to explain why we keep an unused
parameter in key helpers.
Signed-off-by: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
---
fs/ubifs/key.h | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/fs/ubifs/key.h b/fs/ubifs/key.h
index 92a8491..dce72c4 100644
--- a/fs/ubifs/key.h
+++ b/fs/ubifs/key.h
@@ -34,6 +34,12 @@
* node. We use "r5" hash borrowed from reiserfs.
*/
+/*
+ * Lot's of the key helpers require a struct ubifs_info *c as the first parameter.
+ * But we are not using it at all currently. That's designed for scalability for
+ * different c->key_format. But right now, there is only one key type, UBIFS_SIMPLE_KEY_FMT.
+ */
+
#ifndef __UBIFS_KEY_H__
#define __UBIFS_KEY_H__
--
1.8.4.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] UBIFS: add a comment in key.h for unused parameter
2015-12-20 3:25 [PATCH] UBIFS: add a comment in key.h for unused parameter Dongsheng Yang
@ 2015-12-21 11:46 ` Artem Bityutskiy
2015-12-22 1:01 ` Dongsheng Yang
0 siblings, 1 reply; 3+ messages in thread
From: Artem Bityutskiy @ 2015-12-21 11:46 UTC (permalink / raw)
To: Dongsheng Yang, linux-mtd; +Cc: richard, david
On Sun, 2015-12-20 at 11:25 +0800, Dongsheng Yang wrote:
> Add a comment in key.h to explain why we keep an unused
> parameter in key helpers.
>
> Signed-off-by: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
> ---
> fs/ubifs/key.h | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/fs/ubifs/key.h b/fs/ubifs/key.h
> index 92a8491..dce72c4 100644
> --- a/fs/ubifs/key.h
> +++ b/fs/ubifs/key.h
> @@ -34,6 +34,12 @@
> * node. We use "r5" hash borrowed from reiserfs.
> */
>
> +/*
> + * Lot's of the key helpers require a struct ubifs_info *c as the
> first parameter.
> + * But we are not using it at all currently. That's designed for
> scalability for
> + * different c->key_format. But right now, there is only one key
> type, UBIFS_SIMPLE_KEY_FMT.
> + */
I think word "scalability" is not a perfect fit here. Just say for
future extensions, or something like this. Scalability is a bit
confusing.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] UBIFS: add a comment in key.h for unused parameter
2015-12-21 11:46 ` Artem Bityutskiy
@ 2015-12-22 1:01 ` Dongsheng Yang
0 siblings, 0 replies; 3+ messages in thread
From: Dongsheng Yang @ 2015-12-22 1:01 UTC (permalink / raw)
To: dedekind1, linux-mtd; +Cc: richard, david
On 12/21/2015 07:46 PM, Artem Bityutskiy wrote:
> On Sun, 2015-12-20 at 11:25 +0800, Dongsheng Yang wrote:
>> Add a comment in key.h to explain why we keep an unused
>> parameter in key helpers.
>>
>> Signed-off-by: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
>> ---
>> fs/ubifs/key.h | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/fs/ubifs/key.h b/fs/ubifs/key.h
>> index 92a8491..dce72c4 100644
>> --- a/fs/ubifs/key.h
>> +++ b/fs/ubifs/key.h
>> @@ -34,6 +34,12 @@
>> * node. We use "r5" hash borrowed from reiserfs.
>> */
>>
>> +/*
>> + * Lot's of the key helpers require a struct ubifs_info *c as the
>> first parameter.
>> + * But we are not using it at all currently. That's designed for
>> scalability for
>> + * different c->key_format. But right now, there is only one key
>> type, UBIFS_SIMPLE_KEY_FMT.
>> + */
>
> I think word "scalability" is not a perfect fit here. Just say for
> future extensions, or something like this. Scalability is a bit
> confusing.
It makes sense. Okey, I would update it with
"That's designed for future extensions of different c->key_format"
Thanx
Yang
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-12-22 1:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-20 3:25 [PATCH] UBIFS: add a comment in key.h for unused parameter Dongsheng Yang
2015-12-21 11:46 ` Artem Bityutskiy
2015-12-22 1:01 ` Dongsheng Yang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.