All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrange" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
	qemu-block@nongnu.org, "Markus Armbruster" <armbru@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Andreas Färber" <afaerber@suse.de>
Subject: [Qemu-devel] [PATCH v2 08/10] qemu-nbd: don't overlap long option values with short options
Date: Wed, 23 Dec 2015 17:11:20 +0000	[thread overview]
Message-ID: <1450890682-13600-9-git-send-email-berrange@redhat.com> (raw)
In-Reply-To: <1450890682-13600-1-git-send-email-berrange@redhat.com>

When defining values for long options, the normal practice is
to start numbering from 256, to avoid overlap with the range
of valid values for short options.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---
 qemu-nbd.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/qemu-nbd.c b/qemu-nbd.c
index 02fdcf1..9898e22 100644
--- a/qemu-nbd.c
+++ b/qemu-nbd.c
@@ -44,12 +44,12 @@
 #include <pthread.h>
 
 #define SOCKET_PATH                "/var/lock/qemu-nbd-%s"
-#define QEMU_NBD_OPT_CACHE         1
-#define QEMU_NBD_OPT_AIO           2
-#define QEMU_NBD_OPT_DISCARD       3
-#define QEMU_NBD_OPT_DETECT_ZEROES 4
-#define QEMU_NBD_OPT_OBJECT        5
-#define QEMU_NBD_OPT_IMAGE_OPTS    6
+#define QEMU_NBD_OPT_CACHE         256
+#define QEMU_NBD_OPT_AIO           257
+#define QEMU_NBD_OPT_DISCARD       258
+#define QEMU_NBD_OPT_DETECT_ZEROES 259
+#define QEMU_NBD_OPT_OBJECT        260
+#define QEMU_NBD_OPT_IMAGE_OPTS    261
 
 static NBDExport *exp;
 static int verbose;
-- 
2.5.0

  parent reply	other threads:[~2015-12-23 17:11 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-23 17:11 [Qemu-devel] [PATCH v2 00/10] Make qemu-img/qemu-nbd/qemu-io CLI more flexible Daniel P. Berrange
2015-12-23 17:11 ` [Qemu-devel] [PATCH v2 01/10] qom: add helpers for UserCreatable object types Daniel P. Berrange
2015-12-23 17:11 ` [Qemu-devel] [PATCH v2 02/10] qemu-img: add support for --object command line arg Daniel P. Berrange
2015-12-23 17:11 ` [Qemu-devel] [PATCH v2 03/10] qemu-nbd: " Daniel P. Berrange
2015-12-23 17:11 ` [Qemu-devel] [PATCH v2 04/10] qemu-io: " Daniel P. Berrange
2015-12-23 17:11 ` [Qemu-devel] [PATCH v2 05/10] qemu-io: allow specifying image as a set of options args Daniel P. Berrange
2015-12-23 17:11 ` [Qemu-devel] [PATCH v2 06/10] qemu-nbd: " Daniel P. Berrange
2015-12-23 17:11 ` [Qemu-devel] [PATCH v2 07/10] qemu-img: " Daniel P. Berrange
2015-12-23 17:11 ` Daniel P. Berrange [this message]
2015-12-23 17:38   ` [Qemu-devel] [PATCH v2 08/10] qemu-nbd: don't overlap long option values with short options Eric Blake
2015-12-23 17:11 ` [Qemu-devel] [PATCH v2 09/10] qemu-nbd: use no_argument/required_argument constants Daniel P. Berrange
2015-12-23 17:40   ` Eric Blake
2015-12-23 17:11 ` [Qemu-devel] [PATCH v2 10/10] qemu-io: " Daniel P. Berrange
2015-12-23 17:41   ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1450890682-13600-9-git-send-email-berrange@redhat.com \
    --to=berrange@redhat.com \
    --cc=afaerber@suse.de \
    --cc=armbru@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.