From: Eric Blake <eblake@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
qemu-block@nongnu.org, "Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH v2 10/10] qemu-io: use no_argument/required_argument constants
Date: Wed, 23 Dec 2015 10:41:15 -0700 [thread overview]
Message-ID: <567ADCBB.8010604@redhat.com> (raw)
In-Reply-To: <1450890682-13600-11-git-send-email-berrange@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 529 bytes --]
On 12/23/2015 10:11 AM, Daniel P. Berrange wrote:
> When declaring the 'struct option' array, use the standard
> constants no_argument/required_argument, instead of magic
> values 0 and 1.
>
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
> qemu-io.c | 30 +++++++++++++++---------------
> 1 file changed, 15 insertions(+), 15 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
prev parent reply other threads:[~2015-12-23 17:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-23 17:11 [Qemu-devel] [PATCH v2 00/10] Make qemu-img/qemu-nbd/qemu-io CLI more flexible Daniel P. Berrange
2015-12-23 17:11 ` [Qemu-devel] [PATCH v2 01/10] qom: add helpers for UserCreatable object types Daniel P. Berrange
2015-12-23 17:11 ` [Qemu-devel] [PATCH v2 02/10] qemu-img: add support for --object command line arg Daniel P. Berrange
2015-12-23 17:11 ` [Qemu-devel] [PATCH v2 03/10] qemu-nbd: " Daniel P. Berrange
2015-12-23 17:11 ` [Qemu-devel] [PATCH v2 04/10] qemu-io: " Daniel P. Berrange
2015-12-23 17:11 ` [Qemu-devel] [PATCH v2 05/10] qemu-io: allow specifying image as a set of options args Daniel P. Berrange
2015-12-23 17:11 ` [Qemu-devel] [PATCH v2 06/10] qemu-nbd: " Daniel P. Berrange
2015-12-23 17:11 ` [Qemu-devel] [PATCH v2 07/10] qemu-img: " Daniel P. Berrange
2015-12-23 17:11 ` [Qemu-devel] [PATCH v2 08/10] qemu-nbd: don't overlap long option values with short options Daniel P. Berrange
2015-12-23 17:38 ` Eric Blake
2015-12-23 17:11 ` [Qemu-devel] [PATCH v2 09/10] qemu-nbd: use no_argument/required_argument constants Daniel P. Berrange
2015-12-23 17:40 ` Eric Blake
2015-12-23 17:11 ` [Qemu-devel] [PATCH v2 10/10] qemu-io: " Daniel P. Berrange
2015-12-23 17:41 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=567ADCBB.8010604@redhat.com \
--to=eblake@redhat.com \
--cc=afaerber@suse.de \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.