From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH v2 2/3] device property: the secondary fwnode needs to depend on the primary
Date: Tue, 29 Dec 2015 12:57:03 +0200 [thread overview]
Message-ID: <1451386623.30729.353.camel@linux.intel.com> (raw)
In-Reply-To: <20151229084020.GA19870@kuha.fi.intel.com>
On Tue, 2015-12-29 at 10:40 +0200, Heikki Krogerus wrote:
> Hi Andy,
>
> Found a bug from my code..
>
> > diff --git a/drivers/base/property.c b/drivers/base/property.c
> > index 0b22c8a..6c04d18 100644
> > --- a/drivers/base/property.c
> > +++ b/drivers/base/property.c
> > @@ -218,7 +218,7 @@ bool fwnode_property_present(struct
> > fwnode_handle *fwnode, const char *propname)
> > bool ret;
> >
> > ret = __fwnode_property_present(fwnode, propname);
> > - if (ret == false && fwnode->secondary)
> > + if (ret == false && fwnode && fwnode->secondary)
> > ret = __fwnode_property_present(fwnode->secondary,
> > propname);
> > return ret;
> > }
> > @@ -423,7 +423,7 @@
> > EXPORT_SYMBOL_GPL(device_property_match_string);
> > int _ret_;
> > \
> > _ret_ = FWNODE_PROP_READ(_fwnode_, _propname_, _type_,
> > _proptype_, \
> > _val_, _nval_);
> > \
> > - if (_ret_ == -EINVAL && _fwnode_->secondary)
> > \
> > + if (_ret_ == -EINVAL && fwnode && _fwnode_->secondary)
> > \
>
> This should be .._fwnode_ && _fwnode_->secondary)
Yeah, we compiled it correctly due to fwnode presents in all
occurrences of this macro.
I will fix and resend a new version.
>
> > _ret_ = FWNODE_PROP_READ(_fwnode_->secondary,
> > _propname_, _type_, \
> > _proptype_, _val_, _nval_);
> > \
> > _ret_;
> > \
>
>
> Cheers,
>
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH v2 2/3] device property: the secondary fwnode needs to depend on the primary
Date: Tue, 29 Dec 2015 12:57:03 +0200 [thread overview]
Message-ID: <1451386623.30729.353.camel@linux.intel.com> (raw)
In-Reply-To: <20151229084020.GA19870@kuha.fi.intel.com>
On Tue, 2015-12-29 at 10:40 +0200, Heikki Krogerus wrote:
> Hi Andy,
>
> Found a bug from my code..
>
> > diff --git a/drivers/base/property.c b/drivers/base/property.c
> > index 0b22c8a..6c04d18 100644
> > --- a/drivers/base/property.c
> > +++ b/drivers/base/property.c
> > @@ -218,7 +218,7 @@ bool fwnode_property_present(struct
> > fwnode_handle *fwnode, const char *propname)
> > bool ret;
> >
> > ret = __fwnode_property_present(fwnode, propname);
> > - if (ret == false && fwnode->secondary)
> > + if (ret == false && fwnode && fwnode->secondary)
> > ret = __fwnode_property_present(fwnode->secondary,
> > propname);
> > return ret;
> > }
> > @@ -423,7 +423,7 @@
> > EXPORT_SYMBOL_GPL(device_property_match_string);
> > int _ret_;
> > \
> > _ret_ = FWNODE_PROP_READ(_fwnode_, _propname_, _type_,
> > _proptype_, \
> > _val_, _nval_);
> > \
> > - if (_ret_ == -EINVAL && _fwnode_->secondary)
> > \
> > + if (_ret_ == -EINVAL && fwnode && _fwnode_->secondary)
> > \
>
> This should be .._fwnode_ && _fwnode_->secondary)
Yeah, we compiled it correctly due to fwnode presents in all
occurrences of this macro.
I will fix and resend a new version.
>
> > _ret_ = FWNODE_PROP_READ(_fwnode_->secondary,
> > _propname_, _type_, \
> > _proptype_, _val_, _nval_);
> > \
> > _ret_;
> > \
>
>
> Cheers,
>
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2015-12-29 10:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-23 13:34 [PATCH v2 0/3] device property: post merge fixes Andy Shevchenko
2015-12-23 13:34 ` [PATCH v2 1/3] device property: add spaces to PROPERTY_ENTRY_STRING macro Andy Shevchenko
2015-12-28 1:12 ` Rafael J. Wysocki
2015-12-28 11:24 ` Andy Shevchenko
2015-12-28 11:24 ` Andy Shevchenko
2015-12-30 1:49 ` Rafael J. Wysocki
2015-12-30 1:24 ` Andrew Morton
2015-12-30 2:06 ` Rafael J. Wysocki
2015-12-30 1:43 ` Andy Shevchenko
2015-12-30 1:44 ` Andrew Morton
2016-01-01 0:53 ` Rafael J. Wysocki
2015-12-30 1:29 ` Andy Shevchenko
2015-12-23 13:34 ` [PATCH v2 2/3] device property: the secondary fwnode needs to depend on the primary Andy Shevchenko
2015-12-29 8:40 ` Heikki Krogerus
2015-12-29 10:57 ` Andy Shevchenko [this message]
2015-12-29 10:57 ` Andy Shevchenko
2015-12-23 13:34 ` [PATCH v2 3/3] device property: avoid allocations of 0 length Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1451386623.30729.353.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.