From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH 1/1] ixgbe: synchronize link_up and link_speed of a slave interface
Date: Wed, 30 Dec 2015 21:37:48 -0800 [thread overview]
Message-ID: <1451540268.3348.108.camel@intel.com> (raw)
In-Reply-To: <1451538295-15823-2-git-send-email-zyjzyj2000@gmail.com>
On Thu, 2015-12-31 at 13:04 +0800, zyjzyj2000 at gmail.com wrote:
> From: Zhu Yanjun <yanjun.zhu@windriver.com>
>
> According to the suggestions from Rustad, Mark D, to all the slave?
> interfaces, the link_speed and link_up should be synchronized since
> the time span between link_up and link_speed will make some virtual
> NICs not work well, such as a bonding driver in 802.3ad mode.
>
> Signed-off-by: Zhu Yanjun <yanjun.zhu@windriver.com>
> ---
Since this is version 5 of your original patch, you should be putting
the change log of this patch here, so that we can follow how you got to
this point. ?This helpful for the reviewers (and me, the maintainer).
?For example:
v2: dropped the "else" case of "if" statement, based on feedback from
? ? Jeff Kirsher
v3: changed the if statement to simply return when the link speed is
? ? unknown on X540 parts based on feedback from Emil Tantilov
v4: updated code comment and if statement to test for IFF_SLAVE flag
V5: simplified code comment and if statement to only test for IFF_SLAVE
? ? flag and unknown link speed.
Of course, you can expand on what I have above, I just did a quick
summary of the changes as an example of a change log.?
> ?drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 5 +++++
> ?1 file changed, 5 insertions(+)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20151230/dd49f916/attachment-0001.asc>
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: zyjzyj2000@gmail.com, jesse.brandeburg@intel.com,
shannon.nelson@intel.com, carolyn.wyborny@intel.com,
donald.c.skidmore@intel.com, bruce.w.allan@intel.com,
john.ronciak@intel.com, mitch.a.williams@intel.com,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
e1000-devel@lists.sourceforge.net, mark.d.rustad@intel.com
Cc: venkat.viswanathan@windriver.com, Boris.Shteinbock@windriver.com,
Vincent.Bourg@windriver.com
Subject: Re: [PATCH 1/1] ixgbe: synchronize link_up and link_speed of a slave interface
Date: Wed, 30 Dec 2015 21:37:48 -0800 [thread overview]
Message-ID: <1451540268.3348.108.camel@intel.com> (raw)
In-Reply-To: <1451538295-15823-2-git-send-email-zyjzyj2000@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1328 bytes --]
On Thu, 2015-12-31 at 13:04 +0800, zyjzyj2000@gmail.com wrote:
> From: Zhu Yanjun <yanjun.zhu@windriver.com>
>
> According to the suggestions from Rustad, Mark D, to all the slave
> interfaces, the link_speed and link_up should be synchronized since
> the time span between link_up and link_speed will make some virtual
> NICs not work well, such as a bonding driver in 802.3ad mode.
>
> Signed-off-by: Zhu Yanjun <yanjun.zhu@windriver.com>
> ---
Since this is version 5 of your original patch, you should be putting
the change log of this patch here, so that we can follow how you got to
this point. This helpful for the reviewers (and me, the maintainer).
For example:
v2: dropped the "else" case of "if" statement, based on feedback from
Jeff Kirsher
v3: changed the if statement to simply return when the link speed is
unknown on X540 parts based on feedback from Emil Tantilov
v4: updated code comment and if statement to test for IFF_SLAVE flag
V5: simplified code comment and if statement to only test for IFF_SLAVE
flag and unknown link speed.
Of course, you can expand on what I have above, I just did a quick
summary of the changes as an example of a change log.
> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 5 +++++
> 1 file changed, 5 insertions(+)
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-12-31 5:37 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-23 6:46 [Intel-wired-lan] [PATCH 1/1] ixgbe: force to synchronize reporting "link on" and getting speed and duplex zyjzyj2000
2015-12-23 6:46 ` zyjzyj2000
2015-12-23 10:54 ` [Intel-wired-lan] " Jeff Kirsher
2015-12-23 10:54 ` Jeff Kirsher
2015-12-24 3:12 ` [Intel-wired-lan] [V2 PATCH 1/1] ixgbe: force to synchronize reporting "link on" and zyjzyj2000
2015-12-24 3:12 ` zyjzyj2000
2015-12-24 3:12 ` [Intel-wired-lan] [PATCH 1/1] ixgbe: force to synchronize reporting "link on" and getting speed zyjzyj2000
2015-12-24 3:12 ` zyjzyj2000
2015-12-24 5:10 ` [Intel-wired-lan] [V2 PATCH 1/1] ixgbe: force to synchronize reporting "link on" and zhuyj
2015-12-24 5:10 ` zhuyj
2015-12-24 6:17 ` [Intel-wired-lan] " Tantilov, Emil S
2015-12-24 6:17 ` Tantilov, Emil S
2015-12-29 2:32 ` [Intel-wired-lan] [PATCH V3] ixgbe: force to synchronize link_up and speed as a slave zyjzyj2000
2015-12-29 2:32 ` zyjzyj2000
2015-12-29 2:32 ` [Intel-wired-lan] [PATCH 1/2] ixgbe: force to synchronize reporting "link on" and getting speed zyjzyj2000
2015-12-29 2:32 ` zyjzyj2000
2015-12-29 2:32 ` [Intel-wired-lan] [PATCH 2/2] ixgbe: restrict synchronization of link_up and speed zyjzyj2000
2015-12-29 2:32 ` zyjzyj2000
2015-12-29 16:18 ` [Intel-wired-lan] " Tantilov, Emil S
2015-12-29 16:18 ` Tantilov, Emil S
2015-12-29 19:17 ` Rustad, Mark D
2015-12-29 19:17 ` Rustad, Mark D
2015-12-30 3:06 ` zhuyj
2015-12-30 3:06 ` zhuyj
2015-12-30 9:16 ` [Intel-wired-lan] [PATCH V4] ixgbe: synchronize the link_speed and link_up of a slave interface zyjzyj2000
2015-12-30 9:16 ` zyjzyj2000
2015-12-30 9:16 ` [Intel-wired-lan] [PATCH 1/3] ixgbe: force to synchronize reporting "link on" and getting speed zyjzyj2000
2015-12-30 9:16 ` zyjzyj2000
2015-12-30 9:16 ` [Intel-wired-lan] [PATCH 2/3] ixgbe: restrict synchronization of link_up and speed zyjzyj2000
2015-12-30 9:16 ` zyjzyj2000
2015-12-30 9:16 ` [Intel-wired-lan] [PATCH 3/3] ixgbe: synchronize the link_speed and link_up of a slave interface zyjzyj2000
2015-12-30 9:16 ` zyjzyj2000
2015-12-30 19:02 ` [Intel-wired-lan] " Rustad, Mark D
2015-12-30 19:02 ` Rustad, Mark D
2015-12-31 5:04 ` [Intel-wired-lan] [PATCH V5] ixgbe: synchronize link_up and link_speed of a slave zyjzyj2000
2015-12-31 5:04 ` zyjzyj2000
2015-12-31 5:04 ` [Intel-wired-lan] [PATCH 1/1] ixgbe: synchronize link_up and link_speed of a slave interface zyjzyj2000
2015-12-31 5:04 ` zyjzyj2000
2015-12-31 5:37 ` Jeff Kirsher [this message]
2015-12-31 5:37 ` Jeff Kirsher
2015-12-31 7:11 ` [Intel-wired-lan] [PATCH V6] ixgbe: synchronize link_up and link_speed of a slave zyjzyj2000
2015-12-31 7:11 ` zyjzyj2000
2015-12-31 7:11 ` [Intel-wired-lan] [PATCH V6 1/1] ixgbe: synchronize link_up and link_speed of a slave interface zyjzyj2000
2015-12-31 7:11 ` zyjzyj2000
2015-12-31 5:17 ` [Intel-wired-lan] [PATCH V5] ixgbe: synchronize link_up and link_speed of a slave Jeff Kirsher
2015-12-31 5:17 ` Jeff Kirsher
2015-12-31 5:24 ` [Intel-wired-lan] " zhuyj
2015-12-31 5:24 ` zhuyj
2015-12-30 2:49 ` [Intel-wired-lan] [PATCH 2/2] ixgbe: restrict synchronization of link_up and speed zhuyj
2015-12-30 2:49 ` zhuyj
2015-12-30 6:55 ` Tantilov, Emil S
2015-12-30 6:55 ` Tantilov, Emil S
2015-12-30 8:20 ` zhuyj
2015-12-30 8:20 ` zhuyj
2015-12-30 16:37 ` Tantilov, Emil S
2015-12-30 16:37 ` Tantilov, Emil S
2016-01-06 5:41 ` zhuyj
2016-01-06 5:41 ` zhuyj
2016-01-06 15:30 ` Tantilov, Emil S
2016-01-06 15:30 ` Tantilov, Emil S
2016-01-07 2:08 ` zhuyj
2016-01-07 2:08 ` zhuyj
2016-01-07 2:38 ` zhuyj
2016-01-07 2:38 ` zhuyj
2015-12-23 12:17 ` [Intel-wired-lan] [PATCH 1/1] ixgbe: force to synchronize reporting "link on" and getting speed and duplex Sergei Shtylyov
2015-12-23 12:17 ` Sergei Shtylyov
2015-12-23 15:59 ` [Intel-wired-lan] " Tantilov, Emil S
2015-12-23 15:59 ` Tantilov, Emil S
2015-12-23 18:09 ` [Intel-wired-lan] [E1000-devel] " Stephen Hemminger
2015-12-23 18:09 ` [E1000-devel] [Intel-wired-lan] " Stephen Hemminger
2015-12-24 2:27 ` zhuyj
2015-12-24 2:27 ` zhuyj
2015-12-24 5:58 ` Tantilov, Emil S
2015-12-24 5:58 ` Tantilov, Emil S
2015-12-24 6:24 ` zhuyj
2015-12-24 6:24 ` zhuyj
2015-12-24 14:52 ` Tantilov, Emil S
2015-12-24 14:52 ` Tantilov, Emil S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1451540268.3348.108.camel@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.