From: keith.busch@intel.com (Keith Busch)
Subject: [PATCHv2 1/5] NVMe: Fix admin queue ring wrap
Date: Thu, 31 Dec 2015 09:41:52 -0700 [thread overview]
Message-ID: <1451580116-12252-2-git-send-email-keith.busch@intel.com> (raw)
In-Reply-To: <1451580116-12252-1-git-send-email-keith.busch@intel.com>
The tag set queue depth needs to be one less than the h/w queue depth
so we don't wrap the circular buffer. This conforms to the specification
defined "Full Queue" condition.
Signed-off-by: Keith Busch <keith.busch at intel.com>
---
drivers/nvme/host/pci.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index b82bbea..67cb406 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -1271,7 +1271,12 @@ static int nvme_alloc_admin_tags(struct nvme_dev *dev)
if (!dev->ctrl.admin_q) {
dev->admin_tagset.ops = &nvme_mq_admin_ops;
dev->admin_tagset.nr_hw_queues = 1;
- dev->admin_tagset.queue_depth = NVME_AQ_BLKMQ_DEPTH;
+
+ /*
+ * Subtract one to leave an empty queue entry for 'Full Queue'
+ * condition. See NVM-Express 1.2 specification, section 4.1.2.
+ */
+ dev->admin_tagset.queue_depth = NVME_AQ_BLKMQ_DEPTH - 1;
dev->admin_tagset.timeout = ADMIN_TIMEOUT;
dev->admin_tagset.numa_node = dev_to_node(dev->dev);
dev->admin_tagset.cmd_size = nvme_cmd_size(dev);
--
2.6.2.307.g37023ba
next prev parent reply other threads:[~2015-12-31 16:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-31 16:41 [PATCHv2 0/5] NVMe fixes and updates, version 2 Keith Busch
2015-12-31 16:41 ` Keith Busch [this message]
2016-01-03 16:44 ` [PATCHv2 1/5] NVMe: Fix admin queue ring wrap Sagi Grimberg
2015-12-31 16:41 ` [PATCHv2 2/5] NVMe: Use a retryable error code on reset Keith Busch
2016-01-03 16:54 ` Sagi Grimberg
2015-12-31 16:41 ` [PATCHv2 3/5] NVMe: Remove queue freezing on resets Keith Busch
2016-01-03 16:41 ` Sagi Grimberg
2015-12-31 16:41 ` [PATCHv2 4/5] NVMe: IO queue deletion re-write Keith Busch
2015-12-31 16:41 ` [PATCHv2 5/5] NVMe: Shutdown controller only for power-off Keith Busch
2016-01-03 16:52 ` Sagi Grimberg
2016-01-04 15:54 ` Keith Busch
2016-01-04 16:08 ` Sagi Grimberg
2015-12-31 18:38 ` [PATCHv2 0/5] NVMe fixes and updates, version 2 Sagi Grimberg
2015-12-31 18:40 ` Keith Busch
2015-12-31 18:42 ` Sagi Grimberg
2016-01-02 16:59 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1451580116-12252-2-git-send-email-keith.busch@intel.com \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.