All of lore.kernel.org
 help / color / mirror / Atom feed
From: keith.busch@intel.com (Keith Busch)
Subject: [PATCHv2 2/5] NVMe: Use a retryable error code on reset
Date: Thu, 31 Dec 2015 09:41:53 -0700	[thread overview]
Message-ID: <1451580116-12252-3-git-send-email-keith.busch@intel.com> (raw)
In-Reply-To: <1451580116-12252-1-git-send-email-keith.busch@intel.com>

The negative status has the "do not retry" bit set, which makes it not
retryable. Use a fake status that can potentially be retried on reset.

An aborted command's status is still overridden by the timeout handler
with the CANCELLED status, which is needed for initialization to
distinguish an unresponsive controller.

Signed-off-by: Keith Busch <keith.busch at intel.com>
---
 drivers/nvme/host/pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 67cb406..71f43ff 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -1017,7 +1017,7 @@ static void nvme_cancel_queue_ios(struct request *req, void *data, bool reserved
 	dev_warn(nvmeq->q_dmadev,
 		 "Cancelling I/O %d QID %d\n", req->tag, nvmeq->qid);
 
-	status = NVME_SC_CANCELLED;
+	status = NVME_SC_ABORT_REQ;
 	if (blk_queue_dying(req->q))
 		status |= NVME_SC_DNR;
 	blk_mq_complete_request(req, status);
-- 
2.6.2.307.g37023ba

  parent reply	other threads:[~2015-12-31 16:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-31 16:41 [PATCHv2 0/5] NVMe fixes and updates, version 2 Keith Busch
2015-12-31 16:41 ` [PATCHv2 1/5] NVMe: Fix admin queue ring wrap Keith Busch
2016-01-03 16:44   ` Sagi Grimberg
2015-12-31 16:41 ` Keith Busch [this message]
2016-01-03 16:54   ` [PATCHv2 2/5] NVMe: Use a retryable error code on reset Sagi Grimberg
2015-12-31 16:41 ` [PATCHv2 3/5] NVMe: Remove queue freezing on resets Keith Busch
2016-01-03 16:41   ` Sagi Grimberg
2015-12-31 16:41 ` [PATCHv2 4/5] NVMe: IO queue deletion re-write Keith Busch
2015-12-31 16:41 ` [PATCHv2 5/5] NVMe: Shutdown controller only for power-off Keith Busch
2016-01-03 16:52   ` Sagi Grimberg
2016-01-04 15:54     ` Keith Busch
2016-01-04 16:08       ` Sagi Grimberg
2015-12-31 18:38 ` [PATCHv2 0/5] NVMe fixes and updates, version 2 Sagi Grimberg
2015-12-31 18:40   ` Keith Busch
2015-12-31 18:42     ` Sagi Grimberg
2016-01-02 16:59       ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1451580116-12252-3-git-send-email-keith.busch@intel.com \
    --to=keith.busch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.