From: Joe Perches <joe@perches.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
linux-kernel@vger.kernel.org,
"Cc : Andy Whitcroft" <apw@canonical.com>,
Peter Zijlstra <peterz@infradead.org>,
Arnd Bergmann <arnd@arndb.de>,
linux-arch@vger.kernel.org,
Andrew Cooper <andrew.cooper3@citrix.com>,
virtualization@lists.linux-foundation.org,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
"H. Peter Anvin" <hpa@zytor.com>,
David Miller <davem@davemloft.net>,
linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-s390@vger.kernel.org, sparclinux@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-metag@vger.kernel.org, linux-mips@linux-mips.org,
x86@kernel.org, user-mode-linux-devel@lists.sourceforge.net,
adi-buildroot-devel@lists.sourceforge.net,
linux-sh@vger.kernel.org, linux-xtensa@linux-xtensa.org,
xen-devel@lists.xenpr
Subject: Re: [PATCH 1/3] checkpatch.pl: add missing memory barriers
Date: Mon, 04 Jan 2016 08:15:14 -0800 [thread overview]
Message-ID: <1451924114.4334.85.camel@perches.com> (raw)
In-Reply-To: <20160104161123.GJ19062@n2100.arm.linux.org.uk>
On Mon, 2016-01-04 at 16:11 +0000, Russell King - ARM Linux wrote:
> On Mon, Jan 04, 2016 at 08:07:40AM -0800, Joe Perches wrote:
> > On Mon, 2016-01-04 at 13:36 +0200, Michael S. Tsirkin wrote:
> > > + my $all_barriers = join('|', (@barriers, @smp_barriers));
> > > +
> > > + if ($line =~ /\b($all_barriers)\(/) {
> >
> > It would be better to use /\b$all_barriers\s*\(/
> > as there's no reason for the capture and there
> > could be a space between the function and the
> > open parenthesis.
>
> I think you mean
>
> /\b(?:$all_barriers)\s*\(/
>
> as 'all_barriers' will be:
>
> mb|wmb|rmb|smp_mb|smp_wmb|smp_rmb
>
> and putting that into your suggestion results in:
>
> /\bmb|wmb|rmb|smp_mb|smp_wmb|smp_rmb\s*\(/
>
> which is clearly wrong - the \b only applies to 'mb' and the \s*\( only
> applies to smp_rmb.
right, thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
linux-kernel@vger.kernel.org,
"Cc : Andy Whitcroft" <apw@canonical.com>,
Peter Zijlstra <peterz@infradead.org>,
Arnd Bergmann <arnd@arndb.de>,
linux-arch@vger.kernel.org,
Andrew Cooper <andrew.cooper3@citrix.com>,
virtualization@lists.linux-foundation.org,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
"H. Peter Anvin" <hpa@zytor.com>,
David Miller <davem@davemloft.net>,
linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-s390@vger.kernel.org, sparclinux@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-metag@vger.kernel.org, linux-mips@linux-mips.org,
x86@kernel.org, user-mode-linux-devel@lists.sourceforge.net,
adi-buildroot-devel@lists.sourceforge.net,
linux-sh@vger.kernel.org, linux-xtensa@linux-xtensa.org,
xen-devel@lists.xenproject.org, Ingo Molnar <mingo@kernel.org>,
Tony Lindgren <tony@atomide.com>,
Andrey Konovalov <andreyknvl@google.com>
Subject: Re: [PATCH 1/3] checkpatch.pl: add missing memory barriers
Date: Mon, 04 Jan 2016 08:15:14 -0800 [thread overview]
Message-ID: <1451924114.4334.85.camel@perches.com> (raw)
Message-ID: <20160104161514.pofXaaLn5CyyrJVPiZV_TUgsNGAwqRwQEDqAqKHDZ-s@z> (raw)
In-Reply-To: <20160104161123.GJ19062@n2100.arm.linux.org.uk>
On Mon, 2016-01-04 at 16:11 +0000, Russell King - ARM Linux wrote:
> On Mon, Jan 04, 2016 at 08:07:40AM -0800, Joe Perches wrote:
> > On Mon, 2016-01-04 at 13:36 +0200, Michael S. Tsirkin wrote:
> > > + my $all_barriers = join('|', (@barriers, @smp_barriers));
> > > +
> > > + if ($line =~ /\b($all_barriers)\(/) {
> >
> > It would be better to use /\b$all_barriers\s*\(/
> > as there's no reason for the capture and there
> > could be a space between the function and the
> > open parenthesis.
>
> I think you mean
>
> /\b(?:$all_barriers)\s*\(/
>
> as 'all_barriers' will be:
>
> mb|wmb|rmb|smp_mb|smp_wmb|smp_rmb
>
> and putting that into your suggestion results in:
>
> /\bmb|wmb|rmb|smp_mb|smp_wmb|smp_rmb\s*\(/
>
> which is clearly wrong - the \b only applies to 'mb' and the \s*\( only
> applies to smp_rmb.
right, thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
linux-kernel@vger.kernel.org,
"Cc : Andy Whitcroft" <apw@canonical.com>,
Peter Zijlstra <peterz@infradead.org>,
Arnd Bergmann <arnd@arndb.de>,
linux-arch@vger.kernel.org,
Andrew Cooper <andrew.cooper3@citrix.com>,
virtualization@lists.linux-foundation.org,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
"H. Peter Anvin" <hpa@zytor.com>,
David Miller <davem@davemloft.net>,
linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-s390@vger.kernel.org, sparclinux@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-metag@vger.kernel.org, linux-mips@linux-mips.org,
x86@kernel.org, user-mode-linux-devel@lists.sourceforge.net,
adi-buildroot-devel@lists.sourceforge.net,
linux-sh@vger.kernel.org, linux-xtensa@linux-xtensa.org,
xen-devel@lists.xenpr
Subject: Re: [PATCH 1/3] checkpatch.pl: add missing memory barriers
Date: Mon, 04 Jan 2016 16:15:14 +0000 [thread overview]
Message-ID: <1451924114.4334.85.camel@perches.com> (raw)
In-Reply-To: <20160104161123.GJ19062@n2100.arm.linux.org.uk>
On Mon, 2016-01-04 at 16:11 +0000, Russell King - ARM Linux wrote:
> On Mon, Jan 04, 2016 at 08:07:40AM -0800, Joe Perches wrote:
> > On Mon, 2016-01-04 at 13:36 +0200, Michael S. Tsirkin wrote:
> > > + my $all_barriers = join('|', (@barriers, @smp_barriers));
> > > +
> > > + if ($line =~ /\b($all_barriers)\(/) {
> >
> > It would be better to use /\b$all_barriers\s*\(/
> > as there's no reason for the capture and there
> > could be a space between the function and the
> > open parenthesis.
>
> I think you mean
>
> /\b(?:$all_barriers)\s*\(/
>
> as 'all_barriers' will be:
>
> mb|wmb|rmb|smp_mb|smp_wmb|smp_rmb
>
> and putting that into your suggestion results in:
>
> /\bmb|wmb|rmb|smp_mb|smp_wmb|smp_rmb\s*\(/
>
> which is clearly wrong - the \b only applies to 'mb' and the \s*\( only
> applies to smp_rmb.
right, thanks.
WARNING: multiple messages have this Message-ID (diff)
From: joe@perches.com (Joe Perches)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] checkpatch.pl: add missing memory barriers
Date: Mon, 04 Jan 2016 08:15:14 -0800 [thread overview]
Message-ID: <1451924114.4334.85.camel@perches.com> (raw)
In-Reply-To: <20160104161123.GJ19062@n2100.arm.linux.org.uk>
On Mon, 2016-01-04 at 16:11 +0000, Russell King - ARM Linux wrote:
> On Mon, Jan 04, 2016 at 08:07:40AM -0800, Joe Perches wrote:
> > On Mon, 2016-01-04 at 13:36 +0200, Michael S. Tsirkin wrote:
> > > + my $all_barriers = join('|', (@barriers, @smp_barriers));
> > > +
> > > + if ($line =~ /\b($all_barriers)\(/) {
> >
> > It would be better to use /\b$all_barriers\s*\(/
> > as there's no reason for the capture and there
> > could be a space between the function and the
> > open parenthesis.
>
> I think you mean
>
> /\b(?:$all_barriers)\s*\(/
>
> as 'all_barriers' will be:
>
> mb|wmb|rmb|smp_mb|smp_wmb|smp_rmb
>
> and putting that into your suggestion results in:
>
> /\bmb|wmb|rmb|smp_mb|smp_wmb|smp_rmb\s*\(/
>
> which is clearly wrong - the \b only applies to 'mb' and the \s*\( only
> applies to smp_rmb.
right, thanks.
next prev parent reply other threads:[~2016-01-04 16:15 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-04 11:36 [PATCH 0/3] checkpatch: handling of memory barriers Michael S. Tsirkin
2016-01-04 11:36 ` Michael S. Tsirkin
2016-01-04 11:36 ` Michael S. Tsirkin
2016-01-04 11:36 ` Michael S. Tsirkin
2016-01-04 11:36 ` [PATCH 1/3] checkpatch.pl: add missing " Michael S. Tsirkin
2016-01-04 11:36 ` Michael S. Tsirkin
2016-01-04 11:36 ` Michael S. Tsirkin
2016-01-04 11:36 ` Michael S. Tsirkin
2016-01-04 16:07 ` Joe Perches
2016-01-04 16:07 ` Joe Perches
2016-01-04 16:07 ` Joe Perches
2016-01-04 16:07 ` Joe Perches
2016-01-04 16:07 ` Joe Perches
2016-01-04 16:11 ` Russell King - ARM Linux
2016-01-04 16:11 ` Russell King - ARM Linux
2016-01-04 16:11 ` Russell King - ARM Linux
2016-01-04 16:11 ` Russell King - ARM Linux
2016-01-04 16:11 ` Russell King - ARM Linux
2016-01-04 16:11 ` Russell King - ARM Linux
2016-01-04 16:15 ` Joe Perches
2016-01-04 16:15 ` Joe Perches
2016-01-04 16:15 ` Joe Perches [this message]
2016-01-04 16:15 ` Joe Perches
2016-01-04 16:15 ` Joe Perches
2016-01-04 16:15 ` Joe Perches
2016-01-04 20:45 ` Michael S. Tsirkin
2016-01-04 20:45 ` Michael S. Tsirkin
[not found] ` <1451923660.4334.83.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2016-01-04 20:45 ` Michael S. Tsirkin
2016-01-04 20:45 ` Michael S. Tsirkin
2016-01-04 20:45 ` Michael S. Tsirkin
2016-01-04 20:45 ` Michael S. Tsirkin
2016-01-04 20:45 ` Michael S. Tsirkin
2016-01-04 22:15 ` Joe Perches
2016-01-04 22:15 ` Joe Perches
[not found] ` <20160104224415-mutt-send-email-mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-01-04 22:15 ` Joe Perches
2016-01-04 22:15 ` Joe Perches
2016-01-04 22:15 ` Joe Perches
2016-01-04 22:15 ` Joe Perches
2016-01-04 22:15 ` Joe Perches
2016-01-10 11:42 ` Michael S. Tsirkin
2016-01-10 11:42 ` Michael S. Tsirkin
2016-01-10 11:42 ` Michael S. Tsirkin
2016-01-10 11:42 ` Michael S. Tsirkin
2016-01-10 11:42 ` Michael S. Tsirkin
2016-01-10 11:42 ` Michael S. Tsirkin
2016-01-04 16:07 ` Joe Perches
2016-01-04 16:07 ` Joe Perches
2016-01-04 11:36 ` Michael S. Tsirkin
2016-01-04 11:37 ` [PATCH 2/3] checkpatch: check for __smp outside barrier.h Michael S. Tsirkin
2016-01-04 11:37 ` Michael S. Tsirkin
2016-01-04 11:37 ` Michael S. Tsirkin
2016-01-04 11:37 ` Michael S. Tsirkin
2016-01-04 11:37 ` Michael S. Tsirkin
2016-01-04 11:37 ` [PATCH 3/3] checkpatch: add virt barriers Michael S. Tsirkin
2016-01-04 11:37 ` Michael S. Tsirkin
2016-01-04 11:37 ` Michael S. Tsirkin
2016-01-04 11:37 ` Michael S. Tsirkin
2016-01-04 11:37 ` Michael S. Tsirkin
2016-01-04 16:47 ` Joe Perches
2016-01-04 16:47 ` Joe Perches
2016-01-04 16:47 ` Joe Perches
2016-01-04 16:47 ` Joe Perches
2016-01-04 16:47 ` Joe Perches
2016-01-04 16:47 ` Joe Perches
2016-01-04 21:07 ` Michael S. Tsirkin
2016-01-04 21:07 ` Michael S. Tsirkin
[not found] ` <1451926073.4334.90.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2016-01-04 21:07 ` Michael S. Tsirkin
2016-01-04 21:07 ` Michael S. Tsirkin
2016-01-04 21:07 ` Michael S. Tsirkin
2016-01-04 21:07 ` Michael S. Tsirkin
[not found] ` <20160104230528-mutt-send-email-mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-01-04 22:11 ` Joe Perches
2016-01-04 22:11 ` Joe Perches
2016-01-04 22:11 ` Joe Perches
2016-01-04 22:11 ` Joe Perches
2016-01-04 22:11 ` Joe Perches
2016-01-08 10:14 ` Michael S. Tsirkin
2016-01-08 10:14 ` Michael S. Tsirkin
2016-01-08 10:14 ` Michael S. Tsirkin
2016-01-08 10:14 ` Michael S. Tsirkin
2016-01-08 10:14 ` Michael S. Tsirkin
2016-01-08 10:14 ` Michael S. Tsirkin
2016-01-04 22:11 ` Joe Perches
2016-01-04 22:11 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1451924114.4334.85.camel@perches.com \
--to=joe@perches.com \
--cc=adi-buildroot-devel@lists.sourceforge.net \
--cc=andrew.cooper3@citrix.com \
--cc=apw@canonical.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-metag@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=linux@arm.linux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@elte.hu \
--cc=mst@redhat.com \
--cc=peterz@infradead.org \
--cc=sparclinux@vger.kernel.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tglx@linutronix.de \
--cc=user-mode-linux-devel@lists.sourceforge.net \
--cc=virtualization@lists.linux-foundation.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenpr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.