* [PATCH] data: Drop misleading ExpansionError exception
@ 2016-01-04 17:33 Richard Purdie
0 siblings, 0 replies; only message in thread
From: Richard Purdie @ 2016-01-04 17:33 UTC (permalink / raw)
To: bitbake-devel
This codepath can be triggered by a python indentation error for example.
Showing it as an ExpansionError is misleading.
Change the code to add a warning about where the failure came from (in
particular giving the variable key name that triggered it) but raise the
proper exception.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
diff --git a/bitbake/lib/bb/data.py b/bitbake/lib/bb/data.py
index dc8d02e..fac57da 100644
--- a/bitbake/lib/bb/data.py
+++ b/bitbake/lib/bb/data.py
@@ -406,7 +406,8 @@ def build_dependencies(key, keys, shelldeps, varflagsexcl, d):
deps |= set((vardeps or "").split())
deps -= set(varflags.get("vardepsexclude", "").split())
except Exception as e:
- raise bb.data_smart.ExpansionError(key, None, e)
+ bb.warn("Exception during build_dependencies for %s" % key)
+ raise
return deps, value
#bb.note("Variable %s references %s and calls %s" % (key, str(deps), str(execs)))
#d.setVarFlag(key, "vardeps", deps)
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2016-01-04 17:33 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-04 17:33 [PATCH] data: Drop misleading ExpansionError exception Richard Purdie
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.