Re: [PATCH 1/2] vm_event: sync domctl

[Ian Campbell <ian.campbell@citrix.com>]

On Wed, 2016-01-06 at 19:29 +0100, Tamas K Lengyel wrote:
> 
> 
> On Wed, Jan 6, 2016 at 4:48 PM, Ian Campbell <ian.campbell@citrix.com>
> wrote:
> > On Wed, 2015-12-23 at 15:53 +0100, Tamas K Lengyel wrote:
> > > Introduce new vm_event domctl option which allows an event subscriber
> > > to request all vCPUs not currently pending a vm_event request to be
> > > paused,
> > > thus allowing the subscriber to sync up on the state of the domain.
> > This
> > > is especially useful when the subscribed wants to disable certain
> > events
> > > from being delivered and wants to ensure no more requests are pending
> > on
> > > the
> > > ring before doing so.
> > >
> > > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> > > Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> > > Cc: Ian Campbell <ian.campbell@citrix.com>
> > > Cc: Wei Liu <wei.liu2@citrix.com>
> > > Cc: Razvan Cojocaru <rcojocaru@bitdefender.com>
> > > Signed-off-by: Tamas K Lengyel <tamas@tklengyel.com>
> > > ---
> > >  tools/libxc/include/xenctrl.h | 11 +++++++++++
> > >  tools/libxc/xc_vm_event.c     | 16 ++++++++++++++++
> > 
> > Tools side is pretty trivial, assuming there is agreement on the
> > underlying
> > hypercall interface:
> > 
> > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> Thanks, we've decided that this patch is actually not needed as the pause
> reference count is already good enough.

OK, thanks.

> > > +/***
> > >   * Memory sharing operations.
> > 
> > Do you also maintain this? If so do you fancy sending a patch to fix:
> > 
> > >   *
> > >   * Unles otherwise noted, these calls return 0 on succes, -1 and
> > errno on
> > 
> > "Unless" and "success" ?
> > 
> Sure, that could be done in a separate patch.

Yes, that's what I intended.

>  IMHO the whole sharing subsystem could use a cleanup series of its own
> to fix things like this, style issues and whatnot.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel