diff for duplicates of <1452517435.26146.24.camel@intel.com> diff --git a/a/1.txt b/N1/1.txt index 9ed681d..bce7f09 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,40 +1,69 @@ -T24gTW9uLCAyMDE2LTAxLTExIGF0IDEyOjU0ICswMDAwLCBNw6VucyBSdWxsZ8OlcmQgd3JvdGU6 -DQo+ICJTaGV2Y2hlbmtvLCBBbmRyaXkiIDxhbmRyaXkuc2hldmNoZW5rb0BpbnRlbC5jb20+IHdy -aXRlczoNCj4gDQo+ID4gT24gTW9uLCAyMDE2LTAxLTExIGF0IDE0OjI4ICswMjAwLCBBbmR5IFNo -ZXZjaGVua28gd3JvdGU6DQo+ID4gPiBPbiBGcmksIDIwMTYtMDEtMDggYXQgMTg6NDMgKzAxMDAs -IEFudG9uIFd1ZXJmZWwgd3JvdGU6DQo+ID4gPiA+IFRoaXMgcGF0Y2ggZml4ZXMgd2hpdGVzcGFj -ZSBlcnJvcnMgcmVwb3J0ZWQgYnkgY2hlY2twYXRjaCB0bw0KPiA+ID4gPiBpbmNyZWFzZQ0KPiA+ -ID4gPiByZWFkYWJpbGl0eS4gTWFpbiBmb2N1cyBpcyBvbiBtaXNzaW5nIHNwYWNlcyBhZnRlciBj -b21tYXMgaW4NCj4gPiA+ID4gZnVuY3Rpb24gaGVhZGVycyBhbmQgbWFjcm9zIChsaWtlIGZvbyxi -YXIgZWRpdGVkIHRvIGZvbywgYmFyKS4NCj4gPiA+ID4gDQo+ID4gPiA+IFNpZ25lZC1vZmYtYnk6 -IEFudG9uIFfDvHJmZWwgPGFudG9uLnd1ZXJmZWxAZmF1LmRlPg0KPiA+ID4gPiBTaWduZWQtb2Zm -LWJ5OiBQaGlsbGlwIFJhZmZlY2sgPHBoaWxsaXAucmFmZmVja0BmYXUuZGU+DQo+ID4gPiA+IEND -OiBsaW51eC1rZXJuZWxAaTQuY3MuZmF1LmRlDQo+ID4gPiANCj4gPiA+IENjOiBsb29rcyBtb3Jl -IHN0YW5kYXJkLg0KPiA+ID4gDQo+ID4gPiA+IC0tLSBhL2RyaXZlcnMvdHR5L3NlcmlhbC84MjUw -LzgyNTBfYWNjZW50LmMNCj4gPiA+ID4gKysrIGIvZHJpdmVycy90dHkvc2VyaWFsLzgyNTAvODI1 -MF9hY2NlbnQuYw0KPiA+ID4gPiBAQCAtMTAsNyArMTAsNyBAQA0KPiA+ID4gPiDCoCNpbmNsdWRl -IDxsaW51eC9pbml0Lmg+DQo+ID4gPiA+IMKgI2luY2x1ZGUgPGxpbnV4L3NlcmlhbF84MjUwLmg+ -DQo+ID4gPiA+IMKgDQo+ID4gPiA+IC0jZGVmaW5lIFBPUlQoX2Jhc2UsX2lycSkJCQkJXA0KPiA+ -ID4gPiArI2RlZmluZSBQT1JUKF9iYXNlLCBfaXJxKQkJCQlcDQo+ID4gPiA+IMKgCXsJCQkJCQlc -DQo+ID4gPiA+IMKgCQkuaW9iYXNlCQk9IF9iYXNlLAkJDQo+ID4gPiA+IFwNCj4gPiA+ID4gwqAJ -CS5pcnEJCT0gX2lycSwJCQkNCj4gPiA+ID4gXA0KPiA+IA0KPiA+IDgyNTBfUE9SVCgpDQo+ID4g -DQo+ID4gPiA+IA0KPiA+ID4gDQo+ID4gPiBXaGlsZSB0aG9zZSBhcmUgb2theSwgSSB3b3VsZCBz -dWdnZXN0IHRvIG1ha2UgYSBtYWNybyBpbg0KPiA+ID4gZHJpdmVycy/igKYvODI1MC5oIG9uZSBm -b3IgYWxsLCBzb21ldGhpbmcgbGlrZSB0aGlzOg0KPiA+ID4gDQo+ID4gPiAjZGVmaW5lIDgyNTBf -UE9SVF9GTEFHUyhfYmFzZSwgX2lycSwgX2ZsYWdzKQ0KPiA+ID4g4oCmDQo+ID4gPiAJLmZsYWdz -wqDCoMKgwqDCoMKgwqDCoMKgwqA9IFVQRl9CT09UX0FVVE9DT05GIHwgKF9mbGFncykgXA0KPiA+ -ID4gDQo+ID4gPiAjZGVmaW5lIDgyNTBfUE9SVChfYmFzZSwgX2lycSkJODI1MF9QT1JUX0ZMQUdT -KF9iYXNlLA0KPiA+ID4gX2lycSwgMCkNCj4gPiA+IA0KPiA+ID4gQW5kIHVzZSBpdC4NCj4gPiAN -Cj4gPiAjZGVmaW5lIDgyNTBfRk9VUlBPUlQoX2Jhc2UsIF9pcnEpCTgyNTBfUE9SVF9GTEFHUyhf -YmFzZSwNCj4gPiBfaXJxLA0KPiA+IFVQRl9GT1VSUE9SVCkNCj4gDQo+IE1hY3JvIG5hbWVzIGNh -bid0IHN0YXJ0IHdpdGggYSBudW1iZXIuDQoNCk9oLCByaWdodCwgdGhhbmtzLg0KDQpTRVJJQUw4 -MjUwX1BPUlQqIHdpbGwgd29yay4NCg0KLS0gDQpBbmR5IFNoZXZjaGVua28gPGFuZHJpeS5zaGV2 -Y2hlbmtvQGludGVsLmNvbT4NCkludGVsIEZpbmxhbmQgT3kNCi0tLS0tLS0tLS0tLS0tLS0tLS0t -LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQpJbnRlbCBG -aW5sYW5kIE95ClJlZ2lzdGVyZWQgQWRkcmVzczogUEwgMjgxLCAwMDE4MSBIZWxzaW5raSAKQnVz -aW5lc3MgSWRlbnRpdHkgQ29kZTogMDM1NzYwNiAtIDQgCkRvbWljaWxlZCBpbiBIZWxzaW5raSAK -ClRoaXMgZS1tYWlsIGFuZCBhbnkgYXR0YWNobWVudHMgbWF5IGNvbnRhaW4gY29uZmlkZW50aWFs -IG1hdGVyaWFsIGZvcgp0aGUgc29sZSB1c2Ugb2YgdGhlIGludGVuZGVkIHJlY2lwaWVudChzKS4g -QW55IHJldmlldyBvciBkaXN0cmlidXRpb24KYnkgb3RoZXJzIGlzIHN0cmljdGx5IHByb2hpYml0 -ZWQuIElmIHlvdSBhcmUgbm90IHRoZSBpbnRlbmRlZApyZWNpcGllbnQsIHBsZWFzZSBjb250YWN0 -IHRoZSBzZW5kZXIgYW5kIGRlbGV0ZSBhbGwgY29waWVzLgo= +On Mon, 2016-01-11 at 12:54 +0000, Måns Rullgård wrote: +> "Shevchenko, Andriy" <andriy.shevchenko@intel.com> writes: +> +> > On Mon, 2016-01-11 at 14:28 +0200, Andy Shevchenko wrote: +> > > On Fri, 2016-01-08 at 18:43 +0100, Anton Wuerfel wrote: +> > > > This patch fixes whitespace errors reported by checkpatch to +> > > > increase +> > > > readability. Main focus is on missing spaces after commas in +> > > > function headers and macros (like foo,bar edited to foo, bar). +> > > > +> > > > Signed-off-by: Anton Würfel <anton.wuerfel@fau.de> +> > > > Signed-off-by: Phillip Raffeck <phillip.raffeck@fau.de> +> > > > CC: linux-kernel@i4.cs.fau.de +> > > +> > > Cc: looks more standard. +> > > +> > > > --- a/drivers/tty/serial/8250/8250_accent.c +> > > > +++ b/drivers/tty/serial/8250/8250_accent.c +> > > > @@ -10,7 +10,7 @@ +> > > > #include <linux/init.h> +> > > > #include <linux/serial_8250.h> +> > > > +> > > > -#define PORT(_base,_irq) \ +> > > > +#define PORT(_base, _irq) \ +> > > > { \ +> > > > .iobase = _base, +> > > > \ +> > > > .irq = _irq, +> > > > \ +> > +> > 8250_PORT() +> > +> > > > +> > > +> > > While those are okay, I would suggest to make a macro in +> > > drivers/…/8250.h one for all, something like this: +> > > +> > > #define 8250_PORT_FLAGS(_base, _irq, _flags) +> > > … +> > > .flags = UPF_BOOT_AUTOCONF | (_flags) \ +> > > +> > > #define 8250_PORT(_base, _irq) 8250_PORT_FLAGS(_base, +> > > _irq, 0) +> > > +> > > And use it. +> > +> > #define 8250_FOURPORT(_base, _irq) 8250_PORT_FLAGS(_base, +> > _irq, +> > UPF_FOURPORT) +> +> Macro names can't start with a number. + +Oh, right, thanks. + +SERIAL8250_PORT* will work. + +-- +Andy Shevchenko <andriy.shevchenko@intel.com> +Intel Finland Oy +--------------------------------------------------------------------- +Intel Finland Oy +Registered Address: PL 281, 00181 Helsinki +Business Identity Code: 0357606 - 4 +Domiciled in Helsinki + +This e-mail and any attachments may contain confidential material for +the sole use of the intended recipient(s). Any review or distribution +by others is strictly prohibited. If you are not the intended +recipient, please contact the sender and delete all copies. diff --git a/a/content_digest b/N1/content_digest index a00f679..75149f0 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -25,48 +25,81 @@ linux-kernel@i4.cs.fau.de <linux-kernel@i4.cs.fau.de> adam.lee@canonical.com <adam.lee@canonical.com> gregkh@linuxfoundation.org <gregkh@linuxfoundation.org> - " jejb@parisc-linux.or\0" + jejb@parisc-linux.org <jejb@parisc-linux.org> + linux-parisc@vger.kernel.org <linux-parisc@vger.kernel.org> + peter@hurleysoftware.com <peter@hurleysoftware.com> + matt.redfearn@imgtec.com <matt.redfearn@imgtec.com> + " k.kozlowski@samsung.com <k.kozlowski@samsung.com>\0" "\00:1\0" "b\0" - "T24gTW9uLCAyMDE2LTAxLTExIGF0IDEyOjU0ICswMDAwLCBNw6VucyBSdWxsZ8OlcmQgd3JvdGU6\n" - "DQo+ICJTaGV2Y2hlbmtvLCBBbmRyaXkiIDxhbmRyaXkuc2hldmNoZW5rb0BpbnRlbC5jb20+IHdy\n" - "aXRlczoNCj4gDQo+ID4gT24gTW9uLCAyMDE2LTAxLTExIGF0IDE0OjI4ICswMjAwLCBBbmR5IFNo\n" - "ZXZjaGVua28gd3JvdGU6DQo+ID4gPiBPbiBGcmksIDIwMTYtMDEtMDggYXQgMTg6NDMgKzAxMDAs\n" - "IEFudG9uIFd1ZXJmZWwgd3JvdGU6DQo+ID4gPiA+IFRoaXMgcGF0Y2ggZml4ZXMgd2hpdGVzcGFj\n" - "ZSBlcnJvcnMgcmVwb3J0ZWQgYnkgY2hlY2twYXRjaCB0bw0KPiA+ID4gPiBpbmNyZWFzZQ0KPiA+\n" - "ID4gPiByZWFkYWJpbGl0eS4gTWFpbiBmb2N1cyBpcyBvbiBtaXNzaW5nIHNwYWNlcyBhZnRlciBj\n" - "b21tYXMgaW4NCj4gPiA+ID4gZnVuY3Rpb24gaGVhZGVycyBhbmQgbWFjcm9zIChsaWtlIGZvbyxi\n" - "YXIgZWRpdGVkIHRvIGZvbywgYmFyKS4NCj4gPiA+ID4gDQo+ID4gPiA+IFNpZ25lZC1vZmYtYnk6\n" - "IEFudG9uIFfDvHJmZWwgPGFudG9uLnd1ZXJmZWxAZmF1LmRlPg0KPiA+ID4gPiBTaWduZWQtb2Zm\n" - "LWJ5OiBQaGlsbGlwIFJhZmZlY2sgPHBoaWxsaXAucmFmZmVja0BmYXUuZGU+DQo+ID4gPiA+IEND\n" - "OiBsaW51eC1rZXJuZWxAaTQuY3MuZmF1LmRlDQo+ID4gPiANCj4gPiA+IENjOiBsb29rcyBtb3Jl\n" - "IHN0YW5kYXJkLg0KPiA+ID4gDQo+ID4gPiA+IC0tLSBhL2RyaXZlcnMvdHR5L3NlcmlhbC84MjUw\n" - "LzgyNTBfYWNjZW50LmMNCj4gPiA+ID4gKysrIGIvZHJpdmVycy90dHkvc2VyaWFsLzgyNTAvODI1\n" - "MF9hY2NlbnQuYw0KPiA+ID4gPiBAQCAtMTAsNyArMTAsNyBAQA0KPiA+ID4gPiDCoCNpbmNsdWRl\n" - "IDxsaW51eC9pbml0Lmg+DQo+ID4gPiA+IMKgI2luY2x1ZGUgPGxpbnV4L3NlcmlhbF84MjUwLmg+\n" - "DQo+ID4gPiA+IMKgDQo+ID4gPiA+IC0jZGVmaW5lIFBPUlQoX2Jhc2UsX2lycSkJCQkJXA0KPiA+\n" - "ID4gPiArI2RlZmluZSBQT1JUKF9iYXNlLCBfaXJxKQkJCQlcDQo+ID4gPiA+IMKgCXsJCQkJCQlc\n" - "DQo+ID4gPiA+IMKgCQkuaW9iYXNlCQk9IF9iYXNlLAkJDQo+ID4gPiA+IFwNCj4gPiA+ID4gwqAJ\n" - "CS5pcnEJCT0gX2lycSwJCQkNCj4gPiA+ID4gXA0KPiA+IA0KPiA+IDgyNTBfUE9SVCgpDQo+ID4g\n" - "DQo+ID4gPiA+IA0KPiA+ID4gDQo+ID4gPiBXaGlsZSB0aG9zZSBhcmUgb2theSwgSSB3b3VsZCBz\n" - "dWdnZXN0IHRvIG1ha2UgYSBtYWNybyBpbg0KPiA+ID4gZHJpdmVycy/igKYvODI1MC5oIG9uZSBm\n" - "b3IgYWxsLCBzb21ldGhpbmcgbGlrZSB0aGlzOg0KPiA+ID4gDQo+ID4gPiAjZGVmaW5lIDgyNTBf\n" - "UE9SVF9GTEFHUyhfYmFzZSwgX2lycSwgX2ZsYWdzKQ0KPiA+ID4g4oCmDQo+ID4gPiAJLmZsYWdz\n" - "wqDCoMKgwqDCoMKgwqDCoMKgwqA9IFVQRl9CT09UX0FVVE9DT05GIHwgKF9mbGFncykgXA0KPiA+\n" - "ID4gDQo+ID4gPiAjZGVmaW5lIDgyNTBfUE9SVChfYmFzZSwgX2lycSkJODI1MF9QT1JUX0ZMQUdT\n" - "KF9iYXNlLA0KPiA+ID4gX2lycSwgMCkNCj4gPiA+IA0KPiA+ID4gQW5kIHVzZSBpdC4NCj4gPiAN\n" - "Cj4gPiAjZGVmaW5lIDgyNTBfRk9VUlBPUlQoX2Jhc2UsIF9pcnEpCTgyNTBfUE9SVF9GTEFHUyhf\n" - "YmFzZSwNCj4gPiBfaXJxLA0KPiA+IFVQRl9GT1VSUE9SVCkNCj4gDQo+IE1hY3JvIG5hbWVzIGNh\n" - "bid0IHN0YXJ0IHdpdGggYSBudW1iZXIuDQoNCk9oLCByaWdodCwgdGhhbmtzLg0KDQpTRVJJQUw4\n" - "MjUwX1BPUlQqIHdpbGwgd29yay4NCg0KLS0gDQpBbmR5IFNoZXZjaGVua28gPGFuZHJpeS5zaGV2\n" - "Y2hlbmtvQGludGVsLmNvbT4NCkludGVsIEZpbmxhbmQgT3kNCi0tLS0tLS0tLS0tLS0tLS0tLS0t\n" - "LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQpJbnRlbCBG\n" - "aW5sYW5kIE95ClJlZ2lzdGVyZWQgQWRkcmVzczogUEwgMjgxLCAwMDE4MSBIZWxzaW5raSAKQnVz\n" - "aW5lc3MgSWRlbnRpdHkgQ29kZTogMDM1NzYwNiAtIDQgCkRvbWljaWxlZCBpbiBIZWxzaW5raSAK\n" - "ClRoaXMgZS1tYWlsIGFuZCBhbnkgYXR0YWNobWVudHMgbWF5IGNvbnRhaW4gY29uZmlkZW50aWFs\n" - "IG1hdGVyaWFsIGZvcgp0aGUgc29sZSB1c2Ugb2YgdGhlIGludGVuZGVkIHJlY2lwaWVudChzKS4g\n" - "QW55IHJldmlldyBvciBkaXN0cmlidXRpb24KYnkgb3RoZXJzIGlzIHN0cmljdGx5IHByb2hpYml0\n" - "ZWQuIElmIHlvdSBhcmUgbm90IHRoZSBpbnRlbmRlZApyZWNpcGllbnQsIHBsZWFzZSBjb250YWN0\n" - IHRoZSBzZW5kZXIgYW5kIGRlbGV0ZSBhbGwgY29waWVzLgo= + "On Mon, 2016-01-11 at 12:54 +0000, M\303\245ns Rullg\303\245rd wrote:\n" + "> \"Shevchenko, Andriy\" <andriy.shevchenko@intel.com> writes:\n" + "> \n" + "> > On Mon, 2016-01-11 at 14:28 +0200, Andy Shevchenko wrote:\n" + "> > > On Fri, 2016-01-08 at 18:43 +0100, Anton Wuerfel wrote:\n" + "> > > > This patch fixes whitespace errors reported by checkpatch to\n" + "> > > > increase\n" + "> > > > readability. Main focus is on missing spaces after commas in\n" + "> > > > function headers and macros (like foo,bar edited to foo, bar).\n" + "> > > > \n" + "> > > > Signed-off-by: Anton W\303\274rfel <anton.wuerfel@fau.de>\n" + "> > > > Signed-off-by: Phillip Raffeck <phillip.raffeck@fau.de>\n" + "> > > > CC: linux-kernel@i4.cs.fau.de\n" + "> > > \n" + "> > > Cc: looks more standard.\n" + "> > > \n" + "> > > > --- a/drivers/tty/serial/8250/8250_accent.c\n" + "> > > > +++ b/drivers/tty/serial/8250/8250_accent.c\n" + "> > > > @@ -10,7 +10,7 @@\n" + "> > > > \302\240#include <linux/init.h>\n" + "> > > > \302\240#include <linux/serial_8250.h>\n" + "> > > > \302\240\n" + "> > > > -#define PORT(_base,_irq)\t\t\t\t\\\n" + "> > > > +#define PORT(_base, _irq)\t\t\t\t\\\n" + "> > > > \302\240\t{\t\t\t\t\t\t\\\n" + "> > > > \302\240\t\t.iobase\t\t= _base,\t\t\n" + "> > > > \\\n" + "> > > > \302\240\t\t.irq\t\t= _irq,\t\t\t\n" + "> > > > \\\n" + "> > \n" + "> > 8250_PORT()\n" + "> > \n" + "> > > > \n" + "> > > \n" + "> > > While those are okay, I would suggest to make a macro in\n" + "> > > drivers/\342\200\246/8250.h one for all, something like this:\n" + "> > > \n" + "> > > #define 8250_PORT_FLAGS(_base, _irq, _flags)\n" + "> > > \342\200\246\n" + "> > > \t.flags\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240= UPF_BOOT_AUTOCONF | (_flags) \\\n" + "> > > \n" + "> > > #define 8250_PORT(_base, _irq)\t8250_PORT_FLAGS(_base,\n" + "> > > _irq, 0)\n" + "> > > \n" + "> > > And use it.\n" + "> > \n" + "> > #define 8250_FOURPORT(_base, _irq)\t8250_PORT_FLAGS(_base,\n" + "> > _irq,\n" + "> > UPF_FOURPORT)\n" + "> \n" + "> Macro names can't start with a number.\n" + "\n" + "Oh, right, thanks.\n" + "\n" + "SERIAL8250_PORT* will work.\n" + "\n" + "-- \n" + "Andy Shevchenko <andriy.shevchenko@intel.com>\n" + "Intel Finland Oy\n" + "---------------------------------------------------------------------\n" + "Intel Finland Oy\n" + "Registered Address: PL 281, 00181 Helsinki \n" + "Business Identity Code: 0357606 - 4 \n" + "Domiciled in Helsinki \n" + "\n" + "This e-mail and any attachments may contain confidential material for\n" + "the sole use of the intended recipient(s). Any review or distribution\n" + "by others is strictly prohibited. If you are not the intended\n" + recipient, please contact the sender and delete all copies. -d5874ea374efc92a063ec45b82e8c7e123df1bcb92000fd9df2b07c408c96ca2 +47a7e2ac6e4e0efc401a92e52d0ef4f2dba4513f9f531c08b88e59951447546e
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.