From: "Shevchenko, Andriy" <andriy.shevchenko@intel.com>
To: "mans@mansr.com" <mans@mansr.com>
Cc: "anton.wuerfel@fau.de" <anton.wuerfel@fau.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mail@maciej.szmigiero.name" <mail@maciej.szmigiero.name>,
"desmondl@broadcom.com" <desmondl@broadcom.com>,
"Zha, Qipeng" <qipeng.zha@intel.com>,
"heikki.krogerus@linux.intel.com"
<heikki.krogerus@linux.intel.com>,
"long.wanglong@huawei.com" <long.wanglong@huawei.com>,
"soeren.grunewald@desy.de" <soeren.grunewald@desy.de>,
"deller@gmx.de" <deller@gmx.de>,
"jslaby@suse.com" <jslaby@suse.com>,
"phillip.raffeck@fau.de" <phillip.raffeck@fau.de>,
"paul.burton@imgtec.com" <paul.burton@imgtec.com>,
"hpeter@gmail.com" <hpeter@gmail.com>,
"ralf@linux-mips.org" <ralf@linux-mips.org>,
"linux-kernel@i4.cs.fau.de" <linux-kernel@i4.cs.fau.de>,
"adam.lee@canonical.com" <adam.lee@canonical.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"jejb@parisc-linux.or
Subject: Re: [PATCH v4 01/13] tty: serial: 8250: Fix whitespace errors
Date: Mon, 11 Jan 2016 13:03:27 +0000 [thread overview]
Message-ID: <1452517435.26146.24.camel@intel.com> (raw)
In-Reply-To: <yw1x7fjgxonh.fsf@unicorn.mansr.com>
T24gTW9uLCAyMDE2LTAxLTExIGF0IDEyOjU0ICswMDAwLCBNw6VucyBSdWxsZ8OlcmQgd3JvdGU6
DQo+ICJTaGV2Y2hlbmtvLCBBbmRyaXkiIDxhbmRyaXkuc2hldmNoZW5rb0BpbnRlbC5jb20+IHdy
aXRlczoNCj4gDQo+ID4gT24gTW9uLCAyMDE2LTAxLTExIGF0IDE0OjI4ICswMjAwLCBBbmR5IFNo
ZXZjaGVua28gd3JvdGU6DQo+ID4gPiBPbiBGcmksIDIwMTYtMDEtMDggYXQgMTg6NDMgKzAxMDAs
IEFudG9uIFd1ZXJmZWwgd3JvdGU6DQo+ID4gPiA+IFRoaXMgcGF0Y2ggZml4ZXMgd2hpdGVzcGFj
ZSBlcnJvcnMgcmVwb3J0ZWQgYnkgY2hlY2twYXRjaCB0bw0KPiA+ID4gPiBpbmNyZWFzZQ0KPiA+
ID4gPiByZWFkYWJpbGl0eS4gTWFpbiBmb2N1cyBpcyBvbiBtaXNzaW5nIHNwYWNlcyBhZnRlciBj
b21tYXMgaW4NCj4gPiA+ID4gZnVuY3Rpb24gaGVhZGVycyBhbmQgbWFjcm9zIChsaWtlIGZvbyxi
YXIgZWRpdGVkIHRvIGZvbywgYmFyKS4NCj4gPiA+ID4gDQo+ID4gPiA+IFNpZ25lZC1vZmYtYnk6
IEFudG9uIFfDvHJmZWwgPGFudG9uLnd1ZXJmZWxAZmF1LmRlPg0KPiA+ID4gPiBTaWduZWQtb2Zm
LWJ5OiBQaGlsbGlwIFJhZmZlY2sgPHBoaWxsaXAucmFmZmVja0BmYXUuZGU+DQo+ID4gPiA+IEND
OiBsaW51eC1rZXJuZWxAaTQuY3MuZmF1LmRlDQo+ID4gPiANCj4gPiA+IENjOiBsb29rcyBtb3Jl
IHN0YW5kYXJkLg0KPiA+ID4gDQo+ID4gPiA+IC0tLSBhL2RyaXZlcnMvdHR5L3NlcmlhbC84MjUw
LzgyNTBfYWNjZW50LmMNCj4gPiA+ID4gKysrIGIvZHJpdmVycy90dHkvc2VyaWFsLzgyNTAvODI1
MF9hY2NlbnQuYw0KPiA+ID4gPiBAQCAtMTAsNyArMTAsNyBAQA0KPiA+ID4gPiDCoCNpbmNsdWRl
IDxsaW51eC9pbml0Lmg+DQo+ID4gPiA+IMKgI2luY2x1ZGUgPGxpbnV4L3NlcmlhbF84MjUwLmg+
DQo+ID4gPiA+IMKgDQo+ID4gPiA+IC0jZGVmaW5lIFBPUlQoX2Jhc2UsX2lycSkJCQkJXA0KPiA+
ID4gPiArI2RlZmluZSBQT1JUKF9iYXNlLCBfaXJxKQkJCQlcDQo+ID4gPiA+IMKgCXsJCQkJCQlc
DQo+ID4gPiA+IMKgCQkuaW9iYXNlCQk9IF9iYXNlLAkJDQo+ID4gPiA+IFwNCj4gPiA+ID4gwqAJ
CS5pcnEJCT0gX2lycSwJCQkNCj4gPiA+ID4gXA0KPiA+IA0KPiA+IDgyNTBfUE9SVCgpDQo+ID4g
DQo+ID4gPiA+IA0KPiA+ID4gDQo+ID4gPiBXaGlsZSB0aG9zZSBhcmUgb2theSwgSSB3b3VsZCBz
dWdnZXN0IHRvIG1ha2UgYSBtYWNybyBpbg0KPiA+ID4gZHJpdmVycy/igKYvODI1MC5oIG9uZSBm
b3IgYWxsLCBzb21ldGhpbmcgbGlrZSB0aGlzOg0KPiA+ID4gDQo+ID4gPiAjZGVmaW5lIDgyNTBf
UE9SVF9GTEFHUyhfYmFzZSwgX2lycSwgX2ZsYWdzKQ0KPiA+ID4g4oCmDQo+ID4gPiAJLmZsYWdz
wqDCoMKgwqDCoMKgwqDCoMKgwqA9IFVQRl9CT09UX0FVVE9DT05GIHwgKF9mbGFncykgXA0KPiA+
ID4gDQo+ID4gPiAjZGVmaW5lIDgyNTBfUE9SVChfYmFzZSwgX2lycSkJODI1MF9QT1JUX0ZMQUdT
KF9iYXNlLA0KPiA+ID4gX2lycSwgMCkNCj4gPiA+IA0KPiA+ID4gQW5kIHVzZSBpdC4NCj4gPiAN
Cj4gPiAjZGVmaW5lIDgyNTBfRk9VUlBPUlQoX2Jhc2UsIF9pcnEpCTgyNTBfUE9SVF9GTEFHUyhf
YmFzZSwNCj4gPiBfaXJxLA0KPiA+IFVQRl9GT1VSUE9SVCkNCj4gDQo+IE1hY3JvIG5hbWVzIGNh
bid0IHN0YXJ0IHdpdGggYSBudW1iZXIuDQoNCk9oLCByaWdodCwgdGhhbmtzLg0KDQpTRVJJQUw4
MjUwX1BPUlQqIHdpbGwgd29yay4NCg0KLS0gDQpBbmR5IFNoZXZjaGVua28gPGFuZHJpeS5zaGV2
Y2hlbmtvQGludGVsLmNvbT4NCkludGVsIEZpbmxhbmQgT3kNCi0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQpJbnRlbCBG
aW5sYW5kIE95ClJlZ2lzdGVyZWQgQWRkcmVzczogUEwgMjgxLCAwMDE4MSBIZWxzaW5raSAKQnVz
aW5lc3MgSWRlbnRpdHkgQ29kZTogMDM1NzYwNiAtIDQgCkRvbWljaWxlZCBpbiBIZWxzaW5raSAK
ClRoaXMgZS1tYWlsIGFuZCBhbnkgYXR0YWNobWVudHMgbWF5IGNvbnRhaW4gY29uZmlkZW50aWFs
IG1hdGVyaWFsIGZvcgp0aGUgc29sZSB1c2Ugb2YgdGhlIGludGVuZGVkIHJlY2lwaWVudChzKS4g
QW55IHJldmlldyBvciBkaXN0cmlidXRpb24KYnkgb3RoZXJzIGlzIHN0cmljdGx5IHByb2hpYml0
ZWQuIElmIHlvdSBhcmUgbm90IHRoZSBpbnRlbmRlZApyZWNpcGllbnQsIHBsZWFzZSBjb250YWN0
IHRoZSBzZW5kZXIgYW5kIGRlbGV0ZSBhbGwgY29waWVzLgo=
WARNING: multiple messages have this Message-ID (diff)
From: "Shevchenko, Andriy" <andriy.shevchenko@intel.com>
To: "mans@mansr.com" <mans@mansr.com>
Cc: "anton.wuerfel@fau.de" <anton.wuerfel@fau.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mail@maciej.szmigiero.name" <mail@maciej.szmigiero.name>,
"desmondl@broadcom.com" <desmondl@broadcom.com>,
"Zha, Qipeng" <qipeng.zha@intel.com>,
"heikki.krogerus@linux.intel.com"
<heikki.krogerus@linux.intel.com>,
"long.wanglong@huawei.com" <long.wanglong@huawei.com>,
"soeren.grunewald@desy.de" <soeren.grunewald@desy.de>,
"deller@gmx.de" <deller@gmx.de>,
"jslaby@suse.com" <jslaby@suse.com>,
"phillip.raffeck@fau.de" <phillip.raffeck@fau.de>,
"paul.burton@imgtec.com" <paul.burton@imgtec.com>,
"hpeter@gmail.com" <hpeter@gmail.com>,
"ralf@linux-mips.org" <ralf@linux-mips.org>,
"linux-kernel@i4.cs.fau.de" <linux-kernel@i4.cs.fau.de>,
"adam.lee@canonical.com" <adam.lee@canonical.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"jejb@parisc-linux.org" <jejb@parisc-linux.org>,
"linux-parisc@vger.kernel.org" <linux-parisc@vger.kernel.org>,
"peter@hurleysoftware.com" <peter@hurleysoftware.com>,
"matt.redfearn@imgtec.com" <matt.redfearn@imgtec.com>,
"k.kozlowski@samsung.com" <k.kozlowski@samsung.com>
Subject: Re: [PATCH v4 01/13] tty: serial: 8250: Fix whitespace errors
Date: Mon, 11 Jan 2016 13:03:27 +0000 [thread overview]
Message-ID: <1452517435.26146.24.camel@intel.com> (raw)
In-Reply-To: <yw1x7fjgxonh.fsf@unicorn.mansr.com>
On Mon, 2016-01-11 at 12:54 +0000, Måns Rullgård wrote:
> "Shevchenko, Andriy" <andriy.shevchenko@intel.com> writes:
>
> > On Mon, 2016-01-11 at 14:28 +0200, Andy Shevchenko wrote:
> > > On Fri, 2016-01-08 at 18:43 +0100, Anton Wuerfel wrote:
> > > > This patch fixes whitespace errors reported by checkpatch to
> > > > increase
> > > > readability. Main focus is on missing spaces after commas in
> > > > function headers and macros (like foo,bar edited to foo, bar).
> > > >
> > > > Signed-off-by: Anton Würfel <anton.wuerfel@fau.de>
> > > > Signed-off-by: Phillip Raffeck <phillip.raffeck@fau.de>
> > > > CC: linux-kernel@i4.cs.fau.de
> > >
> > > Cc: looks more standard.
> > >
> > > > --- a/drivers/tty/serial/8250/8250_accent.c
> > > > +++ b/drivers/tty/serial/8250/8250_accent.c
> > > > @@ -10,7 +10,7 @@
> > > > #include <linux/init.h>
> > > > #include <linux/serial_8250.h>
> > > >
> > > > -#define PORT(_base,_irq) \
> > > > +#define PORT(_base, _irq) \
> > > > { \
> > > > .iobase = _base,
> > > > \
> > > > .irq = _irq,
> > > > \
> >
> > 8250_PORT()
> >
> > > >
> > >
> > > While those are okay, I would suggest to make a macro in
> > > drivers/…/8250.h one for all, something like this:
> > >
> > > #define 8250_PORT_FLAGS(_base, _irq, _flags)
> > > …
> > > .flags = UPF_BOOT_AUTOCONF | (_flags) \
> > >
> > > #define 8250_PORT(_base, _irq) 8250_PORT_FLAGS(_base,
> > > _irq, 0)
> > >
> > > And use it.
> >
> > #define 8250_FOURPORT(_base, _irq) 8250_PORT_FLAGS(_base,
> > _irq,
> > UPF_FOURPORT)
>
> Macro names can't start with a number.
Oh, right, thanks.
SERIAL8250_PORT* will work.
--
Andy Shevchenko <andriy.shevchenko@intel.com>
Intel Finland Oy
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki
Business Identity Code: 0357606 - 4
Domiciled in Helsinki
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
next prev parent reply other threads:[~2016-01-11 13:03 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 17:43 [PATCH v4 00/13] tty: serial: 8250: Fix checkpatch warnings Anton Wuerfel
2016-01-08 17:43 ` [PATCH v4 01/13] tty: serial: 8250: Fix whitespace errors Anton Wuerfel
2016-01-08 17:43 ` Anton Wuerfel
2016-01-11 12:28 ` Andy Shevchenko
2016-01-11 12:28 ` Andy Shevchenko
2016-01-11 12:50 ` Shevchenko, Andriy
2016-01-11 12:50 ` Shevchenko, Andriy
2016-01-11 12:54 ` Måns Rullgård
2016-01-11 12:54 ` Måns Rullgård
2016-01-11 13:03 ` Shevchenko, Andriy [this message]
2016-01-11 13:03 ` Shevchenko, Andriy
2016-01-08 17:43 ` [PATCH v4 02/13] tty: serial: 8250: Replace spaces with tabs Anton Wuerfel
2016-01-08 17:43 ` Anton Wuerfel
2016-01-08 17:43 ` [PATCH v4 03/13] tty: serial: 8250: Fix braces after struct Anton Wuerfel
2016-01-08 17:43 ` Anton Wuerfel
2016-01-08 17:43 ` [PATCH v4 04/13] tty: serial: 8250: Fix multiline comment style Anton Wuerfel
2016-01-08 17:43 ` Anton Wuerfel
2016-01-08 17:43 ` [PATCH v4 05/13] tty: serial: 8250: Remove else after return Anton Wuerfel
2016-01-08 17:43 ` Anton Wuerfel
2016-01-11 12:30 ` Andy Shevchenko
2016-01-11 12:30 ` Andy Shevchenko
2016-01-08 17:43 ` [PATCH v4 06/13] tty: serial: 8250: Move EXPORT_SYMBOL to function Anton Wuerfel
2016-01-08 17:43 ` Anton Wuerfel
2016-01-08 17:43 ` [PATCH v4 07/13] tty: serial: 8250: Fix line continuation warning Anton Wuerfel
2016-01-08 17:43 ` Anton Wuerfel
2016-01-08 17:43 ` [PATCH v4 08/13] tty: serial: 8250: Add parentheses to macro Anton Wuerfel
2016-01-08 17:43 ` Anton Wuerfel
2016-01-08 17:43 ` [PATCH v4 09/13] tty: serial: 8250: Fix multi-line strings Anton Wuerfel
2016-01-08 17:43 ` Anton Wuerfel
2016-01-08 17:43 ` [PATCH v4 10/13] tty: serial: 8250: Suitably replace printk Anton Wuerfel
2016-01-08 17:43 ` Anton Wuerfel
2016-01-11 12:38 ` Andy Shevchenko
2016-01-11 12:38 ` Andy Shevchenko
2016-01-08 17:43 ` [PATCH v4 11/13] tty: serial: 8250: Remove SERIAL_DEBUG_PNP macro Anton Wuerfel
2016-01-08 17:43 ` Anton Wuerfel
2016-01-08 17:43 ` [PATCH v4 12/13] tty: serial: 8250: Removed warning in debug output Anton Wuerfel
2016-01-08 17:43 ` Anton Wuerfel
2016-01-11 12:42 ` Andy Shevchenko
2016-01-11 12:42 ` Andy Shevchenko
2016-01-08 17:43 ` [PATCH v4 13/13] tty: serial: 8250: Fix indentation warnings Anton Wuerfel
2016-01-08 17:43 ` Anton Wuerfel
2016-01-11 12:47 ` Andy Shevchenko
2016-01-11 12:47 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452517435.26146.24.camel@intel.com \
--to=andriy.shevchenko@intel.com \
--cc=adam.lee@canonical.com \
--cc=anton.wuerfel@fau.de \
--cc=deller@gmx.de \
--cc=desmondl@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=hpeter@gmail.com \
--cc=jslaby@suse.com \
--cc=linux-kernel@i4.cs.fau.de \
--cc=linux-kernel@vger.kernel.org \
--cc=long.wanglong@huawei.com \
--cc=mail@maciej.szmigiero.name \
--cc=mans@mansr.com \
--cc=paul.burton@imgtec.com \
--cc=phillip.raffeck@fau.de \
--cc=qipeng.zha@intel.com \
--cc=ralf@linux-mips.org \
--cc=soeren.grunewald@desy.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.